2010-02-12 10:42:43

by Alberto Panizzo

Subject: [WARNING] mxc_w1_probe should not be __init modified

Today linux-next build, report this:

WARNING: drivers/w1/masters/built-in.o(.data+0x0): Section mismatch in reference from the variable mxc_w1_driver to the function .init.text:mxc_w1_probe()
The variable mxc_w1_driver references
the function __init mxc_w1_probe()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,


I don't know if should be modified with __devinit instead or nothing at all.

Best regards.

--
Alberto!

2010-02-12 11:01:06

by Uwe Kleine-König

Subject: Re: [WARNING] mxc_w1_probe should not be __init modified

Hello,

On Fri, Feb 12, 2010 at 11:42:28AM +0100, Alberto Panizzo wrote:
> Today linux-next build, report this:
>
> WARNING: drivers/w1/masters/built-in.o(.data+0x0): Section mismatch in reference from the variable mxc_w1_driver to the function .init.text:mxc_w1_probe()
> The variable mxc_w1_driver references
> the function __init mxc_w1_probe()
> If the reference is valid then annotate the
> variable with __init* or __refdata (see linux/init.h) or name the variable:
> *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,
>
>
> I don't know if should be modified with __devinit instead or nothing at all.
Yes it should use __devinit. If you need a reason, try

cd /sys/bus/platform/drivers/mxc_w1
echo -n mxc_w1.0 > unbind
echo -n mxc_w1.0 > bind

While at it, mxc_w1_remove can be moved to devexit.

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |