LinuxLists.cc - Re: [PATCH] Staging: wlan-ng: Fix 80 character limit warnings Fixed 2 warnings identified by the checkpatch.pl tool which occured due to two lines of code going over the 80 character limit. Fixed by wrapping the lines. Signed-off-by: Jim Dog <jimdog@

2010-02-21 15:07:19

Subject: Re: [PATCH] Staging: wlan-ng: Fix 80 character limit warnings Fixed 2 warnings identified by the checkpatch.pl tool which occured due to two lines of code going over the 80 character limit. Fixed by wrapping the lines. Signed-off-by: Jim Dog <jimdog@

On Sun, Feb 21, 2010 at 4:03 PM, <[email protected]> wrote:
> From: Jim Dog <[email protected]>
>
> ---
> ?drivers/staging/wlan-ng/prism2usb.c | ? ?9 ++++++---
> ?1 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/prism2usb.c b/drivers/staging/wlan-ng/prism2usb.c
> index 9dde68b..b55930c 100644
> --- a/drivers/staging/wlan-ng/prism2usb.c
> +++ b/drivers/staging/wlan-ng/prism2usb.c
> @@ -24,8 +24,9 @@ static struct usb_device_id usb_prism_tbl[] = {
> ? ? ? ? (0x066b, 0x2213, "Linksys WUSB12v1.1 11Mbps WLAN USB Adapter")},
> ? ? ? ?{PRISM_USB_DEVICE
> ? ? ? ? (0x067c, 0x1022, "Siemens SpeedStream 1022 11Mbps WLAN USB Adapter")},
> - ? ? ? {PRISM_USB_DEVICE(0x049f, 0x0033,
> - ? ? ? ? ? ? ? ? ? ? ? ? "Compaq/Intel W100 PRO/Wireless 11Mbps multiport WLAN Adapter")},
> + ? ? ? {PRISM_USB_DEVICE
> + ? ? ? ?(0x049f, 0x0033,
> + ? ? ? ? "Compaq/Intel W100 PRO/Wireless 11Mbps multiport WLAN Adapter")},
> ? ? ? ?{PRISM_USB_DEVICE
> ? ? ? ? (0x0411, 0x0016, "Melco WLI-USB-S11 11Mbps WLAN Adapter")},
> ? ? ? ?{PRISM_USB_DEVICE
> @@ -55,7 +56,9 @@ static struct usb_device_id usb_prism_tbl[] = {
> ? ? ? ? (0x04f1, 0x3009, "JVC MP-XP7250 Builtin USB WLAN Adapter")},
> ? ? ? ?{PRISM_USB_DEVICE(0x0846, 0x4110, "NetGear MA111")},
> ? ? ? ?{PRISM_USB_DEVICE(0x03f3, 0x0020, "Adaptec AWN-8020 USB WLAN Adapter")},
> -/* ? ? ?{PRISM_USB_DEVICE(0x0ace, 0x1201, "ZyDAS ZD1201 Wireless USB Adapter")}, */
> +/*
> + ? ? ? {PRISM_USB_DEVICE(0x0ace, 0x1201, "ZyDAS ZD1201 Wireless USB Adapter")},
> +*/

Why is this even included? We do have support for this in zd1201, and
I'm pretty sure wlan-ng doesn't actually handle it.

> ? ? ? ?{PRISM_USB_DEVICE(0x2821, 0x3300, "ASUS-WL140 Wireless USB Adapter")},
> ? ? ? ?{PRISM_USB_DEVICE(0x2001, 0x3700, "DWL-122 Wireless USB Adapter")},
> ? ? ? ?{PRISM_USB_DEVICE
> --
> 1.6.3.3
>
> _______________________________________________
> devel mailing list
> [email protected]
> http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
>

--
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)

2010-02-21 16:07:00

by JimDog

[permalink] [raw]

Subject: Re: [PATCH] Staging: wlan-ng: Fix 80 character limit warnings Fixed 2 warnings identified by the checkpatch.pl tool which occured due to two lines of code going over the 80 character limit. Fixed by wrapping the lines. Signed-off-by: Jim Dog <jimdog@

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Not sure, guess that's why it's commented out. I just wrapped it so it
fitted in 80 chars.

JD

G?bor Stefanik wrote:
> On Sun, Feb 21, 2010 at 4:03 PM, <[email protected]> wrote:
>> From: Jim Dog <[email protected]>
>>
>> ---
>> drivers/staging/wlan-ng/prism2usb.c | 9 ++++++---
>> 1 files changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/staging/wlan-ng/prism2usb.c b/drivers/staging/wlan-ng/prism2usb.c
>> index 9dde68b..b55930c 100644
>> --- a/drivers/staging/wlan-ng/prism2usb.c
>> +++ b/drivers/staging/wlan-ng/prism2usb.c
>> @@ -24,8 +24,9 @@ static struct usb_device_id usb_prism_tbl[] = {
>> (0x066b, 0x2213, "Linksys WUSB12v1.1 11Mbps WLAN USB Adapter")},
>> {PRISM_USB_DEVICE
>> (0x067c, 0x1022, "Siemens SpeedStream 1022 11Mbps WLAN USB Adapter")},
>> - {PRISM_USB_DEVICE(0x049f, 0x0033,
>> - "Compaq/Intel W100 PRO/Wireless 11Mbps multiport WLAN Adapter")},
>> + {PRISM_USB_DEVICE
>> + (0x049f, 0x0033,
>> + "Compaq/Intel W100 PRO/Wireless 11Mbps multiport WLAN Adapter")},
>> {PRISM_USB_DEVICE
>> (0x0411, 0x0016, "Melco WLI-USB-S11 11Mbps WLAN Adapter")},
>> {PRISM_USB_DEVICE
>> @@ -55,7 +56,9 @@ static struct usb_device_id usb_prism_tbl[] = {
>> (0x04f1, 0x3009, "JVC MP-XP7250 Builtin USB WLAN Adapter")},
>> {PRISM_USB_DEVICE(0x0846, 0x4110, "NetGear MA111")},
>> {PRISM_USB_DEVICE(0x03f3, 0x0020, "Adaptec AWN-8020 USB WLAN Adapter")},
>> -/* {PRISM_USB_DEVICE(0x0ace, 0x1201, "ZyDAS ZD1201 Wireless USB Adapter")}, */
>> +/*
>> + {PRISM_USB_DEVICE(0x0ace, 0x1201, "ZyDAS ZD1201 Wireless USB Adapter")},
>> +*/
>
> Why is this even included? We do have support for this in zd1201, and
> I'm pretty sure wlan-ng doesn't actually handle it.
>
>> {PRISM_USB_DEVICE(0x2821, 0x3300, "ASUS-WL140 Wireless USB Adapter")},
>> {PRISM_USB_DEVICE(0x2001, 0x3700, "DWL-122 Wireless USB Adapter")},
>> {PRISM_USB_DEVICE
>> --
>> 1.6.3.3
>>
>> _______________________________________________
>> devel mailing list
>> [email protected]
>> http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
>>
>
>
>

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkuBVUAACgkQjI3ttaQQxva7ywCgtB2/cbd+Tz+4WvvlyIGKwiFq
o6kAnjIu9lCZeIEb374pfZRoEU3G9oQx
=TKK4
-----END PGP SIGNATURE-----

2010-02-23 14:35:42

by Richard Kennedy

[permalink] [raw]

Subject: Re: [PATCH] Staging: wlan-ng: Fix 80 character limit warnings Fixed 2 warnings identified by the checkpatch.pl tool which occured due to two lines of code going over the 80 character limit. Fixed by wrapping the lines. Signed-off-by: Jim Dog <jimdog@

On Sun, 2010-02-21 at 16:06 +0100, Gábor Stefanik wrote:

> > +/*
> > + {PRISM_USB_DEVICE(0x0ace, 0x1201, "ZyDAS ZD1201 Wireless USB Adapter")},
> > +*/
>
> Why is this even included? We do have support for this in zd1201, and
> I'm pretty sure wlan-ng doesn't actually handle it.
>
In that case, let's just remove it. It's only clutter and may cause
confusion.
JD do you want to update your patch to get rid of this?

regards
Richard