2010-02-24 19:08:47

by Alessio Igor Bogani

Subject: [PATCH] Staging: Cleanup useless headers

BKL isn't anymore present into these files thus it is no necessary still include smp_lock.h.
---
drivers/staging/comedi/comedi_compat32.c | 1 -
drivers/staging/comedi/drivers/usbdux.c | 1 -
drivers/staging/comedi/drivers/usbduxfast.c | 1 -
drivers/staging/panel/panel.c | 1 -
4 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/comedi/comedi_compat32.c b/drivers/staging/comedi/comedi_compat32.c
index a9fdcda..581aa5f 100644
--- a/drivers/staging/comedi/comedi_compat32.c
+++ b/drivers/staging/comedi/comedi_compat32.c
@@ -26,7 +26,6 @@

#define __NO_VERSION__
#include "comedi.h"
-#include <linux/smp_lock.h>
#include <linux/uaccess.h>

#include "comedi_compat32.h"
diff --git a/drivers/staging/comedi/drivers/usbdux.c b/drivers/staging/comedi/drivers/usbdux.c
index 9a1b559..d400d43 100644
--- a/drivers/staging/comedi/drivers/usbdux.c
+++ b/drivers/staging/comedi/drivers/usbdux.c
@@ -95,7 +95,6 @@ sampling rate. If you sample two channels you get 4kHz and so on.
#include <linux/slab.h>
#include <linux/input.h>
#include <linux/usb.h>
-#include <linux/smp_lock.h>
#include <linux/fcntl.h>
#include <linux/compiler.h>
#include <linux/firmware.h>
diff --git a/drivers/staging/comedi/drivers/usbduxfast.c b/drivers/staging/comedi/drivers/usbduxfast.c
index 2e675cc..40512f5 100644
--- a/drivers/staging/comedi/drivers/usbduxfast.c
+++ b/drivers/staging/comedi/drivers/usbduxfast.c
@@ -44,7 +44,6 @@
#include <linux/slab.h>
#include <linux/input.h>
#include <linux/usb.h>
-#include <linux/smp_lock.h>
#include <linux/fcntl.h>
#include <linux/compiler.h>
#include "comedi_fc.h"
diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
index 95c93e8..377884f 100644
--- a/drivers/staging/panel/panel.c
+++ b/drivers/staging/panel/panel.c
@@ -41,7 +41,6 @@
#include <linux/signal.h>
#include <linux/sched.h>
#include <linux/spinlock.h>
-#include <linux/smp_lock.h>
#include <linux/interrupt.h>
#include <linux/miscdevice.h>
#include <linux/slab.h>
--
1.6.3.3

2010-02-26 00:13:30

by Greg KH

Subject: Re: [PATCH] Staging: Cleanup useless headers

On Wed, Feb 24, 2010 at 08:08:15PM +0100, Alessio Igor Bogani wrote:
> BKL isn't anymore present into these files thus it is no necessary still include smp_lock.h.
> ---

I need a "Signed-off-by:" in order to be able to apply a patch.

Care to resend this with it in it?

thanks,

greg k-h