2010-02-27 16:51:59

by Andrea Gelmini

[permalink] [raw]
Subject: Some simple Checkpatch.pl cleanup

Hi all,
here's some simple Checkpatch.pl cleanup.
They apply and compile on latest Linus' git tree¹ as well
as on next-20100226.

Thanks a lot for your work,
Andrea

--------------------------
¹ 06a79b82b2a3e4bebb9a20638ca208c780e9e507


2010-02-27 16:52:26

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 04/66] arch/um/include/asm/irq_vectors.h: Checkpatch cleanup

arch/um/include/asm/irq_vectors.h:1: ERROR: trailing whitespace

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/um/include/asm/irq_vectors.h | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/arch/um/include/asm/irq_vectors.h b/arch/um/include/asm/irq_vectors.h
index 272a81e..05cb834 100644
--- a/arch/um/include/asm/irq_vectors.h
+++ b/arch/um/include/asm/irq_vectors.h
@@ -1,4 +1,4 @@
-/*
+/*
* Copyright (C) 2002 Jeff Dike ([email protected])
* Licensed under the GPL
*/
@@ -7,4 +7,3 @@
#define __UM_IRQ_VECTORS_H

#endif
-
--
1.7.0.90.g251a4

2010-02-27 16:52:09

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 01/66] arch/parisc/include/asm/percpu.h: Checkpatch cleanup

arch/parisc/include/asm/percpu.h:6: ERROR: trailing whitespace

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/parisc/include/asm/percpu.h | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/arch/parisc/include/asm/percpu.h b/arch/parisc/include/asm/percpu.h
index a0dcd19..fb92561 100644
--- a/arch/parisc/include/asm/percpu.h
+++ b/arch/parisc/include/asm/percpu.h
@@ -3,5 +3,4 @@

#include <asm-generic/percpu.h>

-#endif
-
+#endif
--
1.7.0.90.g251a4

2010-02-27 16:52:12

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 02/66] fs/befs/inode.h: Checkpatch cleanup

fs/befs/inode.h:3: ERROR: trailing whitespace

Signed-off-by: Andrea Gelmini <[email protected]>
---
fs/befs/inode.h | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/fs/befs/inode.h b/fs/befs/inode.h
index 9dc7fd9..1dcefba 100644
--- a/fs/befs/inode.h
+++ b/fs/befs/inode.h
@@ -1,8 +1,7 @@
/*
* inode.h
- *
+ *
*/

int befs_check_inode(struct super_block *sb, befs_inode * raw_inode,
befs_blocknr_t inode);
-
--
1.7.0.90.g251a4

2010-02-27 16:52:19

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 03/66] arch/um/include/asm/mmu.h: Checkpatch cleanup

arch/um/include/asm/mmu.h:1: ERROR: trailing whitespace

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/um/include/asm/mmu.h | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/arch/um/include/asm/mmu.h b/arch/um/include/asm/mmu.h
index cf259de..2b201d9 100644
--- a/arch/um/include/asm/mmu.h
+++ b/arch/um/include/asm/mmu.h
@@ -1,4 +1,4 @@
-/*
+/*
* Copyright (C) 2002 Jeff Dike ([email protected])
* Licensed under the GPL
*/
@@ -9,4 +9,3 @@
#include "um_mmu.h"

#endif
-
--
1.7.0.90.g251a4

2010-02-27 16:52:41

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 07/66] arch/um/sys-ia64/sysdep/sigcontext.h: Checkpatch cleanup

arch/um/sys-ia64/sysdep/sigcontext.h:1: ERROR: trailing whitespace

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/um/sys-ia64/sysdep/sigcontext.h | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/arch/um/sys-ia64/sysdep/sigcontext.h b/arch/um/sys-ia64/sysdep/sigcontext.h
index 76b4316..f3caa4c 100644
--- a/arch/um/sys-ia64/sysdep/sigcontext.h
+++ b/arch/um/sys-ia64/sysdep/sigcontext.h
@@ -1,4 +1,4 @@
-/*
+/*
* Copyright (C) 2000 Jeff Dike ([email protected])
* Licensed under the GPL
*/
@@ -7,4 +7,3 @@
#define __SYSDEP_IA64_SIGCONTEXT_H

#endif
-
--
1.7.0.90.g251a4

2010-02-27 16:53:21

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 14/66] arch/um/sys-ia64/sysdep/ptrace.h: Checkpatch cleanup

arch/um/sys-ia64/sysdep/ptrace.h:1: ERROR: trailing whitespace

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/um/sys-ia64/sysdep/ptrace.h | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/arch/um/sys-ia64/sysdep/ptrace.h b/arch/um/sys-ia64/sysdep/ptrace.h
index 0f0f4e6..8e85f09 100644
--- a/arch/um/sys-ia64/sysdep/ptrace.h
+++ b/arch/um/sys-ia64/sysdep/ptrace.h
@@ -1,4 +1,4 @@
-/*
+/*
* Copyright (C) 2000 Jeff Dike ([email protected])
* Licensed under the GPL
*/
@@ -13,4 +13,3 @@ struct sys_pt_regs {
#define EMPTY_REGS { 0 }

#endif
-
--
1.7.0.90.g251a4

2010-02-27 16:52:59

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 10/66] arch/um/kernel/gprof_syms.c: Checkpatch cleanup

arch/um/kernel/gprof_syms.c:1: ERROR: trailing whitespace

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/um/kernel/gprof_syms.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/um/kernel/gprof_syms.c b/arch/um/kernel/gprof_syms.c
index e2f043d..ec82929 100644
--- a/arch/um/kernel/gprof_syms.c
+++ b/arch/um/kernel/gprof_syms.c
@@ -1,4 +1,4 @@
-/*
+/*
* Copyright (C) 2001 - 2007 Jeff Dike (jdike@{addtoit,linux.intel}.com)
* Licensed under the GPL
*/
--
1.7.0.90.g251a4

2010-02-27 16:52:45

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 08/66] arch/arm/mach-sa1100/include/mach/timex.h: Checkpatch cleanup

arch/arm/mach-sa1100/include/mach/timex.h:6: ERROR: trailing whitespace

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/arm/mach-sa1100/include/mach/timex.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-sa1100/include/mach/timex.h b/arch/arm/mach-sa1100/include/mach/timex.h
index 7a5d017..7dc68ec 100644
--- a/arch/arm/mach-sa1100/include/mach/timex.h
+++ b/arch/arm/mach-sa1100/include/mach/timex.h
@@ -3,7 +3,7 @@
*
* SA1100 architecture timex specifications
*
- * Copyright (C) 1998
+ * Copyright (C) 1998
*/

/*
--
1.7.0.90.g251a4

2010-02-27 16:53:33

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 15/66] arch/um/drivers/ssl.h: Checkpatch cleanup

arch/um/drivers/ssl.h:1: ERROR: trailing whitespace

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/um/drivers/ssl.h | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/arch/um/drivers/ssl.h b/arch/um/drivers/ssl.h
index 314d177..de82843 100644
--- a/arch/um/drivers/ssl.h
+++ b/arch/um/drivers/ssl.h
@@ -1,4 +1,4 @@
-/*
+/*
* Copyright (C) 2000 Jeff Dike ([email protected])
* Licensed under the GPL
*/
@@ -10,4 +10,3 @@ extern int ssl_read(int fd, int line);
extern void ssl_receive_char(int line, char ch);

#endif
-
--
1.7.0.90.g251a4

2010-02-27 16:53:05

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 11/66] arch/um/drivers/stdio_console.h: Checkpatch cleanup

arch/um/drivers/stdio_console.h:1: ERROR: trailing whitespace

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/um/drivers/stdio_console.h | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/arch/um/drivers/stdio_console.h b/arch/um/drivers/stdio_console.h
index 6d8275f..587cd2d 100644
--- a/arch/um/drivers/stdio_console.h
+++ b/arch/um/drivers/stdio_console.h
@@ -1,4 +1,4 @@
-/*
+/*
* Copyright (C) 2000 Jeff Dike ([email protected])
* Licensed under the GPL
*/
@@ -8,4 +8,3 @@

extern void save_console_flags(void);
#endif
-
--
1.7.0.90.g251a4

2010-02-27 16:52:51

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 09/66] arch/um/drivers/xterm.h: Checkpatch cleanup

arch/um/drivers/xterm.h:1: ERROR: trailing whitespace

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/um/drivers/xterm.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/um/drivers/xterm.h b/arch/um/drivers/xterm.h
index 56b9c4a..c5c8aac 100644
--- a/arch/um/drivers/xterm.h
+++ b/arch/um/drivers/xterm.h
@@ -1,4 +1,4 @@
-/*
+/*
* Copyright (C) 2002 Jeff Dike ([email protected])
* Licensed under the GPL
*/
--
1.7.0.90.g251a4

2010-02-27 16:53:39

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 16/66] arch/sparc/include/asm/setup.h: Checkpatch cleanup

arch/sparc/include/asm/setup.h:2: ERROR: trailing whitespace

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/sparc/include/asm/setup.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/sparc/include/asm/setup.h b/arch/sparc/include/asm/setup.h
index 2643c62..b1597f1 100644
--- a/arch/sparc/include/asm/setup.h
+++ b/arch/sparc/include/asm/setup.h
@@ -1,5 +1,5 @@
/*
- * Just a place holder.
+ * Just a place holder.
*/

#ifndef _SPARC_SETUP_H
--
1.7.0.90.g251a4

2010-02-27 16:53:14

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 12/66] arch/cris/include/asm/kmap_types.h: Checkpatch cleanup

arch/cris/include/asm/kmap_types.h:5: ERROR: trailing whitespace

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/cris/include/asm/kmap_types.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/cris/include/asm/kmap_types.h b/arch/cris/include/asm/kmap_types.h
index d2d643c..eff255e 100644
--- a/arch/cris/include/asm/kmap_types.h
+++ b/arch/cris/include/asm/kmap_types.h
@@ -2,7 +2,7 @@
#define _ASM_KMAP_TYPES_H

/* Dummy header just to define km_type. None of this
- * is actually used on cris.
+ * is actually used on cris.
*/

#include <asm-generic/kmap_types.h>
--
1.7.0.90.g251a4

2010-02-27 16:53:50

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 18/66] arch/um/include/shared/skas_ptrace.h: Checkpatch cleanup

arch/um/include/shared/skas_ptrace.h:1: ERROR: trailing whitespace

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/um/include/shared/skas_ptrace.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/um/include/shared/skas_ptrace.h b/arch/um/include/shared/skas_ptrace.h
index 3d31bba..38dfbd2 100644
--- a/arch/um/include/shared/skas_ptrace.h
+++ b/arch/um/include/shared/skas_ptrace.h
@@ -1,4 +1,4 @@
-/*
+/*
* Copyright (C) 2000 - 2007 Jeff Dike (jdike@{addtoit,linux.intel}.com)
* Licensed under the GPL
*/
--
1.7.0.90.g251a4

2010-02-27 16:54:51

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 29/66] arch/s390/include/asm/unaligned.h: Checkpatch cleanup

arch/s390/include/asm/unaligned.h:5: ERROR: trailing whitespace

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/s390/include/asm/unaligned.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/s390/include/asm/unaligned.h b/arch/s390/include/asm/unaligned.h
index da9627a..1ce42c3 100644
--- a/arch/s390/include/asm/unaligned.h
+++ b/arch/s390/include/asm/unaligned.h
@@ -2,7 +2,7 @@
#define _ASM_S390_UNALIGNED_H

/*
- * The S390 can do unaligned accesses itself.
+ * The S390 can do unaligned accesses itself.
*/
#include <linux/unaligned/access_ok.h>
#include <linux/unaligned/generic.h>
--
1.7.0.90.g251a4

2010-02-27 16:54:32

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 26/66] fs/befs/btree.h: Checkpatch cleanup

fs/befs/btree.h:3: ERROR: trailing whitespace
fs/befs/btree.h:12: ERROR: "foo * bar" should be "foo *bar"

Signed-off-by: Andrea Gelmini <[email protected]>
---
fs/befs/btree.h | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/fs/befs/btree.h b/fs/befs/btree.h
index 92e781e..9c85aea 100644
--- a/fs/befs/btree.h
+++ b/fs/befs/btree.h
@@ -1,6 +1,6 @@
/*
* btree.h
- *
+ *
*/


@@ -9,5 +9,4 @@ int befs_btree_find(struct super_block *sb, befs_data_stream * ds,

int befs_btree_read(struct super_block *sb, befs_data_stream * ds,
loff_t key_no, size_t bufsize, char *keybuf,
- size_t * keysize, befs_off_t * value);
-
+ size_t *keysize, befs_off_t *value);
--
1.7.0.90.g251a4

2010-02-27 16:54:05

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 20/66] arch/cris/include/asm/current.h: Checkpatch cleanup

arch/cris/include/asm/current.h:8: ERROR: "foo * bar" should be "foo *bar"
arch/cris/include/asm/current.h:10: ERROR: code indent should use tabs where possible
arch/cris/include/asm/current.h:12: ERROR: trailing whitespace

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/cris/include/asm/current.h | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/cris/include/asm/current.h b/arch/cris/include/asm/current.h
index 5f5c0ef..e846834 100644
--- a/arch/cris/include/asm/current.h
+++ b/arch/cris/include/asm/current.h
@@ -5,11 +5,11 @@

struct task_struct;

-static inline struct task_struct * get_current(void)
+static inline struct task_struct *get_current(void)
{
- return current_thread_info()->task;
+ return current_thread_info()->task;
}
-
+
#define current get_current()

#endif /* !(_CRIS_CURRENT_H) */
--
1.7.0.90.g251a4

2010-02-27 16:54:13

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 22/66] sound/oss/v_midi.h: Checkpatch cleanup

sound/oss/v_midi.h:5: ERROR: code indent should use tabs where possible
sound/oss/v_midi.h:7: ERROR: trailing whitespace

Signed-off-by: Andrea Gelmini <[email protected]>
---
sound/oss/v_midi.h | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/sound/oss/v_midi.h b/sound/oss/v_midi.h
index 1b86cb4..08e2185 100644
--- a/sound/oss/v_midi.h
+++ b/sound/oss/v_midi.h
@@ -2,9 +2,9 @@ typedef struct vmidi_devc {
int dev;

/* State variables */
- int opened;
+ int opened;
spinlock_t lock;
-
+
/* MIDI fields */
int my_mididev;
int pair_mididev;
@@ -12,4 +12,3 @@ typedef struct vmidi_devc {
int intr_active;
void (*midi_input_intr) (int dev, unsigned char data);
} vmidi_devc;
-
--
1.7.0.90.g251a4

2010-02-27 16:54:25

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 24/66] arch/h8300/include/asm/tlb.h: Checkpatch cleanup

arch/h8300/include/asm/tlb.h:1: ERROR: trailing whitespace
arch/h8300/include/asm/tlb.h:2: ERROR: trailing whitespace
arch/h8300/include/asm/tlb.h:10: ERROR: trailing whitespace
arch/h8300/include/asm/tlb.h:11: ERROR: trailing whitespace

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/h8300/include/asm/tlb.h | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/h8300/include/asm/tlb.h b/arch/h8300/include/asm/tlb.h
index 3dea80a..54e30d4 100644
--- a/arch/h8300/include/asm/tlb.h
+++ b/arch/h8300/include/asm/tlb.h
@@ -1,5 +1,5 @@
-/*
- include/asm-h8300/tlb.h
+/*
+ include/asm-h8300/tlb.h
*/

#ifndef __H8300_TLB_H__
@@ -7,8 +7,8 @@

#define tlb_flush(tlb) do { } while(0)

-/*
- include/asm-h8300/tlb.h
+/*
+ include/asm-h8300/tlb.h
*/

#ifndef __H8300_TLB_H__
--
1.7.0.90.g251a4

2010-02-27 16:53:58

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 19/66] arch/parisc/include/asm/current.h: Checkpatch cleanup

arch/parisc/include/asm/current.h:8: ERROR: "foo * bar" should be "foo *bar"
arch/parisc/include/asm/current.h:12: ERROR: trailing whitespace

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/parisc/include/asm/current.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/parisc/include/asm/current.h b/arch/parisc/include/asm/current.h
index 0fb9338..4cbf4ad 100644
--- a/arch/parisc/include/asm/current.h
+++ b/arch/parisc/include/asm/current.h
@@ -5,11 +5,11 @@

struct task_struct;

-static inline struct task_struct * get_current(void)
+static inline struct task_struct *get_current(void)
{
return current_thread_info()->task;
}
-
+
#define current get_current()

#endif /* !(_PARISC_CURRENT_H) */
--
1.7.0.90.g251a4

2010-02-27 16:54:41

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 27/66] include/linux/raw.h: Checkpatch cleanup

include/linux/raw.h:6: ERROR: space prohibited after that open parenthesis '('
include/linux/raw.h:6: ERROR: space prohibited before that close parenthesis ')'
include/linux/raw.h:7: ERROR: space prohibited after that open parenthesis '('
include/linux/raw.h:7: ERROR: space prohibited before that close parenthesis ')'
include/linux/raw.h:9: ERROR: trailing whitespace
include/linux/raw.h:10: ERROR: open brace '{' following struct go on the same line

Signed-off-by: Andrea Gelmini <[email protected]>
---
include/linux/raw.h | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/include/linux/raw.h b/include/linux/raw.h
index 62d543e..01d635b 100644
--- a/include/linux/raw.h
+++ b/include/linux/raw.h
@@ -3,11 +3,10 @@

#include <linux/types.h>

-#define RAW_SETBIND _IO( 0xac, 0 )
-#define RAW_GETBIND _IO( 0xac, 1 )
+#define RAW_SETBIND _IO(0xac, 0)
+#define RAW_GETBIND _IO(0xac, 1)

-struct raw_config_request
-{
+struct raw_config_request {
int raw_minor;
__u64 block_major;
__u64 block_minor;
--
1.7.0.90.g251a4

2010-02-27 16:55:26

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 34/66] arch/um/os-Linux/drivers/etap.h: Checkpatch cleanup

arch/um/os-Linux/drivers/etap.h:1: ERROR: trailing whitespace

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/um/os-Linux/drivers/etap.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/um/os-Linux/drivers/etap.h b/arch/um/os-Linux/drivers/etap.h
index ddffd41..0df8526 100644
--- a/arch/um/os-Linux/drivers/etap.h
+++ b/arch/um/os-Linux/drivers/etap.h
@@ -1,4 +1,4 @@
-/*
+/*
* Copyright (C) 2001 - 2007 Jeff Dike (jdike@{addtoit,linux.intel}.com)
* Licensed under the GPL
*/
--
1.7.0.90.g251a4

2010-02-27 16:55:36

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 35/66] arch/cris/include/arch-v10/arch/tlb.h: Checkpatch cleanup

arch/cris/include/arch-v10/arch/tlb.h:6: ERROR: trailing whitespace

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/cris/include/arch-v10/arch/tlb.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/cris/include/arch-v10/arch/tlb.h b/arch/cris/include/arch-v10/arch/tlb.h
index 31525bb..d565bd8 100644
--- a/arch/cris/include/arch-v10/arch/tlb.h
+++ b/arch/cris/include/arch-v10/arch/tlb.h
@@ -3,7 +3,7 @@

/* The TLB can host up to 64 different mm contexts at the same time.
* The last page_id is never running - it is used as an invalid page_id
- * so we can make TLB entries that will never match.
+ * so we can make TLB entries that will never match.
*/
#define NUM_TLB_ENTRIES 64
#define NUM_PAGEID 64
--
1.7.0.90.g251a4

2010-02-27 16:55:44

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 38/66] sound/oss/coproc.h: Checkpatch cleanup

sound/oss/coproc.h:7: ERROR: trailing whitespace

Signed-off-by: Andrea Gelmini <[email protected]>
---
sound/oss/coproc.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/oss/coproc.h b/sound/oss/coproc.h
index 7306346..7bec21b 100644
--- a/sound/oss/coproc.h
+++ b/sound/oss/coproc.h
@@ -4,7 +4,7 @@
*/

/*
- * Coprocessor access types
+ * Coprocessor access types
*/
#define COPR_CUSTOM 0x0001 /* Custom applications */
#define COPR_MIDI 0x0002 /* MIDI (MPU-401) emulation */
--
1.7.0.90.g251a4

2010-02-27 16:55:52

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 39/66] arch/um/drivers/pcap_user.h: Checkpatch cleanup

arch/um/drivers/pcap_user.h:1: ERROR: trailing whitespace

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/um/drivers/pcap_user.h | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/arch/um/drivers/pcap_user.h b/arch/um/drivers/pcap_user.h
index d8ba615..6ff1c46 100644
--- a/arch/um/drivers/pcap_user.h
+++ b/arch/um/drivers/pcap_user.h
@@ -1,4 +1,4 @@
-/*
+/*
* Copyright (C) 2002 Jeff Dike ([email protected])
* Licensed under the GPL
*/
@@ -18,4 +18,3 @@ struct pcap_data {
extern const struct net_user_info pcap_user_info;

extern int pcap_user_read(int fd, void *buf, int len, struct pcap_data *pri);
-
--
1.7.0.90.g251a4

2010-02-27 16:55:57

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 40/66] include/linux/netfilter/nf_conntrack_tuple_common.h: Checkpatch cleanup

include/linux/netfilter/nf_conntrack_tuple_common.h:5: ERROR: open brace '{' following enum go on the same line

Signed-off-by: Andrea Gelmini <[email protected]>
---
.../linux/netfilter/nf_conntrack_tuple_common.h | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/include/linux/netfilter/nf_conntrack_tuple_common.h b/include/linux/netfilter/nf_conntrack_tuple_common.h
index 8e145f0..2ea22b0 100644
--- a/include/linux/netfilter/nf_conntrack_tuple_common.h
+++ b/include/linux/netfilter/nf_conntrack_tuple_common.h
@@ -1,8 +1,7 @@
#ifndef _NF_CONNTRACK_TUPLE_COMMON_H
#define _NF_CONNTRACK_TUPLE_COMMON_H

-enum ip_conntrack_dir
-{
+enum ip_conntrack_dir {
IP_CT_DIR_ORIGINAL,
IP_CT_DIR_REPLY,
IP_CT_DIR_MAX
--
1.7.0.90.g251a4

2010-02-27 16:56:08

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 41/66] drivers/md/linear.h: Checkpatch cleanup

drivers/md/linear.h:12: ERROR: open brace '{' following struct go on the same line

Signed-off-by: Andrea Gelmini <[email protected]>
---
drivers/md/linear.h | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/md/linear.h b/drivers/md/linear.h
index 0ce29b6..3860fd8 100644
--- a/drivers/md/linear.h
+++ b/drivers/md/linear.h
@@ -8,8 +8,7 @@ struct dev_info {

typedef struct dev_info dev_info_t;

-struct linear_private_data
-{
+struct linear_private_data {
sector_t array_sectors;
dev_info_t disks[0];
struct rcu_head rcu;
--
1.7.0.90.g251a4

2010-02-27 16:56:19

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 42/66] arch/mips/lib/libgcc.h: Checkpatch cleanup

arch/mips/lib/libgcc.h:21: ERROR: open brace '{' following union go on the same line

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/mips/lib/libgcc.h | 3 +--
arch/sh/lib/libgcc.h | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/mips/lib/libgcc.h b/arch/mips/lib/libgcc.h
index 3f19d1c..05909d5 100644
--- a/arch/mips/lib/libgcc.h
+++ b/arch/mips/lib/libgcc.h
@@ -17,8 +17,7 @@ struct DWstruct {
#error I feel sick.
#endif

-typedef union
-{
+typedef union {
struct DWstruct s;
long long ll;
} DWunion;
diff --git a/arch/sh/lib/libgcc.h b/arch/sh/lib/libgcc.h
index 3f19d1c..05909d5 100644
--- a/arch/sh/lib/libgcc.h
+++ b/arch/sh/lib/libgcc.h
@@ -17,8 +17,7 @@ struct DWstruct {
#error I feel sick.
#endif

-typedef union
-{
+typedef union {
struct DWstruct s;
long long ll;
} DWunion;
--
1.7.0.90.g251a4

2010-02-27 16:57:11

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 49/66] arch/cris/include/arch-v32/arch/intmem.h: Checkpatch cleanup

arch/cris/include/arch-v32/arch/intmem.h:4: ERROR: "foo* bar" should be "foo *bar"
arch/cris/include/arch-v32/arch/intmem.h:5: ERROR: "foo* bar" should be "foo *bar"
arch/cris/include/arch-v32/arch/intmem.h:6: ERROR: "foo* bar" should be "foo *bar"

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/cris/include/arch-v32/arch/intmem.h | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/cris/include/arch-v32/arch/intmem.h b/arch/cris/include/arch-v32/arch/intmem.h
index c0ada33..46b05ee 100644
--- a/arch/cris/include/arch-v32/arch/intmem.h
+++ b/arch/cris/include/arch-v32/arch/intmem.h
@@ -1,9 +1,9 @@
#ifndef _ASM_CRIS_INTMEM_H
#define _ASM_CRIS_INTMEM_H

-void* crisv32_intmem_alloc(unsigned size, unsigned align);
-void crisv32_intmem_free(void* addr);
-void* crisv32_intmem_phys_to_virt(unsigned long addr);
+void *crisv32_intmem_alloc(unsigned size, unsigned align);
+void crisv32_intmem_free(void *addr);
+void *crisv32_intmem_phys_to_virt(unsigned long addr);
unsigned long crisv32_intmem_virt_to_phys(void *addr);

#endif /* _ASM_CRIS_ARCH_INTMEM_H */
--
1.7.0.90.g251a4

2010-02-27 16:56:34

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 47/66] drivers/isdn/hardware/eicon/os_pri.h: Checkpatch cleanup

drivers/isdn/hardware/eicon/os_pri.h:6: ERROR: "foo * bar" should be "foo *bar"

Signed-off-by: Andrea Gelmini <[email protected]>
---
drivers/isdn/hardware/eicon/os_pri.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/isdn/hardware/eicon/os_pri.h b/drivers/isdn/hardware/eicon/os_pri.h
index a7c42f9..537c74d 100644
--- a/drivers/isdn/hardware/eicon/os_pri.h
+++ b/drivers/isdn/hardware/eicon/os_pri.h
@@ -3,6 +3,6 @@
#ifndef __DIVA_OS_PRI_REV_1_H__
#define __DIVA_OS_PRI_REV_1_H__

-int diva_pri_init_card(diva_os_xdi_adapter_t * a);
+int diva_pri_init_card(diva_os_xdi_adapter_t *a);

#endif
--
1.7.0.90.g251a4

2010-02-27 16:57:33

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 55/66] arch/sh/boot/compressed/cache.c: Checkpatch cleanup

arch/sh/boot/compressed/cache.c:8: WARNING: space prohibited between function name and open parenthesis '('

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/sh/boot/compressed/cache.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/sh/boot/compressed/cache.c b/arch/sh/boot/compressed/cache.c
index e27fc74..d0b77b6 100644
--- a/arch/sh/boot/compressed/cache.c
+++ b/arch/sh/boot/compressed/cache.c
@@ -5,7 +5,7 @@ int cache_control(unsigned int command)

for (i = 0; i < (32 * 1024); i += 32) {
(void)*p;
- p += (32 / sizeof (int));
+ p += (32 / sizeof(int));
}

return 0;
--
1.7.0.90.g251a4

2010-02-27 16:57:20

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 52/66] arch/m68k/hp300/time.h: Checkpatch cleanup

arch/m68k/hp300/time.h:2: WARNING: space prohibited between function name and open parenthesis '('

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/m68k/hp300/time.h | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/arch/m68k/hp300/time.h b/arch/m68k/hp300/time.h
index f5b3d09..7b98242 100644
--- a/arch/m68k/hp300/time.h
+++ b/arch/m68k/hp300/time.h
@@ -1,4 +1,2 @@
extern void hp300_sched_init(irq_handler_t vector);
-extern unsigned long hp300_gettimeoffset (void);
-
-
+extern unsigned long hp300_gettimeoffset(void);
--
1.7.0.90.g251a4

2010-02-27 16:56:55

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 45/66] drivers/isdn/hardware/eicon/os_4bri.h: Checkpatch cleanup

drivers/isdn/hardware/eicon/os_4bri.h:6: ERROR: "foo * bar" should be "foo *bar"

Signed-off-by: Andrea Gelmini <[email protected]>
---
drivers/isdn/hardware/eicon/os_4bri.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/isdn/hardware/eicon/os_4bri.h b/drivers/isdn/hardware/eicon/os_4bri.h
index 665f0af..7225327 100644
--- a/drivers/isdn/hardware/eicon/os_4bri.h
+++ b/drivers/isdn/hardware/eicon/os_4bri.h
@@ -3,6 +3,6 @@
#ifndef __DIVA_OS_4_BRI_H__
#define __DIVA_OS_4_BRI_H__

-int diva_4bri_init_card(diva_os_xdi_adapter_t * a);
+int diva_4bri_init_card(diva_os_xdi_adapter_t *a);

#endif
--
1.7.0.90.g251a4

2010-02-27 16:56:29

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 43/66] arch/um/include/shared/sysrq.h: Checkpatch cleanup

arch/um/include/shared/sysrq.h:5: ERROR: "foo* bar" should be "foo *bar"

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/um/include/shared/sysrq.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/um/include/shared/sysrq.h b/arch/um/include/shared/sysrq.h
index c8d332b..19181a9 100644
--- a/arch/um/include/shared/sysrq.h
+++ b/arch/um/include/shared/sysrq.h
@@ -2,6 +2,6 @@
#define __UM_SYSRQ_H

struct task_struct;
-extern void show_trace(struct task_struct* task, unsigned long *stack);
+extern void show_trace(struct task_struct *task, unsigned long *stack);

#endif
--
1.7.0.90.g251a4

2010-02-27 16:57:27

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 54/66] include/asm-generic/kdebug.h: Checkpatch cleanup

include/asm-generic/kdebug.h:6: ERROR: spaces required around that '=' (ctx:VxV)

Signed-off-by: Andrea Gelmini <[email protected]>
---
include/asm-generic/kdebug.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/asm-generic/kdebug.h b/include/asm-generic/kdebug.h
index 11e57b6..832be39 100644
--- a/include/asm-generic/kdebug.h
+++ b/include/asm-generic/kdebug.h
@@ -3,7 +3,7 @@

enum die_val {
DIE_UNUSED,
- DIE_OOPS=1
+ DIE_OOPS = 1
};

#endif /* _ASM_GENERIC_KDEBUG_H */
--
1.7.0.90.g251a4

2010-02-27 16:57:42

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 56/66] include/linux/mtd/mtdram.h: Checkpatch cleanup

include/linux/mtd/mtdram.h:6: ERROR: code indent should use tabs where possible

Signed-off-by: Andrea Gelmini <[email protected]>
---
include/linux/mtd/mtdram.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/mtd/mtdram.h b/include/linux/mtd/mtdram.h
index 04fdc07..6889131 100644
--- a/include/linux/mtd/mtdram.h
+++ b/include/linux/mtd/mtdram.h
@@ -3,6 +3,6 @@

#include <linux/mtd/mtd.h>
int mtdram_init_device(struct mtd_info *mtd, void *mapped_address,
- unsigned long size, char *name);
+ unsigned long size, char *name);

#endif /* __MTD_MTDRAM_H__ */
--
1.7.0.90.g251a4

2010-02-27 16:57:55

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 59/66] arch/cris/include/arch-v10/arch/thread_info.h: Checkpatch cleanup

arch/cris/include/arch-v10/arch/thread_info.h:8: ERROR: code indent should use tabs where possible
arch/cris/include/arch-v10/arch/thread_info.h:8: ERROR: spaces required around that ':' (ctx:VxV)
arch/cris/include/arch-v10/arch/thread_info.h:9: ERROR: code indent should use tabs where possible

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/cris/include/arch-v10/arch/thread_info.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/cris/include/arch-v10/arch/thread_info.h b/arch/cris/include/arch-v10/arch/thread_info.h
index 218f415..218ceb8 100644
--- a/arch/cris/include/arch-v10/arch/thread_info.h
+++ b/arch/cris/include/arch-v10/arch/thread_info.h
@@ -5,8 +5,8 @@
static inline struct thread_info *current_thread_info(void)
{
struct thread_info *ti;
- __asm__("and.d $sp,%0; ":"=r" (ti) : "0" (~8191UL));
- return ti;
+ __asm__("and.d $sp,%0; " : "=r" (ti) : "0" (~8191UL));
+ return ti;
}

#endif
--
1.7.0.90.g251a4

2010-02-27 16:56:49

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 46/66] drivers/isdn/hardware/eicon/os_bri.h: Checkpatch cleanup

drivers/isdn/hardware/eicon/os_bri.h:6: ERROR: "foo * bar" should be "foo *bar"

Signed-off-by: Andrea Gelmini <[email protected]>
---
drivers/isdn/hardware/eicon/os_bri.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/isdn/hardware/eicon/os_bri.h b/drivers/isdn/hardware/eicon/os_bri.h
index a54f0ce..02e7456 100644
--- a/drivers/isdn/hardware/eicon/os_bri.h
+++ b/drivers/isdn/hardware/eicon/os_bri.h
@@ -3,6 +3,6 @@
#ifndef __DIVA_OS_BRI_REV_1_H__
#define __DIVA_OS_BRI_REV_1_H__

-int diva_bri_init_card(diva_os_xdi_adapter_t * a);
+int diva_bri_init_card(diva_os_xdi_adapter_t *a);

#endif
--
1.7.0.90.g251a4

2010-02-27 16:58:00

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 60/66] arch/um/sys-i386/shared/sysdep/vm-flags.h: Checkpatch cleanup

arch/um/sys-i386/shared/sysdep/vm-flags.h:11: ERROR: space prohibited before that close parenthesis ')'

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/um/sys-i386/shared/sysdep/vm-flags.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/um/sys-i386/shared/sysdep/vm-flags.h b/arch/um/sys-i386/shared/sysdep/vm-flags.h
index e0d24c5..881afd7 100644
--- a/arch/um/sys-i386/shared/sysdep/vm-flags.h
+++ b/arch/um/sys-i386/shared/sysdep/vm-flags.h
@@ -8,7 +8,7 @@

#define VM_DATA_DEFAULT_FLAGS \
(VM_READ | VM_WRITE | \
- ((current->personality & READ_IMPLIES_EXEC) ? VM_EXEC : 0 ) | \
+ ((current->personality & READ_IMPLIES_EXEC) ? VM_EXEC : 0) | \
VM_MAYREAD | VM_MAYWRITE | VM_MAYEXEC)

#endif
--
1.7.0.90.g251a4

2010-02-27 16:58:43

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH] fs/nls/nls_cp949.c: Checkpatch cleanup

fs/nls/nls_cp949.c:4437: ERROR: trailing whitespace
[snip]
fs/nls/nls_cp949.c:13786: ERROR: trailing whitespace
fs/nls/nls_cp949.c:13882: ERROR: spaces required around that '==' (ctx:VxV)
fs/nls/nls_cp949.c:13886: ERROR: else should follow close brace '}'

Signed-off-by: Andrea Gelmini <[email protected]>
---
fs/nls/nls_cp949.c | 131 ++++++++++++++++++++++++++--------------------------
1 files changed, 65 insertions(+), 66 deletions(-)

diff --git a/fs/nls/nls_cp949.c b/fs/nls/nls_cp949.c
index 8a7a2fe..296425d 100644
--- a/fs/nls/nls_cp949.c
+++ b/fs/nls/nls_cp949.c
@@ -4434,38 +4434,38 @@ static const wchar_t c2u_FD[256] = {
};

static const wchar_t *page_charset2uni[256] = {
- NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
- NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
- NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
- NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
- NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
- NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
- NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
- NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
- NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
- NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
- NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
- NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
- NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
- NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
- NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
- NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
- NULL, c2u_81, c2u_82, c2u_83, c2u_84, c2u_85, c2u_86, c2u_87,
- c2u_88, c2u_89, c2u_8A, c2u_8B, c2u_8C, c2u_8D, c2u_8E, c2u_8F,
- c2u_90, c2u_91, c2u_92, c2u_93, c2u_94, c2u_95, c2u_96, c2u_97,
- c2u_98, c2u_99, c2u_9A, c2u_9B, c2u_9C, c2u_9D, c2u_9E, c2u_9F,
- c2u_A0, c2u_A1, c2u_A2, c2u_A3, c2u_A4, c2u_A5, c2u_A6, c2u_A7,
- c2u_A8, c2u_A9, c2u_AA, c2u_AB, c2u_AC, c2u_AD, c2u_AE, c2u_AF,
- c2u_B0, c2u_B1, c2u_B2, c2u_B3, c2u_B4, c2u_B5, c2u_B6, c2u_B7,
- c2u_B8, c2u_B9, c2u_BA, c2u_BB, c2u_BC, c2u_BD, c2u_BE, c2u_BF,
- c2u_C0, c2u_C1, c2u_C2, c2u_C3, c2u_C4, c2u_C5, c2u_C6, c2u_C7,
- c2u_C8, NULL, c2u_CA, c2u_CB, c2u_CC, c2u_CD, c2u_CE, c2u_CF,
- c2u_D0, c2u_D1, c2u_D2, c2u_D3, c2u_D4, c2u_D5, c2u_D6, c2u_D7,
- c2u_D8, c2u_D9, c2u_DA, c2u_DB, c2u_DC, c2u_DD, c2u_DE, c2u_DF,
- c2u_E0, c2u_E1, c2u_E2, c2u_E3, c2u_E4, c2u_E5, c2u_E6, c2u_E7,
- c2u_E8, c2u_E9, c2u_EA, c2u_EB, c2u_EC, c2u_ED, c2u_EE, c2u_EF,
- c2u_F0, c2u_F1, c2u_F2, c2u_F3, c2u_F4, c2u_F5, c2u_F6, c2u_F7,
- c2u_F8, c2u_F9, c2u_FA, c2u_FB, c2u_FC, c2u_FD, NULL, NULL,
+ NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
+ NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
+ NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
+ NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
+ NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
+ NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
+ NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
+ NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
+ NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
+ NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
+ NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
+ NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
+ NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
+ NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
+ NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
+ NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
+ NULL, c2u_81, c2u_82, c2u_83, c2u_84, c2u_85, c2u_86, c2u_87,
+ c2u_88, c2u_89, c2u_8A, c2u_8B, c2u_8C, c2u_8D, c2u_8E, c2u_8F,
+ c2u_90, c2u_91, c2u_92, c2u_93, c2u_94, c2u_95, c2u_96, c2u_97,
+ c2u_98, c2u_99, c2u_9A, c2u_9B, c2u_9C, c2u_9D, c2u_9E, c2u_9F,
+ c2u_A0, c2u_A1, c2u_A2, c2u_A3, c2u_A4, c2u_A5, c2u_A6, c2u_A7,
+ c2u_A8, c2u_A9, c2u_AA, c2u_AB, c2u_AC, c2u_AD, c2u_AE, c2u_AF,
+ c2u_B0, c2u_B1, c2u_B2, c2u_B3, c2u_B4, c2u_B5, c2u_B6, c2u_B7,
+ c2u_B8, c2u_B9, c2u_BA, c2u_BB, c2u_BC, c2u_BD, c2u_BE, c2u_BF,
+ c2u_C0, c2u_C1, c2u_C2, c2u_C3, c2u_C4, c2u_C5, c2u_C6, c2u_C7,
+ c2u_C8, NULL, c2u_CA, c2u_CB, c2u_CC, c2u_CD, c2u_CE, c2u_CF,
+ c2u_D0, c2u_D1, c2u_D2, c2u_D3, c2u_D4, c2u_D5, c2u_D6, c2u_D7,
+ c2u_D8, c2u_D9, c2u_DA, c2u_DB, c2u_DC, c2u_DD, c2u_DE, c2u_DF,
+ c2u_E0, c2u_E1, c2u_E2, c2u_E3, c2u_E4, c2u_E5, c2u_E6, c2u_E7,
+ c2u_E8, c2u_E9, c2u_EA, c2u_EB, c2u_EC, c2u_ED, c2u_EE, c2u_EF,
+ c2u_F0, c2u_F1, c2u_F2, c2u_F3, c2u_F4, c2u_F5, c2u_F6, c2u_F7,
+ c2u_F8, c2u_F9, c2u_FA, c2u_FB, c2u_FC, c2u_FD, NULL, NULL,
};

static const unsigned char u2c_01[512] = {
@@ -13753,37 +13753,37 @@ static const unsigned char u2c_FF[512] = {
};

static const unsigned char *const page_uni2charset[256] = {
- NULL, u2c_01, u2c_02, u2c_03, u2c_04, NULL, NULL, NULL,
- NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
- NULL, u2c_11, NULL, NULL, NULL, NULL, NULL, NULL,
- NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
- u2c_20, u2c_21, u2c_22, u2c_23, u2c_24, u2c_25, u2c_26, NULL,
- NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
- u2c_30, u2c_31, u2c_32, u2c_33, NULL, NULL, NULL, NULL,
- NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
- NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
- NULL, NULL, NULL, NULL, NULL, NULL, u2c_4E, u2c_4F,
- u2c_50, u2c_51, u2c_52, u2c_53, u2c_54, u2c_55, u2c_56, u2c_57,
- u2c_58, u2c_59, u2c_5A, u2c_5B, u2c_5C, u2c_5D, u2c_5E, u2c_5F,
- u2c_60, u2c_61, u2c_62, u2c_63, u2c_64, u2c_65, u2c_66, u2c_67,
- u2c_68, u2c_69, u2c_6A, u2c_6B, u2c_6C, u2c_6D, u2c_6E, u2c_6F,
- u2c_70, u2c_71, u2c_72, u2c_73, u2c_74, u2c_75, u2c_76, u2c_77,
- u2c_78, u2c_79, u2c_7A, u2c_7B, u2c_7C, u2c_7D, u2c_7E, u2c_7F,
- u2c_80, u2c_81, u2c_82, u2c_83, u2c_84, u2c_85, u2c_86, u2c_87,
- u2c_88, u2c_89, u2c_8A, u2c_8B, u2c_8C, u2c_8D, u2c_8E, u2c_8F,
- u2c_90, u2c_91, u2c_92, u2c_93, u2c_94, u2c_95, u2c_96, u2c_97,
- u2c_98, u2c_99, u2c_9A, u2c_9B, u2c_9C, u2c_9D, u2c_9E, u2c_9F,
- NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
- NULL, NULL, NULL, NULL, u2c_AC, u2c_AD, u2c_AE, u2c_AF,
- u2c_B0, u2c_B1, u2c_B2, u2c_B3, u2c_B4, u2c_B5, u2c_B6, u2c_B7,
- u2c_B8, u2c_B9, u2c_BA, u2c_BB, u2c_BC, u2c_BD, u2c_BE, u2c_BF,
- u2c_C0, u2c_C1, u2c_C2, u2c_C3, u2c_C4, u2c_C5, u2c_C6, u2c_C7,
- u2c_C8, u2c_C9, u2c_CA, u2c_CB, u2c_CC, u2c_CD, u2c_CE, u2c_CF,
- u2c_D0, u2c_D1, u2c_D2, u2c_D3, u2c_D4, u2c_D5, u2c_D6, u2c_D7,
- NULL, NULL, NULL, NULL, u2c_DC, NULL, NULL, NULL,
- NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
- NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
- NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
+ NULL, u2c_01, u2c_02, u2c_03, u2c_04, NULL, NULL, NULL,
+ NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
+ NULL, u2c_11, NULL, NULL, NULL, NULL, NULL, NULL,
+ NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
+ u2c_20, u2c_21, u2c_22, u2c_23, u2c_24, u2c_25, u2c_26, NULL,
+ NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
+ u2c_30, u2c_31, u2c_32, u2c_33, NULL, NULL, NULL, NULL,
+ NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
+ NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
+ NULL, NULL, NULL, NULL, NULL, NULL, u2c_4E, u2c_4F,
+ u2c_50, u2c_51, u2c_52, u2c_53, u2c_54, u2c_55, u2c_56, u2c_57,
+ u2c_58, u2c_59, u2c_5A, u2c_5B, u2c_5C, u2c_5D, u2c_5E, u2c_5F,
+ u2c_60, u2c_61, u2c_62, u2c_63, u2c_64, u2c_65, u2c_66, u2c_67,
+ u2c_68, u2c_69, u2c_6A, u2c_6B, u2c_6C, u2c_6D, u2c_6E, u2c_6F,
+ u2c_70, u2c_71, u2c_72, u2c_73, u2c_74, u2c_75, u2c_76, u2c_77,
+ u2c_78, u2c_79, u2c_7A, u2c_7B, u2c_7C, u2c_7D, u2c_7E, u2c_7F,
+ u2c_80, u2c_81, u2c_82, u2c_83, u2c_84, u2c_85, u2c_86, u2c_87,
+ u2c_88, u2c_89, u2c_8A, u2c_8B, u2c_8C, u2c_8D, u2c_8E, u2c_8F,
+ u2c_90, u2c_91, u2c_92, u2c_93, u2c_94, u2c_95, u2c_96, u2c_97,
+ u2c_98, u2c_99, u2c_9A, u2c_9B, u2c_9C, u2c_9D, u2c_9E, u2c_9F,
+ NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
+ NULL, NULL, NULL, NULL, u2c_AC, u2c_AD, u2c_AE, u2c_AF,
+ u2c_B0, u2c_B1, u2c_B2, u2c_B3, u2c_B4, u2c_B5, u2c_B6, u2c_B7,
+ u2c_B8, u2c_B9, u2c_BA, u2c_BB, u2c_BC, u2c_BD, u2c_BE, u2c_BF,
+ u2c_C0, u2c_C1, u2c_C2, u2c_C3, u2c_C4, u2c_C5, u2c_C6, u2c_C7,
+ u2c_C8, u2c_C9, u2c_CA, u2c_CB, u2c_CC, u2c_CD, u2c_CE, u2c_CF,
+ u2c_D0, u2c_D1, u2c_D2, u2c_D3, u2c_D4, u2c_D5, u2c_D6, u2c_D7,
+ NULL, NULL, NULL, NULL, u2c_DC, NULL, NULL, NULL,
+ NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
+ NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
+ NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
NULL, u2c_F9, u2c_FA, NULL, NULL, NULL, NULL, u2c_FF, };

static const unsigned char charset2lower[256] = {
@@ -13879,11 +13879,10 @@ static int uni2char(const wchar_t uni,
if (out[0] == 0x00 && out[1] == 0x00)
return -EINVAL;
n = 2;
- } else if (ch==0 && cl) {
+ } else if ((ch==0) && cl) {
out[0] = cl;
n = 1;
- }
- else
+ } else
return -EINVAL;

return n;
--
1.7.0.90.g251a4

2010-02-27 16:58:18

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 63/66] arch/um/sys-ppc/shared/sysdep/skas_ptrace.h: Checkpatch cleanup

arch/um/sys-ppc/shared/sysdep/skas_ptrace.h:10: ERROR: code indent should use tabs where possible
arch/um/sys-ppc/shared/sysdep/skas_ptrace.h:11: ERROR: code indent should use tabs where possible
arch/um/sys-ppc/shared/sysdep/skas_ptrace.h:15: ERROR: code indent should use tabs where possible
arch/um/sys-ppc/shared/sysdep/skas_ptrace.h:16: ERROR: code indent should use tabs where possible
arch/um/sys-ppc/shared/sysdep/skas_ptrace.h:17: ERROR: code indent should use tabs where possible

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/um/sys-ppc/shared/sysdep/skas_ptrace.h | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/um/sys-ppc/shared/sysdep/skas_ptrace.h b/arch/um/sys-ppc/shared/sysdep/skas_ptrace.h
index d9fbbac..f26f93b 100644
--- a/arch/um/sys-ppc/shared/sysdep/skas_ptrace.h
+++ b/arch/um/sys-ppc/shared/sysdep/skas_ptrace.h
@@ -7,14 +7,14 @@
#define __SYSDEP_PPC_SKAS_PTRACE_H

struct ptrace_faultinfo {
- int is_write;
- unsigned long addr;
+ int is_write;
+ unsigned long addr;
};

struct ptrace_ldt {
- int func;
- void *ptr;
- unsigned long bytecount;
+ int func;
+ void *ptr;
+ unsigned long bytecount;
};

#define PTRACE_LDT 54
--
1.7.0.90.g251a4

2010-02-27 16:58:11

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 61/66] drivers/acpi/sleep.h: Checkpatch cleanup

drivers/acpi/sleep.h:3: WARNING: space prohibited between function name and open parenthesis '('

Signed-off-by: Andrea Gelmini <[email protected]>
---
drivers/acpi/sleep.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/acpi/sleep.h b/drivers/acpi/sleep.h
index 8a8f3b3..25b8bd1 100644
--- a/drivers/acpi/sleep.h
+++ b/drivers/acpi/sleep.h
@@ -1,6 +1,6 @@

extern u8 sleep_states[];
-extern int acpi_suspend (u32 state);
+extern int acpi_suspend(u32 state);

extern void acpi_enable_wakeup_device_prep(u8 sleep_state);
extern void acpi_enable_wakeup_device(u8 sleep_state);
--
1.7.0.90.g251a4

2010-02-27 16:59:23

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 62/66] arch/x86/kvm/kvm_timer.h: Checkpatch cleanup

arch/x86/kvm/kvm_timer.h:13: ERROR: code indent should use tabs where possible

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/x86/kvm/kvm_timer.h | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kvm/kvm_timer.h b/arch/x86/kvm/kvm_timer.h
index 55c7524..64bc6ea 100644
--- a/arch/x86/kvm/kvm_timer.h
+++ b/arch/x86/kvm/kvm_timer.h
@@ -10,9 +10,7 @@ struct kvm_timer {
};

struct kvm_timer_ops {
- bool (*is_periodic)(struct kvm_timer *);
+ bool (*is_periodic)(struct kvm_timer *);
};

-
enum hrtimer_restart kvm_timer_fn(struct hrtimer *data);
-
--
1.7.0.90.g251a4

2010-02-27 16:58:30

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 65/66] arch/um/sys-ia64/sysdep/skas_ptrace.h: Checkpatch cleanup

arch/um/sys-ia64/sysdep/skas_ptrace.h:10: ERROR: code indent should use tabs where possible
arch/um/sys-ia64/sysdep/skas_ptrace.h:11: ERROR: code indent should use tabs where possible
arch/um/sys-ia64/sysdep/skas_ptrace.h:15: ERROR: code indent should use tabs where possible
arch/um/sys-ia64/sysdep/skas_ptrace.h:16: ERROR: code indent should use tabs where possible
arch/um/sys-ia64/sysdep/skas_ptrace.h:17: ERROR: code indent should use tabs where possible

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/um/sys-ia64/sysdep/skas_ptrace.h | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/um/sys-ia64/sysdep/skas_ptrace.h b/arch/um/sys-ia64/sysdep/skas_ptrace.h
index 25a38e7..b49be9e 100644
--- a/arch/um/sys-ia64/sysdep/skas_ptrace.h
+++ b/arch/um/sys-ia64/sysdep/skas_ptrace.h
@@ -7,14 +7,14 @@
#define __SYSDEP_IA64_SKAS_PTRACE_H

struct ptrace_faultinfo {
- int is_write;
- unsigned long addr;
+ int is_write;
+ unsigned long addr;
};

struct ptrace_ldt {
- int func;
- void *ptr;
- unsigned long bytecount;
+ int func;
+ void *ptr;
+ unsigned long bytecount;
};

#define PTRACE_LDT 54
--
1.7.0.90.g251a4

2010-02-27 16:58:26

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 64/66] arch/um/sys-i386/shared/sysdep/skas_ptrace.h: Checkpatch cleanup

arch/um/sys-i386/shared/sysdep/skas_ptrace.h:10: ERROR: code indent should use tabs where possible
arch/um/sys-i386/shared/sysdep/skas_ptrace.h:11: ERROR: code indent should use tabs where possible
arch/um/sys-i386/shared/sysdep/skas_ptrace.h:15: ERROR: code indent should use tabs where possible
arch/um/sys-i386/shared/sysdep/skas_ptrace.h:16: ERROR: code indent should use tabs where possible
arch/um/sys-i386/shared/sysdep/skas_ptrace.h:17: ERROR: code indent should use tabs where possible

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/um/sys-i386/shared/sysdep/skas_ptrace.h | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/um/sys-i386/shared/sysdep/skas_ptrace.h b/arch/um/sys-i386/shared/sysdep/skas_ptrace.h
index e27b8a7..0f6cebb 100644
--- a/arch/um/sys-i386/shared/sysdep/skas_ptrace.h
+++ b/arch/um/sys-i386/shared/sysdep/skas_ptrace.h
@@ -7,14 +7,14 @@
#define __SYSDEP_I386_SKAS_PTRACE_H

struct ptrace_faultinfo {
- int is_write;
- unsigned long addr;
+ int is_write;
+ unsigned long addr;
};

struct ptrace_ldt {
- int func;
- void *ptr;
- unsigned long bytecount;
+ int func;
+ void *ptr;
+ unsigned long bytecount;
};

#define PTRACE_LDT 54
--
1.7.0.90.g251a4

2010-02-27 16:58:36

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 66/66] arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h: Checkpatch cleanup

arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h:10: ERROR: code indent should use tabs where possible
arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h:11: ERROR: code indent should use tabs where possible
arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h:15: ERROR: code indent should use tabs where possible
arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h:16: ERROR: code indent should use tabs where possible
arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h:17: ERROR: code indent should use tabs where possible

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h b/arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h
index 95db4be..40fa1cb 100644
--- a/arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h
+++ b/arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h
@@ -7,14 +7,14 @@
#define __SYSDEP_X86_64_SKAS_PTRACE_H

struct ptrace_faultinfo {
- int is_write;
- unsigned long addr;
+ int is_write;
+ unsigned long addr;
};

struct ptrace_ldt {
- int func;
- void *ptr;
- unsigned long bytecount;
+ int func;
+ void *ptr;
+ unsigned long bytecount;
};

#define PTRACE_LDT 54
--
1.7.0.90.g251a4

2010-02-27 16:57:52

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 58/66] arch/um/os-Linux/sys-x86_64/prctl.c: Checkpatch cleanup

arch/um/os-Linux/sys-x86_64/prctl.c:11: ERROR: code indent should use tabs where possible

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/um/os-Linux/sys-x86_64/prctl.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/um/os-Linux/sys-x86_64/prctl.c b/arch/um/os-Linux/sys-x86_64/prctl.c
index 9d34edd..79c278a 100644
--- a/arch/um/os-Linux/sys-x86_64/prctl.c
+++ b/arch/um/os-Linux/sys-x86_64/prctl.c
@@ -8,5 +8,5 @@

int os_arch_prctl(int pid, int code, unsigned long *addr)
{
- return ptrace(PTRACE_ARCH_PRCTL, pid, (unsigned long) addr, code);
+ return ptrace(PTRACE_ARCH_PRCTL, pid, (unsigned long) addr, code);
}
--
1.7.0.90.g251a4

2010-02-27 16:59:50

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 57/66] arch/arm/plat-omap/include/plat/blizzard.h: Checkpatch cleanup

arch/arm/plat-omap/include/plat/blizzard.h:9: ERROR: spaces prohibited around that ':' (ctx:WxW)

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/arm/plat-omap/include/plat/blizzard.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/plat-omap/include/plat/blizzard.h b/arch/arm/plat-omap/include/plat/blizzard.h
index 8d160f1..56e7f2e 100644
--- a/arch/arm/plat-omap/include/plat/blizzard.h
+++ b/arch/arm/plat-omap/include/plat/blizzard.h
@@ -6,7 +6,7 @@ struct blizzard_platform_data {
void (*power_down)(struct device *dev);
unsigned long (*get_clock_rate)(struct device *dev);

- unsigned te_connected : 1;
+ unsigned te_connected:1;
};

#endif
--
1.7.0.90.g251a4

2010-02-27 17:00:23

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 53/66] drivers/s390/cio/blacklist.h: Checkpatch cleanup

drivers/s390/cio/blacklist.h:4: WARNING: space prohibited between function name and open parenthesis '('

Signed-off-by: Andrea Gelmini <[email protected]>
---
drivers/s390/cio/blacklist.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/s390/cio/blacklist.h b/drivers/s390/cio/blacklist.h
index 95e25c1..4a78e64 100644
--- a/drivers/s390/cio/blacklist.h
+++ b/drivers/s390/cio/blacklist.h
@@ -1,6 +1,6 @@
#ifndef S390_BLACKLIST_H
#define S390_BLACKLIST_H

-extern int is_blacklisted (int ssid, int devno);
+extern int is_blacklisted(int ssid, int devno);

#endif
--
1.7.0.90.g251a4

2010-02-27 16:57:06

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 50/66] arch/um/include/shared/irq_kern.h: Checkpatch cleanup

arch/um/include/shared/irq_kern.h:14: ERROR: "foo * bar" should be "foo *bar"

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/um/include/shared/irq_kern.h | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/arch/um/include/shared/irq_kern.h b/arch/um/include/shared/irq_kern.h
index b05d22f..f5855e1 100644
--- a/arch/um/include/shared/irq_kern.h
+++ b/arch/um/include/shared/irq_kern.h
@@ -11,8 +11,7 @@

extern int um_request_irq(unsigned int irq, int fd, int type,
irq_handler_t handler,
- unsigned long irqflags, const char * devname,
+ unsigned long irqflags, const char *devname,
void *dev_id);

#endif
-
--
1.7.0.90.g251a4

2010-02-27 17:00:47

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 51/66] drivers/isdn/i4l/isdn_concap.h: Checkpatch cleanup

drivers/isdn/i4l/isdn_concap.h:1: WARNING: CVS style keyword markers, these will _not_ be updated
drivers/isdn/i4l/isdn_concap.h:11: ERROR: "foo * bar" should be "foo *bar"
drivers/isdn/i4l/isdn_concap.h:11: ERROR: space prohibited after that open parenthesis '('
drivers/isdn/i4l/isdn_concap.h:11: ERROR: space prohibited before that close parenthesis ')'

Signed-off-by: Andrea Gelmini <[email protected]>
---
drivers/isdn/i4l/isdn_concap.h | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/isdn/i4l/isdn_concap.h b/drivers/isdn/i4l/isdn_concap.h
index 6ac7e04..cd7e3ba 100644
--- a/drivers/isdn/i4l/isdn_concap.h
+++ b/drivers/isdn/i4l/isdn_concap.h
@@ -8,6 +8,4 @@
*/

extern struct concap_device_ops isdn_concap_reliable_dl_dops;
-extern struct concap_proto * isdn_concap_new( int );
-
-
+extern struct concap_proto *isdn_concap_new(int);
--
1.7.0.90.g251a4

2010-02-27 17:01:26

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 44/66] arch/powerpc/sysdev/cpm2_pic.h: Checkpatch cleanup

arch/powerpc/sysdev/cpm2_pic.h:6: ERROR: "(foo*)" should be "(foo *)"

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/powerpc/sysdev/cpm2_pic.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/sysdev/cpm2_pic.h b/arch/powerpc/sysdev/cpm2_pic.h
index 30e5828..2c5f70c 100644
--- a/arch/powerpc/sysdev/cpm2_pic.h
+++ b/arch/powerpc/sysdev/cpm2_pic.h
@@ -3,6 +3,6 @@

extern unsigned int cpm2_get_irq(void);

-extern void cpm2_pic_init(struct device_node*);
+extern void cpm2_pic_init(struct device_node *);

#endif /* _PPC_KERNEL_CPM2_H */
--
1.7.0.90.g251a4

2010-02-27 17:01:07

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 48/66] sound/usb/caiaq/midi.h: Checkpatch cleanup

sound/usb/caiaq/midi.h:6: ERROR: "foo* bar" should be "foo *bar"

Signed-off-by: Andrea Gelmini <[email protected]>
---
sound/usb/caiaq/midi.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/usb/caiaq/midi.h b/sound/usb/caiaq/midi.h
index 9d16db0..380f984 100644
--- a/sound/usb/caiaq/midi.h
+++ b/sound/usb/caiaq/midi.h
@@ -3,6 +3,6 @@

int snd_usb_caiaq_midi_init(struct snd_usb_caiaqdev *dev);
void snd_usb_caiaq_midi_handle_input(struct snd_usb_caiaqdev *dev, int port, const char *buf, int len);
-void snd_usb_caiaq_midi_output_done(struct urb* urb);
+void snd_usb_caiaq_midi_output_done(struct urb *urb);

#endif /* CAIAQ_MIDI_H */
--
1.7.0.90.g251a4

2010-02-27 16:55:20

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 32/66] arch/parisc/include/asm/parport.h: Checkpatch cleanup

arch/parisc/include/asm/parport.h:1: ERROR: trailing whitespace
arch/parisc/include/asm/parport.h:11: WARNING: space prohibited between function name and open parenthesis '('

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/parisc/include/asm/parport.h | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/parisc/include/asm/parport.h b/arch/parisc/include/asm/parport.h
index 00d9cc3..5cbf98b 100644
--- a/arch/parisc/include/asm/parport.h
+++ b/arch/parisc/include/asm/parport.h
@@ -1,4 +1,4 @@
-/*
+/*
*
* parport.h: ia32-compatible parport initialisation
*
@@ -8,8 +8,7 @@
#define _ASM_PARPORT_H 1


-static int __devinit parport_pc_find_nonpci_ports (int autoirq, int autodma)
-{
+static int __devinit parport_pc_find_nonpci_ports (int autoirq, int autodma) {
/* nothing ! */
return 0;
}
--
1.7.0.90.g251a4

2010-02-27 17:03:17

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 33/66] include/linux/uts.h: Checkpatch cleanup

include/linux/uts.h:5: ERROR: trailing whitespace

Signed-off-by: Andrea Gelmini <[email protected]>
---
include/linux/uts.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/uts.h b/include/linux/uts.h
index 73eb1ed..2ad5582 100644
--- a/include/linux/uts.h
+++ b/include/linux/uts.h
@@ -2,7 +2,7 @@
#define _LINUX_UTS_H

/*
- * Defines for what uname() should return
+ * Defines for what uname() should return
*/
#ifndef UTS_SYSNAME
#define UTS_SYSNAME "Linux"
--
1.7.0.90.g251a4

2010-02-27 17:02:28

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 36/66] arch/um/include/shared/ubd_user.h: Checkpatch cleanup

arch/um/include/shared/ubd_user.h:1: ERROR: trailing whitespace

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/um/include/shared/ubd_user.h | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/arch/um/include/shared/ubd_user.h b/arch/um/include/shared/ubd_user.h
index 3845051..9198fa3 100644
--- a/arch/um/include/shared/ubd_user.h
+++ b/arch/um/include/shared/ubd_user.h
@@ -1,4 +1,4 @@
-/*
+/*
* Copyright (C) 2000 Jeff Dike ([email protected])
* Copyright (C) 2001 RidgeRun, Inc ([email protected])
* Licensed under the GPL
@@ -13,4 +13,3 @@ extern int io_thread(void *arg);
extern int kernel_fd;

#endif
-
--
1.7.0.90.g251a4

2010-02-27 16:55:12

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 31/66] include/linux/tc_act/tc_defact.h: Checkpatch cleanup

include/linux/tc_act/tc_defact.h:9: ERROR: trailing whitespace
include/linux/tc_act/tc_defact.h:9: ERROR: code indent should use tabs where possible

Signed-off-by: Andrea Gelmini <[email protected]>
---
include/linux/tc_act/tc_defact.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/tc_act/tc_defact.h b/include/linux/tc_act/tc_defact.h
index 6f65d07..17dddb4 100644
--- a/include/linux/tc_act/tc_defact.h
+++ b/include/linux/tc_act/tc_defact.h
@@ -6,7 +6,7 @@
struct tc_defact {
tc_gen;
};
-
+
enum {
TCA_DEF_UNSPEC,
TCA_DEF_TM,
--
1.7.0.90.g251a4

2010-02-27 17:02:51

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 28/66] arch/cris/include/asm/unaligned.h: Checkpatch cleanup

arch/cris/include/asm/unaligned.h:5: ERROR: trailing whitespace

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/cris/include/asm/unaligned.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/cris/include/asm/unaligned.h b/arch/cris/include/asm/unaligned.h
index 7b3f3fe..b0fc89d 100644
--- a/arch/cris/include/asm/unaligned.h
+++ b/arch/cris/include/asm/unaligned.h
@@ -2,7 +2,7 @@
#define _ASM_CRIS_UNALIGNED_H

/*
- * CRIS can do unaligned accesses itself.
+ * CRIS can do unaligned accesses itself.
*/
#include <linux/unaligned/access_ok.h>
#include <linux/unaligned/generic.h>
--
1.7.0.90.g251a4

2010-02-27 17:02:24

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 37/66] include/linux/tc_act/tc_ipt.h: Checkpatch cleanup

include/linux/tc_act/tc_ipt.h:19: ERROR: trailing whitespace
include/linux/tc_act/tc_ipt.h:19: ERROR: code indent should use tabs where possible

Signed-off-by: Andrea Gelmini <[email protected]>
---
include/linux/tc_act/tc_ipt.h | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/include/linux/tc_act/tc_ipt.h b/include/linux/tc_act/tc_ipt.h
index a233556..1140188 100644
--- a/include/linux/tc_act/tc_ipt.h
+++ b/include/linux/tc_act/tc_ipt.h
@@ -16,5 +16,4 @@ enum {
__TCA_IPT_MAX
};
#define TCA_IPT_MAX (__TCA_IPT_MAX - 1)
-
#endif
--
1.7.0.90.g251a4

2010-02-27 16:55:05

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 30/66] include/net/x25device.h: Checkpatch cleanup

include/net/x25device.h:13: ERROR: trailing whitespace

Signed-off-by: Andrea Gelmini <[email protected]>
---
include/net/x25device.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/net/x25device.h b/include/net/x25device.h
index 1415bcf..246a17b 100644
--- a/include/net/x25device.h
+++ b/include/net/x25device.h
@@ -10,7 +10,7 @@ static inline __be16 x25_type_trans(struct sk_buff *skb, struct net_device *dev)
skb->dev = dev;
skb_reset_mac_header(skb);
skb->pkt_type = PACKET_HOST;
-
+
return htons(ETH_P_X25);
}
#endif
--
1.7.0.90.g251a4

2010-02-27 17:03:45

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 25/66] arch/h8300/include/asm/target_time.h: Checkpatch cleanup

arch/h8300/include/asm/target_time.h:3: ERROR: trailing whitespace
arch/h8300/include/asm/target_time.h:4: ERROR: code indent should use tabs where possible

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/h8300/include/asm/target_time.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/h8300/include/asm/target_time.h b/arch/h8300/include/asm/target_time.h
index 9f2a9aa..043d9a0 100644
--- a/arch/h8300/include/asm/target_time.h
+++ b/arch/h8300/include/asm/target_time.h
@@ -1,4 +1,4 @@
extern int platform_timer_setup(void (*timer_int)(int, void *, struct pt_regs *));
extern void platform_timer_eoi(void);
-extern void platform_gettod(unsigned int *year, unsigned int *mon, unsigned int *day,
- unsigned int *hour, unsigned int *min, unsigned int *sec);
+extern void platform_gettod(unsigned int *year, unsigned int *mon, unsigned int *day,
+ unsigned int *hour, unsigned int *min, unsigned int *sec);
--
1.7.0.90.g251a4

2010-02-27 17:03:58

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 23/66] arch/cris/include/arch-v10/arch/pgtable.h: Checkpatch cleanup

arch/cris/include/arch-v10/arch/pgtable.h:5: ERROR: trailing whitespace

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/cris/include/arch-v10/arch/pgtable.h | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/arch/cris/include/arch-v10/arch/pgtable.h b/arch/cris/include/arch-v10/arch/pgtable.h
index 2a2576d..1975118 100644
--- a/arch/cris/include/arch-v10/arch/pgtable.h
+++ b/arch/cris/include/arch-v10/arch/pgtable.h
@@ -2,7 +2,7 @@
#define _CRIS_ARCH_PGTABLE_H

/*
- * Kernels own virtual memory area.
+ * Kernels own virtual memory area.
*/

#ifdef CONFIG_CRIS_LOW_MAP
@@ -14,4 +14,3 @@
#endif

#endif
-
--
1.7.0.90.g251a4

2010-02-27 17:04:21

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 21/66] arch/um/include/shared/sigio.h: Checkpatch cleanup

arch/um/include/shared/sigio.h:1: ERROR: trailing whitespace

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/um/include/shared/sigio.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/um/include/shared/sigio.h b/arch/um/include/shared/sigio.h
index 434f1a9..8af4c67 100644
--- a/arch/um/include/shared/sigio.h
+++ b/arch/um/include/shared/sigio.h
@@ -1,4 +1,4 @@
-/*
+/*
* Copyright (C) 2002 Jeff Dike ([email protected])
* Licensed under the GPL
*/
--
1.7.0.90.g251a4

2010-02-27 17:04:42

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 17/66] arch/um/sys-i386/asm/archparam.h: Checkpatch cleanup

arch/um/sys-i386/asm/archparam.h:1: ERROR: trailing whitespace

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/um/sys-i386/asm/archparam.h | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/arch/um/sys-i386/asm/archparam.h b/arch/um/sys-i386/asm/archparam.h
index 2a18a88..32f7253 100644
--- a/arch/um/sys-i386/asm/archparam.h
+++ b/arch/um/sys-i386/asm/archparam.h
@@ -1,4 +1,4 @@
-/*
+/*
* Copyright (C) 2000 - 2003 Jeff Dike ([email protected])
* Licensed under the GPL
*/
@@ -13,4 +13,3 @@
#endif

#endif
-
--
1.7.0.90.g251a4

2010-02-27 17:05:00

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 13/66] arch/h8300/include/asm/md.h: Checkpatch cleanup

arch/h8300/include/asm/md.h:2: ERROR: trailing whitespace
arch/h8300/include/asm/md.h:5: ERROR: trailing whitespace

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/h8300/include/asm/md.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/h8300/include/asm/md.h b/arch/h8300/include/asm/md.h
index 1b7300e..d2f78f2 100644
--- a/arch/h8300/include/asm/md.h
+++ b/arch/h8300/include/asm/md.h
@@ -1,8 +1,8 @@
/*
- * md.h: High speed xor_block operation for RAID4/5
+ * md.h: High speed xor_block operation for RAID4/5
*
*/
-
+
#ifndef __ASM_MD_H
#define __ASM_MD_H

--
1.7.0.90.g251a4

2010-02-27 16:52:38

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 05/66] arch/cris/include/asm/irq.h: Checkpatch cleanup

arch/cris/include/asm/irq.h:7: ERROR: trailing whitespace
arch/cris/include/asm/irq.h:8: ERROR: trailing whitespace

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/cris/include/asm/irq.h | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/cris/include/asm/irq.h b/arch/cris/include/asm/irq.h
index ce0fcf5..9e9f231 100644
--- a/arch/cris/include/asm/irq.h
+++ b/arch/cris/include/asm/irq.h
@@ -4,10 +4,8 @@
#include <arch/irq.h>

static inline int irq_canonicalize(int irq)
-{
- return irq;
+{
+ return irq;
}

#endif /* _ASM_IRQ_H */
-
-
--
1.7.0.90.g251a4

2010-02-27 17:06:29

by Andrea Gelmini

[permalink] [raw]
Subject: [PATCH 06/66] arch/um/sys-ia64/sysdep/syscalls.h: Checkpatch cleanup

arch/um/sys-ia64/sysdep/syscalls.h:1: ERROR: trailing whitespace

Signed-off-by: Andrea Gelmini <[email protected]>
---
arch/um/sys-ia64/sysdep/syscalls.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/um/sys-ia64/sysdep/syscalls.h b/arch/um/sys-ia64/sysdep/syscalls.h
index 5f6700c..e6f6994 100644
--- a/arch/um/sys-ia64/sysdep/syscalls.h
+++ b/arch/um/sys-ia64/sysdep/syscalls.h
@@ -1,4 +1,4 @@
-/*
+/*
* Copyright (C) 2000 Jeff Dike ([email protected])
* Licensed under the GPL
*/
--
1.7.0.90.g251a4

2010-02-27 22:15:05

by Jeff Dike

[permalink] [raw]
Subject: Re: [uml-devel] [PATCH 66/66] arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h: Checkpatch cleanup

On Sat, Feb 27, 2010 at 05:51:47PM +0100, Andrea Gelmini wrote:
> arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h:10: ERROR: code indent should use tabs where possible
> arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h:11: ERROR: code indent should use tabs where possible

Don't you have anything better to do with your time?

Jeff

2010-02-27 22:18:22

by Thibaut VARENE

[permalink] [raw]
Subject: Re: [PATCH 32/66] arch/parisc/include/asm/parport.h: Checkpatch cleanup

On Sat, Feb 27, 2010 at 5:51 PM, Andrea Gelmini
<[email protected]> wrote:
> arch/parisc/include/asm/parport.h:1: ERROR: trailing whitespace
> arch/parisc/include/asm/parport.h:11: WARNING: space prohibited between function name and open parenthesis '('
>
> Signed-off-by: Andrea Gelmini <[email protected]>
> ---
>  arch/parisc/include/asm/parport.h |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/parisc/include/asm/parport.h b/arch/parisc/include/asm/parport.h
> index 00d9cc3..5cbf98b 100644
> --- a/arch/parisc/include/asm/parport.h
> +++ b/arch/parisc/include/asm/parport.h

> @@ -8,8 +8,7 @@
>  #define _ASM_PARPORT_H 1
>
>
> -static int __devinit parport_pc_find_nonpci_ports (int autoirq, int autodma)
> -{
> +static int __devinit parport_pc_find_nonpci_ports (int autoirq, int autodma) {

This looks very much in contradiction with CodingStyle, since
parport_pc_find_nonpci_ports() is a function, and it's not a fix for
the quoted "WARNING". I'm guessing this wasn't intended the way it is.

HTH

T-Bone

--
Thibaut VARENE
http://www.parisc-linux.org/~varenet/

2010-02-28 05:41:12

by NeilBrown

[permalink] [raw]
Subject: Re: [PATCH 41/66] drivers/md/linear.h: Checkpatch cleanup

On Sat, 27 Feb 2010 17:51:22 +0100
Andrea Gelmini <[email protected]> wrote:

> drivers/md/linear.h:12: ERROR: open brace '{' following struct go on the same line

Thanks, but no thanks.
This just doesn't need cleaning up.

NeilBrown

>
> Signed-off-by: Andrea Gelmini <[email protected]>
> ---
> drivers/md/linear.h | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/md/linear.h b/drivers/md/linear.h
> index 0ce29b6..3860fd8 100644
> --- a/drivers/md/linear.h
> +++ b/drivers/md/linear.h
> @@ -8,8 +8,7 @@ struct dev_info {
>
> typedef struct dev_info dev_info_t;
>
> -struct linear_private_data
> -{
> +struct linear_private_data {
> sector_t array_sectors;
> dev_info_t disks[0];
> struct rcu_head rcu;

2010-02-28 08:10:41

by David Miller

[permalink] [raw]
Subject: Re: [PATCH 16/66] arch/sparc/include/asm/setup.h: Checkpatch cleanup

From: Andrea Gelmini <[email protected]>
Date: Sat, 27 Feb 2010 17:50:57 +0100

> arch/sparc/include/asm/setup.h:2: ERROR: trailing whitespace
>
> Signed-off-by: Andrea Gelmini <[email protected]>

Acked-by: David S. Miller <[email protected]>

2010-02-28 08:11:13

by David Miller

[permalink] [raw]
Subject: Re: [PATCH 30/66] include/net/x25device.h: Checkpatch cleanup

From: Andrea Gelmini <[email protected]>
Date: Sat, 27 Feb 2010 17:51:11 +0100

> include/net/x25device.h:13: ERROR: trailing whitespace
>
> Signed-off-by: Andrea Gelmini <[email protected]>

Acked-by: David S. Miller <[email protected]>

2010-02-28 08:11:25

by David Miller

[permalink] [raw]
Subject: Re: [PATCH 31/66] include/linux/tc_act/tc_defact.h: Checkpatch cleanup

From: Andrea Gelmini <[email protected]>
Date: Sat, 27 Feb 2010 17:51:12 +0100

> include/linux/tc_act/tc_defact.h:9: ERROR: trailing whitespace
> include/linux/tc_act/tc_defact.h:9: ERROR: code indent should use tabs where possible
>
> Signed-off-by: Andrea Gelmini <[email protected]>

Acked-by: David S. Miller <[email protected]>

2010-02-28 08:11:35

by David Miller

[permalink] [raw]
Subject: Re: [PATCH 27/66] include/linux/raw.h: Checkpatch cleanup

From: Andrea Gelmini <[email protected]>
Date: Sat, 27 Feb 2010 17:51:08 +0100

> include/linux/raw.h:6: ERROR: space prohibited after that open parenthesis '('
> include/linux/raw.h:6: ERROR: space prohibited before that close parenthesis ')'
> include/linux/raw.h:7: ERROR: space prohibited after that open parenthesis '('
> include/linux/raw.h:7: ERROR: space prohibited before that close parenthesis ')'
> include/linux/raw.h:9: ERROR: trailing whitespace
> include/linux/raw.h:10: ERROR: open brace '{' following struct go on the same line
>
> Signed-off-by: Andrea Gelmini <[email protected]>

Acked-by: David S. Miller <[email protected]>

2010-02-28 08:11:53

by David Miller

[permalink] [raw]
Subject: Re: [PATCH 37/66] include/linux/tc_act/tc_ipt.h: Checkpatch cleanup

From: Andrea Gelmini <[email protected]>
Date: Sat, 27 Feb 2010 17:51:18 +0100

> include/linux/tc_act/tc_ipt.h:19: ERROR: trailing whitespace
> include/linux/tc_act/tc_ipt.h:19: ERROR: code indent should use tabs where possible
>
> Signed-off-by: Andrea Gelmini <[email protected]>

Acked-by: David S. Miller <[email protected]>

2010-02-28 08:12:19

by David Miller

[permalink] [raw]
Subject: Re: [PATCH 40/66] include/linux/netfilter/nf_conntrack_tuple_common.h: Checkpatch cleanup

From: Andrea Gelmini <[email protected]>
Date: Sat, 27 Feb 2010 17:51:21 +0100

> include/linux/netfilter/nf_conntrack_tuple_common.h:5: ERROR: open brace '{' following enum go on the same line
>
> Signed-off-by: Andrea Gelmini <[email protected]>

Acked-by: David S. Miller <[email protected]>

2010-02-28 08:12:50

by David Miller

[permalink] [raw]
Subject: Re: [PATCH 45/66] drivers/isdn/hardware/eicon/os_4bri.h: Checkpatch cleanup

From: Andrea Gelmini <[email protected]>
Date: Sat, 27 Feb 2010 17:51:26 +0100

> drivers/isdn/hardware/eicon/os_4bri.h:6: ERROR: "foo * bar" should be "foo *bar"
>
> Signed-off-by: Andrea Gelmini <[email protected]>

Acked-by: David S. Miller <[email protected]>

2010-02-28 08:12:33

by David Miller

[permalink] [raw]
Subject: Re: [PATCH 47/66] drivers/isdn/hardware/eicon/os_pri.h: Checkpatch cleanup

From: Andrea Gelmini <[email protected]>
Date: Sat, 27 Feb 2010 17:51:28 +0100

> drivers/isdn/hardware/eicon/os_pri.h:6: ERROR: "foo * bar" should be "foo *bar"
>
> Signed-off-by: Andrea Gelmini <[email protected]>

Acked-by: David S. Miller <[email protected]>

2010-02-28 08:12:40

by David Miller

[permalink] [raw]
Subject: Re: [PATCH 46/66] drivers/isdn/hardware/eicon/os_bri.h: Checkpatch cleanup

From: Andrea Gelmini <[email protected]>
Date: Sat, 27 Feb 2010 17:51:27 +0100

> drivers/isdn/hardware/eicon/os_bri.h:6: ERROR: "foo * bar" should be "foo *bar"
>
> Signed-off-by: Andrea Gelmini <[email protected]>

Acked-by: David S. Miller <[email protected]>

2010-02-28 08:13:14

by David Miller

[permalink] [raw]
Subject: Re: [PATCH 51/66] drivers/isdn/i4l/isdn_concap.h: Checkpatch cleanup

From: Andrea Gelmini <[email protected]>
Date: Sat, 27 Feb 2010 17:51:32 +0100

> drivers/isdn/i4l/isdn_concap.h:1: WARNING: CVS style keyword markers, these will _not_ be updated
> drivers/isdn/i4l/isdn_concap.h:11: ERROR: "foo * bar" should be "foo *bar"
> drivers/isdn/i4l/isdn_concap.h:11: ERROR: space prohibited after that open parenthesis '('
> drivers/isdn/i4l/isdn_concap.h:11: ERROR: space prohibited before that close parenthesis ')'
>
> Signed-off-by: Andrea Gelmini <[email protected]>

Acked-by: David S. Miller <[email protected]>

2010-02-28 10:20:20

by Daniel Mack

[permalink] [raw]
Subject: Re: [PATCH 48/66] sound/usb/caiaq/midi.h: Checkpatch cleanup

On Sat, Feb 27, 2010 at 05:51:29PM +0100, Andrea Gelmini wrote:
> sound/usb/caiaq/midi.h:6: ERROR: "foo* bar" should be "foo *bar"
>
> Signed-off-by: Andrea Gelmini <[email protected]>

Acked-by: Daniel Mack <[email protected]>


> ---
> sound/usb/caiaq/midi.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/usb/caiaq/midi.h b/sound/usb/caiaq/midi.h
> index 9d16db0..380f984 100644
> --- a/sound/usb/caiaq/midi.h
> +++ b/sound/usb/caiaq/midi.h
> @@ -3,6 +3,6 @@
>
> int snd_usb_caiaq_midi_init(struct snd_usb_caiaqdev *dev);
> void snd_usb_caiaq_midi_handle_input(struct snd_usb_caiaqdev *dev, int port, const char *buf, int len);
> -void snd_usb_caiaq_midi_output_done(struct urb* urb);
> +void snd_usb_caiaq_midi_output_done(struct urb *urb);
>
> #endif /* CAIAQ_MIDI_H */
> --
> 1.7.0.90.g251a4
>

2010-02-28 13:54:31

by Andrea Gelmini

[permalink] [raw]
Subject: Re: [PATCH 32/66] arch/parisc/include/asm/parport.h: Checkpatch cleanup

2010/2/27 Thibaut VARENE <[email protected]>:

Hi Thubaut,
thanks a lot for you answer.

> This looks very much in contradiction with CodingStyle, since
> parport_pc_find_nonpci_ports() is a function, and it's not a fix for
> the quoted "WARNING". I'm guessing this wasn't intended the way it is.

My fault. I'll look at checkpatch.pl regexp to resolve false positive
(I've found a few other regressions).

Thanks again,
Andrea

2010-02-28 14:06:24

by Andrea Gelmini

[permalink] [raw]
Subject: Re: [uml-devel] [PATCH 66/66] arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h: Checkpatch cleanup

2010/2/27 Jeff Dike <[email protected]>:
Hi Jeff,
and thanks for your reply.

> Don't you have anything better to do with your time?

It's a dirty job, but somebody has to do it...
Enlighted by Greg's talk at FOSDEM¹ I sent him some patches (nothing
more than boring things for a real programmer, but a good solitaire
alternative for a rookie like me).

These patches are just a try to see if there are other subtree
maintainers interested in stuff like this.

Ciao,
Andrea




----------------------------
¹ http://bit.ly/9d3Ql3

2010-02-28 18:28:13

by Jeff Dike

[permalink] [raw]
Subject: Re: [uml-devel] [PATCH 66/66] arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h: Checkpatch cleanup

On Sun, Feb 28, 2010 at 03:06:21PM +0100, Andrea Gelmini wrote:
> 2010/2/27 Jeff Dike <[email protected]>:
> Hi Jeff,
> and thanks for your reply.
>
> > Don't you have anything better to do with your time?
>
> It's a dirty job, but somebody has to do it...

To be a bit more serious, the UML tree was once a seething mass of
checkpatch violations. I cleaned up a lot of it while making other
changes in the area. This sort of thing I think is reasonably
worthwhile, but dumping in a whole lot of checkpatch changes doesn't
help anything and it just pollutes the change history.

Jeff

2010-02-28 20:45:12

by Al Viro

[permalink] [raw]
Subject: Re: [uml-devel] [PATCH 66/66] arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h: Checkpatch cleanup

On Sun, Feb 28, 2010 at 03:06:21PM +0100, Andrea Gelmini wrote:
> 2010/2/27 Jeff Dike <[email protected]>:
> Hi Jeff,
> and thanks for your reply.
>
> > Don't you have anything better to do with your time?
>
> It's a dirty job, but somebody has to do it...
> Enlighted by Greg's talk at FOSDEM?? I sent him some patches (nothing
> more than boring things for a real programmer, but a good solitaire
> alternative for a rookie like me).
>
> These patches are just a try to see if there are other subtree
> maintainers interested in stuff like this.

Note to gregkh: the next time you give a talk like that, consider including
"spamming l-k with sixty-odd solitaire sessions^W^Wwhitespace-removal patches
can lead to considerable annoyance"...

2010-02-28 22:30:28

by Andrew Hendry

[permalink] [raw]
Subject: Re: [PATCH 30/66] include/net/x25device.h: Checkpatch cleanup

Acked-by: Andrew Hendry <[email protected]>

On Sun, Feb 28, 2010 at 7:11 PM, David Miller <[email protected]> wrote:
> From: Andrea Gelmini <[email protected]>
> Date: Sat, 27 Feb 2010 17:51:11 +0100
>
>> include/net/x25device.h:13: ERROR: trailing whitespace
>>
>> Signed-off-by: Andrea Gelmini <[email protected]>
>
> Acked-by: David S. Miller <[email protected]>
>

2010-03-01 02:33:51

by Paul Mundt

[permalink] [raw]
Subject: Re: [PATCH 42/66] arch/mips/lib/libgcc.h: Checkpatch cleanup

On Sat, Feb 27, 2010 at 05:51:23PM +0100, Andrea Gelmini wrote:
> arch/mips/lib/libgcc.h:21: ERROR: open brace '{' following union go on the same line
>
> Signed-off-by: Andrea Gelmini <[email protected]>
> ---
> arch/mips/lib/libgcc.h | 3 +--
> arch/sh/lib/libgcc.h | 3 +--
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
I'll apply the sh part by itself, and I suppose Ralf will do the same for
MIPS. I'm a bit confused as to why these were lumped together when 65 out
of 66 oneliner patches made no use of ad-hoc grouping.

2010-03-01 03:58:21

by Greg KH

[permalink] [raw]
Subject: Re: [uml-devel] [PATCH 66/66] arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h: Checkpatch cleanup

On Sun, Feb 28, 2010 at 08:45:06PM +0000, Al Viro wrote:
> On Sun, Feb 28, 2010 at 03:06:21PM +0100, Andrea Gelmini wrote:
> > 2010/2/27 Jeff Dike <[email protected]>:
> > Hi Jeff,
> > and thanks for your reply.
> >
> > > Don't you have anything better to do with your time?
> >
> > It's a dirty job, but somebody has to do it...
> > Enlighted by Greg's talk at FOSDEM?? I sent him some patches (nothing
> > more than boring things for a real programmer, but a good solitaire
> > alternative for a rookie like me).
> >
> > These patches are just a try to see if there are other subtree
> > maintainers interested in stuff like this.
>
> Note to gregkh: the next time you give a talk like that, consider including
> "spamming l-k with sixty-odd solitaire sessions^W^Wwhitespace-removal patches
> can lead to considerable annoyance"...

Heh, I did explicitly state that this should be done on the staging
tree only. This developer took it apon themselves to try a different
subsystem, which is fine, why would we want to turn away free help :)

thanks,

greg k-h

2010-04-01 12:18:33

by Artem Bityutskiy

[permalink] [raw]
Subject: Re: [PATCH 56/66] include/linux/mtd/mtdram.h: Checkpatch cleanup

On Sat, 2010-02-27 at 17:51 +0100, Andrea Gelmini wrote:
> include/linux/mtd/mtdram.h:6: ERROR: code indent should use tabs where possible
>
> Signed-off-by: Andrea Gelmini <[email protected]>

Pushed to l2-mtd-2.6.git / master

--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)