2010-04-01 12:30:08

by Artem Bityutskiy

[permalink] [raw]
Subject: Re: [PATCH] [mtd, nandsim] Fix typo: struct nandsin_geometry

On Sat, 2010-03-06 at 20:08 +0100, Ferenc Wagner wrote:
> Actually, this embedded struct (together with nandsim_regs) could as well
> remain nameless...
>
> Signed-off-by: Ferenc Wagner <[email protected]>
> ---
> drivers/mtd/nand/nandsim.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/nand/nandsim.c b/drivers/mtd/nand/nandsim.c
> index 7281000..803ae12 100644
> --- a/drivers/mtd/nand/nandsim.c
> +++ b/drivers/mtd/nand/nandsim.c
> @@ -312,7 +312,7 @@ struct nandsim {
> union ns_mem buf;
>
> /* NAND flash "geometry" */
> - struct nandsin_geometry {
> + struct nandsim_geometry {
> uint64_t totsz; /* total flash size, bytes */
> uint32_t secsz; /* flash sector (erase block) size, bytes */
> uint pgsz; /* NAND flash page size, bytes */

Instead of taking your patch, I've made this structure anonymous as well
as few other structures. See
http://git.infradead.org/users/dedekind/l2-mtd-2.6.git/commit/833ba5e74a8b141ea7d7b318d6ac8c112659efa6

I've referred you as the person who suggested the change.

--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)