2010-04-20 09:11:36

by Hector Palacios

[permalink] [raw]
Subject: [PATCH] spi: spidev_test gives error upon 1-byte transfer

The sample application spidev_test.c is using SPI_IOC_MESSAGE
ioctl to do an SPI transfer. This ioctl returns the number of
bytes successfully transmitted or a negative error code upon
erroneous completion. The application however is returning an
error if the result of the ioclt if the return value is 1.
This makes the application to fail upon 1-byte length transfers.

Signed-off-by: Hector Palacios <[email protected]>
---
Documentation/spi/spidev_test.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Documentation/spi/spidev_test.c b/Documentation/spi/spidev_test.c
index c1a5aad..8c9d02e 100644
--- a/Documentation/spi/spidev_test.c
+++ b/Documentation/spi/spidev_test.c
@@ -58,7 +58,7 @@ static void transfer(int fd)
};

ret = ioctl(fd, SPI_IOC_MESSAGE(1), &tr);
- if (ret == 1)
+ if (ret < 1)
pabort("can't send spi message");

for (ret = 0; ret < ARRAY_SIZE(tx); ret++) {
--
1.7.0.5