2010-04-27 18:00:37

by Steven J. Magnani

Subject: [PATCH][NOMMU] microblaze: re-enable interrupts before calling schedule

schedule() should not be called with interrupts disabled.

Signed-off-by: Steven J. Magnani <[email protected]>
---
diff -uprN a/arch/microblaze/kernel/entry-nommu.S b/arch/microblaze/kernel/entry-nommu.S
--- a/arch/microblaze/kernel/entry-nommu.S 2010-04-27 10:14:33.000000000 -0500
+++ b/arch/microblaze/kernel/entry-nommu.S 2010-04-27 12:53:04.000000000 -0500
@@ -476,6 +476,8 @@ ENTRY(ret_from_fork)
nop

work_pending:
+ enable_irq
+
andi r11, r19, _TIF_NEED_RESCHED
beqi r11, 1f
bralid r15, schedule

2010-04-30 19:41:50

by Michal Simek

Subject: Re: [PATCH][NOMMU] microblaze: re-enable interrupts before calling schedule

Steven J. Magnani wrote:
> schedule() should not be called with interrupts disabled.
>
> Signed-off-by: Steven J. Magnani <[email protected]>
> ---
> diff -uprN a/arch/microblaze/kernel/entry-nommu.S b/arch/microblaze/kernel/entry-nommu.S
> --- a/arch/microblaze/kernel/entry-nommu.S 2010-04-27 10:14:33.000000000 -0500
> +++ b/arch/microblaze/kernel/entry-nommu.S 2010-04-27 12:53:04.000000000 -0500
> @@ -476,6 +476,8 @@ ENTRY(ret_from_fork)
> nop
>
> work_pending:
> + enable_irq
> +
> andi r11, r19, _TIF_NEED_RESCHED
> beqi r11, 1f
> bralid r15, schedule
>

Applied

Thanks,
Michal


--
Michal Simek, Ing. (M.Eng)
w: http://www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian