2010-04-27 18:00:47

by Steven J. Magnani

Subject: [PATCH] microblaze: export assembly functions used by modules

Modules that use copy_{to,from}_user(), memcpy(), and memset() fail to build
in certain circumstances.

Signed-off-by: Steven J. Magnani <[email protected]>
---
diff -uprN a/arch/microblaze/kernel/microblaze_ksyms.c b/arch/microblaze/kernel/microblaze_ksyms.c
--- a/arch/microblaze/kernel/microblaze_ksyms.c 2010-04-27 10:14:33.000000000 -0500
+++ b/arch/microblaze/kernel/microblaze_ksyms.c 2010-04-27 12:52:08.000000000 -0500
@@ -52,3 +52,13 @@ EXPORT_SYMBOL_GPL(_ebss);
extern void _mcount(void);
EXPORT_SYMBOL(_mcount);
#endif
+
+/*
+ * Assembly functions that may be used (directly or indirectly) by modules
+ */
+EXPORT_SYMBOL(__copy_tofrom_user);
+
+#ifdef CONFIG_OPT_LIB_ASM
+EXPORT_SYMBOL(memcpy);
+EXPORT_SYMBOL(memmove);
+#endif

2010-04-30 16:56:08

by Michal Simek

Subject: Re: [PATCH] microblaze: export assembly functions used by modules

Steven J. Magnani wrote:
> Modules that use copy_{to,from}_user(), memcpy(), and memset() fail to build
> in certain circumstances.
>
> Signed-off-by: Steven J. Magnani <[email protected]>
> ---
> diff -uprN a/arch/microblaze/kernel/microblaze_ksyms.c b/arch/microblaze/kernel/microblaze_ksyms.c
> --- a/arch/microblaze/kernel/microblaze_ksyms.c 2010-04-27 10:14:33.000000000 -0500
> +++ b/arch/microblaze/kernel/microblaze_ksyms.c 2010-04-27 12:52:08.000000000 -0500
> @@ -52,3 +52,13 @@ EXPORT_SYMBOL_GPL(_ebss);
> extern void _mcount(void);
> EXPORT_SYMBOL(_mcount);
> #endif
> +
> +/*
> + * Assembly functions that may be used (directly or indirectly) by modules
> + */
> +EXPORT_SYMBOL(__copy_tofrom_user);
> +
> +#ifdef CONFIG_OPT_LIB_ASM
> +EXPORT_SYMBOL(memcpy);
> +EXPORT_SYMBOL(memmove);
> +#endif
>

applied.

Thanks,
Michal


--
Michal Simek, Ing. (M.Eng)
w: http://www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian