2010-06-22 15:43:31

by Suresh Jayaraman

Subject: [RFC][PATCH 02/10] cifs: guard cifsglob.h against multiple inclusion

Add conditional compile macros to guard the header file against multiple
inclusion.

Signed-off-by: Suresh Jayaraman <[email protected]>
---
fs/cifs/cifsglob.h | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h
index a88479c..6b2c39d 100644
--- a/fs/cifs/cifsglob.h
+++ b/fs/cifs/cifsglob.h
@@ -16,6 +16,9 @@
* the GNU Lesser General Public License for more details.
*
*/
+#ifndef _CIFS_GLOB_H
+#define _CIFS_GLOB_H
+
#include <linux/in.h>
#include <linux/in6.h>
#include <linux/slab.h>
@@ -733,3 +736,5 @@ GLOBAL_EXTERN unsigned int cifs_min_small; /* min size of small buf pool */
GLOBAL_EXTERN unsigned int cifs_max_pending; /* MAX requests at once to server*/

extern const struct slow_work_ops cifs_oplock_break_ops;
+
+#endif /* _CIFS_GLOB_H */
--
1.6.4.2

2010-06-22 21:35:49

by Jeffrey Layton

Subject: Re: [RFC][PATCH 02/10] cifs: guard cifsglob.h against multiple inclusion

On Tue, 22 Jun 2010 20:52:50 +0530
Suresh Jayaraman <[email protected]> wrote:

> Add conditional compile macros to guard the header file against multiple
> inclusion.
>
> Signed-off-by: Suresh Jayaraman <[email protected]>
> ---
> fs/cifs/cifsglob.h | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h
> index a88479c..6b2c39d 100644
> --- a/fs/cifs/cifsglob.h
> +++ b/fs/cifs/cifsglob.h
> @@ -16,6 +16,9 @@
> * the GNU Lesser General Public License for more details.
> *
> */
> +#ifndef _CIFS_GLOB_H
> +#define _CIFS_GLOB_H
> +
> #include <linux/in.h>
> #include <linux/in6.h>
> #include <linux/slab.h>
> @@ -733,3 +736,5 @@ GLOBAL_EXTERN unsigned int cifs_min_small; /* min size of small buf pool */
> GLOBAL_EXTERN unsigned int cifs_max_pending; /* MAX requests at once to server*/
>
> extern const struct slow_work_ops cifs_oplock_break_ops;
> +
> +#endif /* _CIFS_GLOB_H */

Strong ACK

Acked-by: Jeff Layton <[email protected]>