2010-06-22 19:06:14

by Denys Vlasenko

Subject: [PATCH] fbcon: deinline large static function get_color()

This function's body is good two screenfuls and it has six callsites.
No apparent reason why it is marked "iniline".

Signed-off-by: Denys Vlasenko <[email protected]>
---
drivers/video/console/fbcon.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
index b0a3fa0..24983e4 100644
--- a/drivers/video/console/fbcon.c
+++ b/drivers/video/console/fbcon.c
@@ -286,7 +286,7 @@ static inline int fbcon_is_inactive(struct vc_data *vc, struct fb_info *info)
vc->vc_mode != KD_TEXT || ops->graphics);
}

-static inline int get_color(struct vc_data *vc, struct fb_info *info,
+static int get_color(struct vc_data *vc, struct fb_info *info,
u16 c, int is_fg)
{
int depth = fb_get_color_depth(&info->var, &info->fix);
--
1.6.2.5

2010-06-23 15:58:46

by James Simmons

Subject: Re: [PATCH] fbcon: deinline large static function get_color()

> This function's body is good two screenfuls and it has six callsites.
> No apparent reason why it is marked "iniline".
>
> Signed-off-by: Denys Vlasenko <[email protected]>

Signed-off-by: James Simmons <[email protected]>

> ---
> drivers/video/console/fbcon.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
> index b0a3fa0..24983e4 100644
> --- a/drivers/video/console/fbcon.c
> +++ b/drivers/video/console/fbcon.c
> @@ -286,7 +286,7 @@ static inline int fbcon_is_inactive(struct vc_data *vc, struct fb_info *info)
> vc->vc_mode != KD_TEXT || ops->graphics);
> }
>
> -static inline int get_color(struct vc_data *vc, struct fb_info *info,
> +static int get_color(struct vc_data *vc, struct fb_info *info,
> u16 c, int is_fg)
> {
> int depth = fb_get_color_depth(&info->var, &info->fix);
> --
> 1.6.2.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>