The spectra driver doesn't compile with today linux-next
The problem is that it tries to use a blk_fs_request macro. Searching for this macro I saw that it used to exist in linux/blkdev.h as
#define blk_fs_request(rq) ((rq)->cmd_type == REQ_TYPE_FS)
This patch solves the issue eliminating the unnecessary (and now inexistent) wrapper
Best regards,
>From 755f948d65ff67d5dc8dde8c2edd212cbe61bd5f Mon Sep 17 00:00:00 2001
From: Javier Martinez Canillas <[email protected]>
Date: Fri, 25 Jun 2010 00:26:20 -0400
Subject: [PATCH] staging/spectra: remove non existing blk_fs_request wrapper
Signed-off-by: Javier Martinez Canillas <[email protected]>
---
drivers/staging/spectra/ffsport.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/spectra/ffsport.c b/drivers/staging/spectra/ffsport.c
index 3c3565d..d0c5c97 100644
--- a/drivers/staging/spectra/ffsport.c
+++ b/drivers/staging/spectra/ffsport.c
@@ -304,7 +304,7 @@ static int do_transfer(struct spectra_nand_dev *tr, struct request *req)
return 0;
}
- if (!blk_fs_request(req))
+ if (req->cmd_type != REQ_TYPE_FS)
return -EIO;
if (blk_rq_pos(req) + blk_rq_cur_sectors(req) > get_capacity(tr->gd)) {
--
1.7.0.4
On Fri, 25 Jun 2010 00:40:48 -0400 Javier Martinez Canillas wrote:
> The spectra driver doesn't compile with today linux-next
>
> The problem is that it tries to use a blk_fs_request macro. Searching for this macro I saw that it used to exist in linux/blkdev.h as
>
> #define blk_fs_request(rq) ((rq)->cmd_type == REQ_TYPE_FS)
>
> This patch solves the issue eliminating the unnecessary (and now inexistent) wrapper
>
> Best regards,
>
> >From 755f948d65ff67d5dc8dde8c2edd212cbe61bd5f Mon Sep 17 00:00:00 2001
> From: Javier Martinez Canillas <[email protected]>
> Date: Fri, 25 Jun 2010 00:26:20 -0400
> Subject: [PATCH] staging/spectra: remove non existing blk_fs_request wrapper
>
>
> Signed-off-by: Javier Martinez Canillas <[email protected]>
Acked-by: Randy Dunlap <[email protected]>
Thanks.
> ---
> drivers/staging/spectra/ffsport.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/spectra/ffsport.c b/drivers/staging/spectra/ffsport.c
> index 3c3565d..d0c5c97 100644
> --- a/drivers/staging/spectra/ffsport.c
> +++ b/drivers/staging/spectra/ffsport.c
> @@ -304,7 +304,7 @@ static int do_transfer(struct spectra_nand_dev *tr, struct request *req)
> return 0;
> }
>
> - if (!blk_fs_request(req))
> + if (req->cmd_type != REQ_TYPE_FS)
> return -EIO;
>
> if (blk_rq_pos(req) + blk_rq_cur_sectors(req) > get_capacity(tr->gd)) {
> --
> 1.7.0.4
>
>
>
>
>
> _______________________________________________
> devel mailing list
> [email protected]
> http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***