2010-06-29 10:15:12

by Kulikov Vasiliy

Subject: [PATCH 02/25] n2-drv: remove casts from void*

Remove unnesessary casts from void*.

Signed-off-by: Kulikov Vasiliy <[email protected]>
---
drivers/char/hw_random/n2-drv.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/char/hw_random/n2-drv.c b/drivers/char/hw_random/n2-drv.c
index 0f9cbf1..101d5f2 100644
--- a/drivers/char/hw_random/n2-drv.c
+++ b/drivers/char/hw_random/n2-drv.c
@@ -387,7 +387,7 @@ static int n2rng_init_control(struct n2rng *np)

static int n2rng_data_read(struct hwrng *rng, u32 *data)
{
- struct n2rng *np = (struct n2rng *) rng->priv;
+ struct n2rng *np = rng->priv;
unsigned long ra = __pa(&np->test_data);
int len;

--
1.7.0.4

2010-06-29 10:40:01

by Daniel Mack

Subject: Re: [PATCH 02/25] n2-drv: remove casts from void*

On Tue, Jun 29, 2010 at 02:15:01PM +0400, Kulikov Vasiliy wrote:
> Remove unnesessary casts from void*.

I have no idea how I made it to this list of recipients, but the change
looks sane to me :)


Daniel


> Signed-off-by: Kulikov Vasiliy <[email protected]>
> ---
> drivers/char/hw_random/n2-drv.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/char/hw_random/n2-drv.c b/drivers/char/hw_random/n2-drv.c
> index 0f9cbf1..101d5f2 100644
> --- a/drivers/char/hw_random/n2-drv.c
> +++ b/drivers/char/hw_random/n2-drv.c
> @@ -387,7 +387,7 @@ static int n2rng_init_control(struct n2rng *np)
>
> static int n2rng_data_read(struct hwrng *rng, u32 *data)
> {
> - struct n2rng *np = (struct n2rng *) rng->priv;
> + struct n2rng *np = rng->priv;
> unsigned long ra = __pa(&np->test_data);
> int len;
>
> --
> 1.7.0.4
>

2010-07-05 13:25:51

by Herbert Xu

Subject: Re: [PATCH 02/25] n2-drv: remove casts from void*

On Tue, Jun 29, 2010 at 02:15:01PM +0400, Kulikov Vasiliy wrote:
> Remove unnesessary casts from void*.
>
> Signed-off-by: Kulikov Vasiliy <[email protected]>

Patch applied. Thank you.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt