2010-06-29 10:16:25

by Kulikov Vasiliy

Subject: [PATCH 21/25] vme_ca91cx42: remove casts from void*

Remove unnesessary casts from void*.

Signed-off-by: Kulikov Vasiliy <[email protected]>
---
drivers/staging/vme/bridges/vme_ca91cx42.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/vme/bridges/vme_ca91cx42.c b/drivers/staging/vme/bridges/vme_ca91cx42.c
index 0c82eb4..ce05ffa 100644
--- a/drivers/staging/vme/bridges/vme_ca91cx42.c
+++ b/drivers/staging/vme/bridges/vme_ca91cx42.c
@@ -961,11 +961,11 @@ int ca91cx42_dma_list_add(struct vme_dma_list *list, struct vme_dma_attr *src,

if (dest->type == VME_DMA_VME) {
entry->descriptor.dctl |= CA91CX42_DCTL_L2V;
- vme_attr = (struct vme_dma_vme *)dest->private;
- pci_attr = (struct vme_dma_pci *)src->private;
+ vme_attr = dest->private;
+ pci_attr = src->private;
} else {
- vme_attr = (struct vme_dma_vme *)src->private;
- pci_attr = (struct vme_dma_pci *)dest->private;
+ vme_attr = src->private;
+ pci_attr = dest->private;
}

/* Check we can do fullfill required attributes */
--
1.7.0.4

2010-07-05 10:39:14

by Martyn Welch

Subject: Re: [PATCH 21/25] vme_ca91cx42: remove casts from void*

Kulikov Vasiliy wrote:
> Remove unnesessary casts from void*.
>
> Signed-off-by: Kulikov Vasiliy <[email protected]>
>
Seems ok, cheers,

Signed-off-by: Martyn Welch <[email protected]>


> ---
> drivers/staging/vme/bridges/vme_ca91cx42.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/vme/bridges/vme_ca91cx42.c b/drivers/staging/vme/bridges/vme_ca91cx42.c
> index 0c82eb4..ce05ffa 100644
> --- a/drivers/staging/vme/bridges/vme_ca91cx42.c
> +++ b/drivers/staging/vme/bridges/vme_ca91cx42.c
> @@ -961,11 +961,11 @@ int ca91cx42_dma_list_add(struct vme_dma_list *list, struct vme_dma_attr *src,
>
> if (dest->type == VME_DMA_VME) {
> entry->descriptor.dctl |= CA91CX42_DCTL_L2V;
> - vme_attr = (struct vme_dma_vme *)dest->private;
> - pci_attr = (struct vme_dma_pci *)src->private;
> + vme_attr = dest->private;
> + pci_attr = src->private;
> } else {
> - vme_attr = (struct vme_dma_vme *)src->private;
> - pci_attr = (struct vme_dma_pci *)dest->private;
> + vme_attr = src->private;
> + pci_attr = dest->private;
> }
>
> /* Check we can do fullfill required attributes */
>


--
Martyn Welch (Principal Software Engineer) | Registered in England and
GE Intelligent Platforms | Wales (3828642) at 100
T +44(0)127322748 | Barbirolli Square, Manchester,
E [email protected] | M2 3AB VAT:GB 927559189