2010-06-30 02:18:06

by Axel Lin

[permalink] [raw]
Subject: [PATCH] acer-wmi: set permissions on interface file to S_IRUGO

The interface file is not writable, thus set permissions to S_IRUGO.

Signed-off-by: Axel Lin <[email protected]>
---
drivers/platform/x86/acer-wmi.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index 1415d97..fe7c9e4 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -1084,8 +1084,7 @@ static ssize_t show_interface(struct device *dev, struct device_attribute *attr,
}
}

-static DEVICE_ATTR(interface, S_IWUGO | S_IRUGO | S_IWUSR,
- show_interface, NULL);
+static DEVICE_ATTR(interface, S_IRUGO, show_interface, NULL);

/*
* debugfs functions
--
1.5.4.3



2010-07-01 13:53:34

by Matthew Garrett

[permalink] [raw]
Subject: Re: [PATCH] acer-wmi: set permissions on interface file to S_IRUGO

On Wed, Jun 30, 2010 at 10:20:23AM +0800, Axel Lin wrote:
> The interface file is not writable, thus set permissions to S_IRUGO.
>
> Signed-off-by: Axel Lin <[email protected]>

Applied, thanks.

--
Matthew Garrett | [email protected]