2010-06-30 09:10:11

by Tomi Valkeinen

[permalink] [raw]
Subject: Re: [PATCH] OMAP2:OMAPFB: Fix error path

Hi,

Please send the patch as plaintext, without any HTML content.

Also, use the same patch subject as other patches for omapfb, in this
case "OMAP: DSS2: OMAPFB: ...", and include a bit more verbose
description.

Tomi


On Tue, 2010-06-29 at 22:29 +0200, ext Afzal Mohammed wrote:
>
>
> sysfs file removed in error path of omapfb_create_framebuffers()
>
>
> Signed-off-by: Afzal Mohammed <[email protected]>
> ---
> drivers/video/omap2/omapfb/omapfb-main.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
>
> diff --git a/drivers/video/omap2/omapfb/omapfb-main.c
> b/drivers/video/omap2/omapfb/omapfb-main.c
> index 4b4506d..2319b81 100644
> --- a/drivers/video/omap2/omapfb/omapfb-main.c
> +++ b/drivers/video/omap2/omapfb/omapfb-main.c
> @@ -1945,6 +1945,7 @@ static int omapfb_create_framebuffers(struct
> omapfb2_device *fbdev)
> r = omapfb_overlay_enable(ovl, 1);
>
> if (r) {
> + omapfb_remove_sysfs(fbdev);
> dev_err(fbdev->dev,
> "failed to enable overlay\n");
> return r;
> --
> 1.7.0.4
>
>