2010-07-03 16:03:58

by Kulikov Vasiliy

Subject: [PATCH 05/19] arch/x86/kernel: use for_each_pci_dev()

Use for_each_pci_dev() to simplify the code.

Signed-off-by: Kulikov Vasiliy <[email protected]>
---
arch/x86/kernel/amd_iommu.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/amd_iommu.c b/arch/x86/kernel/amd_iommu.c
index 0d20286..29dd3b9 100644
--- a/arch/x86/kernel/amd_iommu.c
+++ b/arch/x86/kernel/amd_iommu.c
@@ -2609,8 +2609,7 @@ int __init amd_iommu_init_passthrough(void)

pt_domain->mode |= PAGE_MODE_NONE;

- while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) {
-
+ for_each_pci_dev(dev) {
if (!check_device(&dev->dev))
continue;

--
1.7.0.4

2010-07-19 13:40:46

by Joerg Roedel

Subject: Re: [PATCH 05/19] arch/x86/kernel: use for_each_pci_dev()

On Sat, Jul 03, 2010 at 12:03:51PM -0400, Kulikov Vasiliy wrote:
> Use for_each_pci_dev() to simplify the code.
>
> Signed-off-by: Kulikov Vasiliy <[email protected]>
> ---
> arch/x86/kernel/amd_iommu.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/amd_iommu.c b/arch/x86/kernel/amd_iommu.c
> index 0d20286..29dd3b9 100644
> --- a/arch/x86/kernel/amd_iommu.c
> +++ b/arch/x86/kernel/amd_iommu.c
> @@ -2609,8 +2609,7 @@ int __init amd_iommu_init_passthrough(void)
>
> pt_domain->mode |= PAGE_MODE_NONE;
>
> - while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) {
> -
> + for_each_pci_dev(dev) {
> if (!check_device(&dev->dev))
> continue;

Applied, thanks.

--
Joerg Roedel - AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632