2010-07-06 12:29:54

by Suresh Jayaraman

Subject: [PATCH] cifs: remove unused ip_address field in struct TCP_Server_Info

The ip_address field is not used and seems redundant as there is union addr
already and I don't see any future use as well.

Signed-off-by: Suresh Jayaraman <[email protected]>
---
fs/cifs/cifsglob.h | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h
index a88479c..f182fe8 100644
--- a/fs/cifs/cifsglob.h
+++ b/fs/cifs/cifsglob.h
@@ -142,7 +142,6 @@ struct TCP_Server_Info {
struct list_head pending_mid_q;
void *Server_NlsInfo; /* BB - placeholder for future NLS info */
unsigned short server_codepage; /* codepage for the server */
- unsigned long ip_address; /* IP addr for the server if known */
enum protocolEnum protocolType;
char versionMajor;
char versionMinor;

2010-07-06 18:22:11

by Steve French

Subject: Re: [PATCH] cifs: remove unused ip_address field in struct TCP_Server_Info

Makes sense - plan to merge this and two others of yours into
cifs-2.6.git today or tomorrow.

On Tue, Jul 6, 2010 at 7:29 AM, Suresh Jayaraman <[email protected]> wrote:
> The ip_address field is not used and seems redundant as there is union addr
> already and I don't see any future use as well.
>
> Signed-off-by: Suresh Jayaraman <[email protected]>
> ---
> ?fs/cifs/cifsglob.h | ? ?1 -
> ?1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h
> index a88479c..f182fe8 100644
> --- a/fs/cifs/cifsglob.h
> +++ b/fs/cifs/cifsglob.h
> @@ -142,7 +142,6 @@ struct TCP_Server_Info {
> ? ? ? ?struct list_head pending_mid_q;
> ? ? ? ?void *Server_NlsInfo; ? /* BB - placeholder for future NLS info ?*/
> ? ? ? ?unsigned short server_codepage; /* codepage for the server ? ?*/
> - ? ? ? unsigned long ip_address; ? ? ? /* IP addr for the server if known */
> ? ? ? ?enum protocolEnum protocolType;
> ? ? ? ?char versionMajor;
> ? ? ? ?char versionMinor;
>



--
Thanks,

Steve