2010-07-01 20:36:41

by Roel Kluin

Subject: [PATCH] USB: Don't return 0 if writing the download record failed

If the write download record failed we shouldn't return 0.

Signed-off-by: Roel Kluin <[email protected]>
---
Maybe a different error value is more appropriate?

diff --git a/drivers/usb/serial/io_ti.c b/drivers/usb/serial/io_ti.c
index 0fca265..03696b9 100644
--- a/drivers/usb/serial/io_ti.c
+++ b/drivers/usb/serial/io_ti.c
@@ -1321,7 +1321,7 @@ static int download_fw(struct edgeport_serial *serial)
kfree(header);
kfree(rom_desc);
kfree(ti_manuf_desc);
- return status;
+ return -EINVAL;
}

kfree(vheader);

2010-07-08 18:46:23

by Greg KH

Subject: patch "USB: serial: io_ti: Don't return 0 if writing the download record failed" added to gregkh-2.6 tree

This is a note to let you know that I've just added the patch titled

USB: serial: io_ti: Don't return 0 if writing the download record failed

to my gregkh-2.6 tree which can be found in directory form at:
http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/
and in git form at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/patches.git

The filename of this patch is:
usb-serial-io_ti-don-t-return-0-if-writing-the-download-record-failed.patch

The patch will show up in the next release of the linux-next tree
(usually sometime within the next 24 hours during the week.)

If this patch meets the merge guidelines for a bugfix, it should be
merged into Linus's tree before the next major kernel release.
If not, it will be merged into Linus's tree during the next merge window.

Either way, you will probably be copied on the patch when it gets sent
to Linus for merging so that others can see what is happening in kernel
development.

If you have any questions about this process, please let me know.


>From [email protected] Thu Jul 8 11:35:42 2010
From: Roel Kluin <[email protected]>
Date: Fri, 02 Jul 2010 00:36:43 +0200
Subject: USB: serial: io_ti: Don't return 0 if writing the download record failed
To: Greg Kroah-Hartman <[email protected]>, [email protected], Andrew Morton <[email protected]>, LKML <[email protected]>
Message-ID: <[email protected]>


If the write download record failed we shouldn't return 0.

Signed-off-by: Roel Kluin <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

---
drivers/usb/serial/io_ti.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/usb/serial/io_ti.c
+++ b/drivers/usb/serial/io_ti.c
@@ -1321,7 +1321,7 @@ static int download_fw(struct edgeport_s
kfree(header);
kfree(rom_desc);
kfree(ti_manuf_desc);
- return status;
+ return -EINVAL;
}

kfree(vheader);