2010-07-14 09:17:51

by Andreas Bießmann

[permalink] [raw]
Subject: [PATCH] atmel_nand: Fix warning: 'part_probes' defined but not used

This patch fixes

drivers/mtd/nand/atmel_nand.c:372: warning: 'part_probes' defined but not used

which is issued when CONFIG_MTD_PARTITIONS is defined but
CONFIG_MTD_CMDLINE_PARTS not.

Signed-off-by: Andreas Bießmann <[email protected]>
---
drivers/mtd/nand/atmel_nand.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
index 04d3088..ccce0f0 100644
--- a/drivers/mtd/nand/atmel_nand.c
+++ b/drivers/mtd/nand/atmel_nand.c
@@ -364,7 +364,7 @@ static void atmel_nand_hwctl(struct mtd_info *mtd, int mode)
}
}

-#ifdef CONFIG_MTD_PARTITIONS
+#ifdef CONFIG_MTD_CMDLINE_PARTS
static const char *part_probes[] = { "cmdlinepart", NULL };
#endif

--
1.7.1


2010-08-05 10:39:54

by Andreas Bießmann

[permalink] [raw]
Subject: [PATCH] atmel_nand: Fix warning: 'part_probes' defined but not used

This patch fixes

drivers/mtd/nand/atmel_nand.c:372: warning: 'part_probes' defined but not used

which is issued when CONFIG_MTD_PARTITIONS is defined but
CONFIG_MTD_CMDLINE_PARTS not.

Signed-off-by: Andreas Bießmann <[email protected]>
---
Resent this patch as a trivial one cause it does only fix a warning which is
seen in very rare cases. There is no functionality change here! I think this
is the definition of a trivial patch.

In addition no one has commented my last submission of this patch.

drivers/mtd/nand/atmel_nand.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
index 04d3088..ccce0f0 100644
--- a/drivers/mtd/nand/atmel_nand.c
+++ b/drivers/mtd/nand/atmel_nand.c
@@ -364,7 +364,7 @@ static void atmel_nand_hwctl(struct mtd_info *mtd, int mode)
}
}

-#ifdef CONFIG_MTD_PARTITIONS
+#ifdef CONFIG_MTD_CMDLINE_PARTS
static const char *part_probes[] = { "cmdlinepart", NULL };
#endif

--
1.7.1

2010-08-05 11:25:23

by Artem Bityutskiy

[permalink] [raw]
Subject: Re: [PATCH] atmel_nand: Fix warning: 'part_probes' defined but not used

On Thu, 2010-08-05 at 12:38 +0200, Andreas Bießmann wrote:
> This patch fixes
>
> drivers/mtd/nand/atmel_nand.c:372: warning: 'part_probes' defined but not used
>
> which is issued when CONFIG_MTD_PARTITIONS is defined but
> CONFIG_MTD_CMDLINE_PARTS not.
>
> Signed-off-by: Andreas Bießmann <[email protected]>

Pushed to my l2-mtd-2.6.git / master

--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)