2010-07-14 18:06:34

by Kulikov Vasiliy

Subject: [PATCH 10/11] staging: msm: formatting of pointers in printk()

Use %p instead of %08x in printk().

Signed-off-by: Kulikov Vasiliy <[email protected]>
---
drivers/staging/msm/mdp4_overlay.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/msm/mdp4_overlay.c b/drivers/staging/msm/mdp4_overlay.c
index 304bb82..de284c2 100644
--- a/drivers/staging/msm/mdp4_overlay.c
+++ b/drivers/staging/msm/mdp4_overlay.c
@@ -874,8 +874,8 @@ struct mdp4_overlay_pipe *mdp4_overlay_pipe_alloc(void)
if (pipe->pipe_ndx == 0) {
pipe->pipe_ndx = i + 1; /* start from 1 */
init_completion(&pipe->comp);
- printk(KERN_INFO "mdp4_overlay_pipe_alloc: pipe=%x ndx=%d\n",
- (int)pipe, pipe->pipe_ndx);
+ printk(KERN_INFO "mdp4_overlay_pipe_alloc: pipe=%p ndx=%d\n",
+ pipe, pipe->pipe_ndx);
return pipe;
}
pipe++;
@@ -887,8 +887,8 @@ struct mdp4_overlay_pipe *mdp4_overlay_pipe_alloc(void)

void mdp4_overlay_pipe_free(struct mdp4_overlay_pipe *pipe)
{
- printk(KERN_INFO "mdp4_overlay_pipe_free: pipe=%x ndx=%d\n",
- (int)pipe, pipe->pipe_ndx);
+ printk(KERN_INFO "mdp4_overlay_pipe_free: pipe=%p ndx=%d\n",
+ pipe, pipe->pipe_ndx);
memset(pipe, 0, sizeof(*pipe));
}

--
1.7.0.4

2010-07-14 22:28:49

by David Brown

Subject: Re: [PATCH 10/11] staging: msm: formatting of pointers in printk()

On Wednesday 14 July 2010 11:05:58 Kulikov Vasiliy wrote:

> Use %p instead of %08x in printk().
>
> Signed-off-by: Kulikov Vasiliy <[email protected]>

Acked-by: David Brown <[email protected]>

2010-07-14 22:29:48

by Daniel Walker

Subject: Re: [PATCH 10/11] staging: msm: formatting of pointers in printk()

On Wed, 2010-07-14 at 15:28 -0700, David Brown wrote:
> On Wednesday 14 July 2010 11:05:58 Kulikov Vasiliy wrote:
>
> > Use %p instead of %08x in printk().
> >
> > Signed-off-by: Kulikov Vasiliy <[email protected]>
>
> Acked-by: David Brown <[email protected]>

yeah, it looks fine to me too.

Daniel

--
Sent by an consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.