2010-07-16 16:16:37

by Kulikov Vasiliy

Subject: [PATCH 13/15] sound/soc: davinci: check kzalloc() result (typo)

The code checks 'davinci_vc' after kzalloc() and do not checks
'davinci_vcif_dev' that kzalloc() result is assigned to. It seems that
it is a typo (autocompletion?).

Signed-off-by: Kulikov Vasiliy <[email protected]>
---
sound/soc/davinci/davinci-vcif.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/soc/davinci/davinci-vcif.c b/sound/soc/davinci/davinci-vcif.c
index 9aa980d..4867853 100644
--- a/sound/soc/davinci/davinci-vcif.c
+++ b/sound/soc/davinci/davinci-vcif.c
@@ -203,7 +203,7 @@ static int davinci_vcif_probe(struct platform_device *pdev)
int ret;

davinci_vcif_dev = kzalloc(sizeof(struct davinci_vcif_dev), GFP_KERNEL);
- if (!davinci_vc) {
+ if (!davinci_vcif_dev) {
dev_dbg(&pdev->dev,
"could not allocate memory for private data\n");
return -ENOMEM;
--
1.7.0.4

2010-07-17 17:45:40

by Liam Girdwood

Subject: Re: [PATCH 13/15] sound/soc: davinci: check kzalloc() result (typo)

On Fri, 2010-07-16 at 20:16 +0400, Kulikov Vasiliy wrote:
> The code checks 'davinci_vc' after kzalloc() and do not checks
> 'davinci_vcif_dev' that kzalloc() result is assigned to. It seems that
> it is a typo (autocompletion?).
>
> Signed-off-by: Kulikov Vasiliy <[email protected]>
> ---
> sound/soc/davinci/davinci-vcif.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/davinci/davinci-vcif.c b/sound/soc/davinci/davinci-vcif.c
> index 9aa980d..4867853 100644
> --- a/sound/soc/davinci/davinci-vcif.c
> +++ b/sound/soc/davinci/davinci-vcif.c
> @@ -203,7 +203,7 @@ static int davinci_vcif_probe(struct platform_device *pdev)
> int ret;
>
> davinci_vcif_dev = kzalloc(sizeof(struct davinci_vcif_dev), GFP_KERNEL);
> - if (!davinci_vc) {
> + if (!davinci_vcif_dev) {
> dev_dbg(&pdev->dev,
> "could not allocate memory for private data\n");
> return -ENOMEM;

13,14 & 15

Acked-by: Liam Girdwood <[email protected]>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

2010-07-17 18:47:10

by Mark Brown

Subject: Re: [PATCH 13/15] sound/soc: davinci: check kzalloc() result (typo)

On Sat, Jul 17, 2010 at 06:45:33PM +0100, Liam Girdwood wrote:
> On Fri, 2010-07-16 at 20:16 +0400, Kulikov Vasiliy wrote:
> > The code checks 'davinci_vc' after kzalloc() and do not checks
> > 'davinci_vcif_dev' that kzalloc() result is assigned to. It seems that
> > it is a typo (autocompletion?).

> > Signed-off-by: Kulikov Vasiliy <[email protected]>

> Acked-by: Liam Girdwood <[email protected]>

Applied, thanks. Kulikov could you please check the subject lines
you're using for your patches - try to be consistent with the rest of
the patches for the same code area.