2010-07-23 16:35:08

by Kulikov Vasiliy

Subject: [PATCH] char: mxser: remove unnesesary NULL check

mxser_transmit_chars(tty, port) is called only from mxser_interrupt().
NULL check is performed in mxser_interrupt() so it is redundant here.

Signed-off-by: Kulikov Vasiliy <[email protected]>
---
drivers/char/mxser.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/char/mxser.c b/drivers/char/mxser.c
index d2692d4..3fc89da 100644
--- a/drivers/char/mxser.c
+++ b/drivers/char/mxser.c
@@ -2193,7 +2193,7 @@ static void mxser_transmit_chars(struct tty_struct *tty, struct mxser_port *port
port->mon_data.up_txcnt += (cnt - port->xmit_cnt);
port->icount.tx += (cnt - port->xmit_cnt);

- if (port->xmit_cnt < WAKEUP_CHARS && tty)
+ if (port->xmit_cnt < WAKEUP_CHARS)
tty_wakeup(tty);

if (port->xmit_cnt <= 0) {
--
1.7.0.4

2010-07-23 19:18:57

by Jiri Slaby

Subject: Re: [PATCH] char: mxser: remove unnesesary NULL check

On 07/23/2010 06:34 PM, Kulikov Vasiliy wrote:
> mxser_transmit_chars(tty, port) is called only from mxser_interrupt().
> NULL check is performed in mxser_interrupt() so it is redundant here.
>
> Signed-off-by: Kulikov Vasiliy <[email protected]>

Acked-by: Jiri Slaby <[email protected]>

> ---
> drivers/char/mxser.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/char/mxser.c b/drivers/char/mxser.c
> index d2692d4..3fc89da 100644
> --- a/drivers/char/mxser.c
> +++ b/drivers/char/mxser.c
> @@ -2193,7 +2193,7 @@ static void mxser_transmit_chars(struct tty_struct *tty, struct mxser_port *port
> port->mon_data.up_txcnt += (cnt - port->xmit_cnt);
> port->icount.tx += (cnt - port->xmit_cnt);
>
> - if (port->xmit_cnt < WAKEUP_CHARS && tty)
> + if (port->xmit_cnt < WAKEUP_CHARS)
> tty_wakeup(tty);
>
> if (port->xmit_cnt <= 0) {


--
js