2023-07-27 16:09:27

by Colin Ian King

[permalink] [raw]
Subject: [PATCH][next] rtla: Fix uninitialized variable found

Variable found is not being initialized, in the case where the desired
mount is not found the variable contains garbage. Fix this by initializing
it to zero.

Fixes: a957cbc02531 ("rtla: Add -C cgroup support")
Signed-off-by: Colin Ian King <[email protected]>
---
tools/tracing/rtla/src/utils.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/tracing/rtla/src/utils.c b/tools/tracing/rtla/src/utils.c
index 623a38908ed5..c769d7b3842c 100644
--- a/tools/tracing/rtla/src/utils.c
+++ b/tools/tracing/rtla/src/utils.c
@@ -538,7 +538,7 @@ static const int find_mount(const char *fs, char *mp, int sizeof_mp)
{
char mount_point[MAX_PATH];
char type[100];
- int found;
+ int found = 0;
FILE *fp;

fp = fopen("/proc/mounts", "r");
--
2.39.2



Subject: Re: [PATCH][next] rtla: Fix uninitialized variable found

On 7/27/23 17:01, Colin Ian King wrote:
> Variable found is not being initialized, in the case where the desired
> mount is not found the variable contains garbage. Fix this by initializing
> it to zero.
>
> Fixes: a957cbc02531 ("rtla: Add -C cgroup support")
> Signed-off-by: Colin Ian King <[email protected]>

Acked-by: Daniel Bristot de Oliveira <[email protected]>

Thanks!
-- Daniel