2010-07-25 04:50:46

by Javier Martinez Canillas

Subject: [PATCH] x86, mrst: remove unused mrst_identify_cpu()

mrst_identify_cpu() function is not been used anymore (at today linux-next). This patch removes it.

Signed-off-by: Javier Martinez Canillas <[email protected]>
---
arch/x86/include/asm/mrst.h | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/arch/x86/include/asm/mrst.h b/arch/x86/include/asm/mrst.h
index 1635074..0d0e702 100644
--- a/arch/x86/include/asm/mrst.h
+++ b/arch/x86/include/asm/mrst.h
@@ -26,10 +26,6 @@ enum mrst_cpu_type {
};

extern enum mrst_cpu_type __mrst_cpu_chip;
-static enum mrst_cpu_type mrst_identify_cpu(void)
-{
- return __mrst_cpu_chip;
-}

enum mrst_timer_options {
MRST_TIMER_DEFAULT,
--
1.7.0.4

2010-07-25 05:05:22

by H. Peter Anvin

Subject: Re: [PATCH] x86, mrst: remove unused mrst_identify_cpu()

Jacob, is this obsolete or something that will be needed in future versions?

It seems that either __mrst_cpu_chip should be killed off, or read-only
users should be using the inline instead of __mrst_cpu_chip directly.

-hpa

On 07/24/2010 09:50 PM, Javier Martinez Canillas wrote:
> mrst_identify_cpu() function is not been used anymore (at today linux-next). This patch removes it.
>
> Signed-off-by: Javier Martinez Canillas <[email protected]>
> ---
> arch/x86/include/asm/mrst.h | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/arch/x86/include/asm/mrst.h b/arch/x86/include/asm/mrst.h
> index 1635074..0d0e702 100644
> --- a/arch/x86/include/asm/mrst.h
> +++ b/arch/x86/include/asm/mrst.h
> @@ -26,10 +26,6 @@ enum mrst_cpu_type {
> };
>
> extern enum mrst_cpu_type __mrst_cpu_chip;
> -static enum mrst_cpu_type mrst_identify_cpu(void)
> -{
> - return __mrst_cpu_chip;
> -}
>
> enum mrst_timer_options {
> MRST_TIMER_DEFAULT,


--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.

2010-07-25 10:43:21

by Alan

Subject: Re: [PATCH] x86, mrst: remove unused mrst_identify_cpu()

On Sun, 25 Jul 2010 00:50:38 -0400
Javier Martinez Canillas <[email protected]> wrote:

> mrst_identify_cpu() function is not been used anymore (at today linux-next). This patch removes it.

NAK

This is stuff being merged.

If you are going to try and remove stuff, -next is not the place to
track !

2010-07-25 10:44:18

by Alan

Subject: Re: [PATCH] x86, mrst: remove unused mrst_identify_cpu()

On Sat, 24 Jul 2010 22:04:45 -0700
"H. Peter Anvin" <[email protected]> wrote:

> Jacob, is this obsolete or something that will be needed in future versions?
>
> It seems that either __mrst_cpu_chip should be killed off, or read-only
> users should be using the inline instead of __mrst_cpu_chip directly.

And how is the inline going to access the variable if the variable isn't
global ...

Alan

2010-07-25 18:56:33

by H. Peter Anvin

Subject: Re: [PATCH] x86, mrst: remove unused mrst_identify_cpu()

On 07/25/2010 03:55 AM, Alan Cox wrote:
> On Sat, 24 Jul 2010 22:04:45 -0700
> "H. Peter Anvin" <[email protected]> wrote:
>
>> Jacob, is this obsolete or something that will be needed in future versions?
>>
>> It seems that either __mrst_cpu_chip should be killed off, or read-only
>> users should be using the inline instead of __mrst_cpu_chip directly.
>
> And how is the inline going to access the variable if the variable isn't
> global ...
>
> Alan

Well, of course it needs to be global. The "or" in the above sentence
is an xor.

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.