2010-07-26 08:27:45

by Kulikov Vasiliy

Subject: [PATCH] afs: do not set task state after schedule_timeout()

schedule_timeout() sets tast state to TASK_RUNNING, so there's no need
to set it explicitly.

Signed-off-by: Kulikov Vasiliy <[email protected]>
---
fs/afs/vlocation.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/fs/afs/vlocation.c b/fs/afs/vlocation.c
index 9ac260d..21f270d 100644
--- a/fs/afs/vlocation.c
+++ b/fs/afs/vlocation.c
@@ -130,7 +130,6 @@ static int afs_vlocation_access_vl_by_id(struct afs_vlocation *vl,
/* second+ BUSY - sleep a little bit */
set_current_state(TASK_UNINTERRUPTIBLE);
schedule_timeout(1);
- __set_current_state(TASK_RUNNING);
}
continue;
}
--
1.7.0.4

2010-07-26 11:33:10

by David Howells

Subject: Re: [PATCH] afs: do not set task state after schedule_timeout()

Kulikov Vasiliy <[email protected]> wrote:

> schedule_timeout() sets tast state to TASK_RUNNING, so there's no need
> to set it explicitly.
>
> Signed-off-by: Kulikov Vasiliy <[email protected]>

Acked-by: David Howells <[email protected]>