2010-07-28 16:39:11

by Kulikov Vasiliy

Subject: [PATCH 01/10] arm: leds: check return value of request_region()

request_region() may fail, if so return -ENOMEM.

Signed-off-by: Kulikov Vasiliy <[email protected]>
---
arch/arm/mach-shark/leds.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-shark/leds.c b/arch/arm/mach-shark/leds.c
index c9e32de..cb1a8f2 100644
--- a/arch/arm/mach-shark/leds.c
+++ b/arch/arm/mach-shark/leds.c
@@ -155,7 +155,8 @@ static int __init leds_init(void)
leds_event = sequoia_leds_event;

/* Make LEDs independent of power-state */
- request_region(0x24,4,"sequoia");
+ if (request_region(0x24, 4, "sequoia") == NULL)
+ return -ENOMEM;
temp = sequoia_read(0x09);
temp |= 1<<10;
sequoia_write(temp,0x09);
--
1.7.0.4

2010-07-28 18:02:17

by Dan Carpenter

Subject: Re: [PATCH 01/10] arm: leds: check return value of request_region()

On Wed, Jul 28, 2010 at 08:38:47PM +0400, Kulikov Vasiliy wrote:
> request_region() may fail, if so return -ENOMEM.

I think -EBUSY is more normal, although some people return -ENODEV or
-EIO. But I would think -EBUSY is the right one.

regards,
dan carpenter