2010-07-29 15:55:38

by Kulikov Vasiliy

[permalink] [raw]
Subject: [PATCH] char: cs5535_gpio: check put_user() result

put_user() may fail, if so return -EFAULT.

Signed-off-by: Kulikov Vasiliy <[email protected]>
---
drivers/char/cs5535_gpio.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/char/cs5535_gpio.c b/drivers/char/cs5535_gpio.c
index 4d830dc..fb7b888 100644
--- a/drivers/char/cs5535_gpio.c
+++ b/drivers/char/cs5535_gpio.c
@@ -146,7 +146,8 @@ static ssize_t cs5535_gpio_read(struct file *file, char __user *buf,

/* add a line-feed if there is room */
if ((i == ARRAY_SIZE(rm)) && (count < len)) {
- put_user('\n', buf + count);
+ if (put_user('\n', buf + count))
+ return -EFAULT;
count++;
}

--
1.7.0.4