2010-08-03 03:09:35

by Axel Lin

Subject: [PATCH] tc6393xb: fix wrong goto labels for error handling

This patch corrects the error handling path.

Signed-off-by: Axel Lin <[email protected]>
---
drivers/mfd/tc6393xb.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mfd/tc6393xb.c b/drivers/mfd/tc6393xb.c
index fcf9068..ef6c42c 100644
--- a/drivers/mfd/tc6393xb.c
+++ b/drivers/mfd/tc6393xb.c
@@ -732,9 +732,9 @@ err_gpio_add:
if (tc6393xb->gpio.base != -1)
temp = gpiochip_remove(&tc6393xb->gpio);
tcpd->disable(dev);
-err_clk_enable:
- clk_disable(tc6393xb->clk);
err_enable:
+ clk_disable(tc6393xb->clk);
+err_clk_enable:
iounmap(tc6393xb->scr);
err_ioremap:
release_resource(&tc6393xb->rscr);
--
1.5.4.3

2010-08-03 10:33:00

by Samuel Ortiz

Subject: Re: [PATCH] tc6393xb: fix wrong goto labels for error handling

On Tue, Aug 03, 2010 at 11:10:41AM +0800, Axel Lin wrote:
> This patch corrects the error handling path.
Applied, thanks.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/

2010-08-03 13:46:05

by Ian Molton

Subject: Re: [PATCH] tc6393xb: fix wrong goto labels for error handling

Acked-by: Ian Molton <[email protected]>

On 3 August 2010 04:10, Axel Lin <[email protected]> wrote:
> This patch corrects the error handling path.
>
> Signed-off-by: Axel Lin <[email protected]>
> ---
> ?drivers/mfd/tc6393xb.c | ? ?4 ++--
> ?1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/tc6393xb.c b/drivers/mfd/tc6393xb.c
> index fcf9068..ef6c42c 100644
> --- a/drivers/mfd/tc6393xb.c
> +++ b/drivers/mfd/tc6393xb.c
> @@ -732,9 +732,9 @@ err_gpio_add:
> ? ? ? ?if (tc6393xb->gpio.base != -1)
> ? ? ? ? ? ? ? ?temp = gpiochip_remove(&tc6393xb->gpio);
> ? ? ? ?tcpd->disable(dev);
> -err_clk_enable:
> - ? ? ? clk_disable(tc6393xb->clk);
> ?err_enable:
> + ? ? ? clk_disable(tc6393xb->clk);
> +err_clk_enable:
> ? ? ? ?iounmap(tc6393xb->scr);
> ?err_ioremap:
> ? ? ? ?release_resource(&tc6393xb->rscr);
> --
> 1.5.4.3
>
>
>
>

2010-08-03 13:48:29

by Ian Molton

Subject: Re: [PATCH] tc6393xb: fix wrong goto labels for error handling

Whoops, didnt see your message Samuel :)

On 3 August 2010 11:33, Samuel Ortiz <[email protected]> wrote:
> On Tue, Aug 03, 2010 at 11:10:41AM +0800, Axel Lin wrote:
>> This patch corrects the error handling path.
> Applied, thanks.
>
> Cheers,
> Samuel.
>
> --
> Intel Open Source Technology Centre
> http://oss.intel.com/
>