2010-07-29 15:51:53

by Henrique Camargo

Subject: [PATCH] drivers: Fixes a typo from "dev" to "ndev" that caused compilation erros.

From: Henrique Camargo

Fixes a typo from "dev" to "ndev" that caused compilation errors.

Signed-off-by: Henrique Camargo <[email protected]>
---
drivers/net/davinci_emac.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c
index 25e14d2..b89b7bf 100644
--- a/drivers/net/davinci_emac.c
+++ b/drivers/net/davinci_emac.c
@@ -1182,8 +1182,8 @@ static int emac_net_tx_complete(struct emac_priv *priv,
struct net_device *ndev = priv->ndev;
u32 cnt;

- if (unlikely(num_tokens && netif_queue_stopped(dev)))
- netif_start_queue(dev);
+ if (unlikely(num_tokens && netif_queue_stopped(ndev)))
+ netif_start_queue(ndev);
for (cnt = 0; cnt < num_tokens; cnt++) {
struct sk_buff *skb = (struct sk_buff *)net_data_tokens[cnt];
if (skb == NULL)
--
1.7.0.4

2010-07-29 16:04:16

by Kulikov Vasiliy

Subject: Re: [PATCH] drivers: Fixes a typo from "dev" to "ndev" that caused compilation erros.

On Thu, Jul 29, 2010 at 12:51 -0300, Henrique Camargo wrote:
> From: Henrique Camargo
>
> Fixes a typo from "dev" to "ndev" that caused compilation errors.
>
> Signed-off-by: Henrique Camargo <[email protected]>

Thanks,
Reviewed-by: Kulikov Vasiliy <[email protected]>

Also I've checked my other patches of removing private stats, the rest
are ok.

> ---
> drivers/net/davinci_emac.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c
> index 25e14d2..b89b7bf 100644
> --- a/drivers/net/davinci_emac.c
> +++ b/drivers/net/davinci_emac.c
> @@ -1182,8 +1182,8 @@ static int emac_net_tx_complete(struct emac_priv *priv,
> struct net_device *ndev = priv->ndev;
> u32 cnt;
>
> - if (unlikely(num_tokens && netif_queue_stopped(dev)))
> - netif_start_queue(dev);
> + if (unlikely(num_tokens && netif_queue_stopped(ndev)))
> + netif_start_queue(ndev);
> for (cnt = 0; cnt < num_tokens; cnt++) {
> struct sk_buff *skb = (struct sk_buff *)net_data_tokens[cnt];
> if (skb == NULL)
> --
> 1.7.0.4

2010-07-31 05:20:18

by David Miller

Subject: Re: [PATCH] drivers: Fixes a typo from "dev" to "ndev" that caused compilation erros.

From: Henrique Camargo <[email protected]>
Date: Thu, 29 Jul 2010 12:51:49 -0300

> From: Henrique Camargo

>From lines need valid email addresses. But in this case since you
are the person who wrote the patch, adding another From: tag in
the message body is superfluous and you can just omit it.

> diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c
> index 25e14d2..b89b7bf 100644
> --- a/drivers/net/davinci_emac.c
> +++ b/drivers/net/davinci_emac.c
> @@ -1182,8 +1182,8 @@ static int emac_net_tx_complete(struct emac_priv *priv,
> struct net_device *ndev = priv->ndev;
> u32 cnt;
>
> - if (unlikely(num_tokens && netif_queue_stopped(dev)))
> - netif_start_queue(dev);
> + if (unlikely(num_tokens && netif_queue_stopped(ndev)))
> + netif_start_queue(ndev);

Your patch is corrupted, tab characters have been turned into spaces by
your email client.

This makes your patch unusable.

Please fix up these errors and resubmit your patch.

Thank you.

2010-08-03 03:10:54

by Henrique Camargo

Subject: [PATCH] Fixes a typo from "dev" to "ndev"

The typo was causing compilation errors since "dev" was not defined.

Signed-off-by: Henrique Camargo <[email protected]>
---
drivers/net/davinci_emac.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c
index 25e14d2..b89b7bf 100644
--- a/drivers/net/davinci_emac.c
+++ b/drivers/net/davinci_emac.c
@@ -1182,8 +1182,8 @@ static int emac_net_tx_complete(struct emac_priv *priv,
struct net_device *ndev = priv->ndev;
u32 cnt;

- if (unlikely(num_tokens && netif_queue_stopped(dev)))
- netif_start_queue(dev);
+ if (unlikely(num_tokens && netif_queue_stopped(ndev)))
+ netif_start_queue(ndev);
for (cnt = 0; cnt < num_tokens; cnt++) {
struct sk_buff *skb = (struct sk_buff *)net_data_tokens[cnt];
if (skb == NULL)
--
1.7.0.4

2010-08-03 05:02:59

by David Miller

Subject: Re: [PATCH] Fixes a typo from "dev" to "ndev"

From: Henrique Camargo <[email protected]>
Date: Tue, 03 Aug 2010 00:10:42 -0300

> The typo was causing compilation errors since "dev" was not defined.
>
> Signed-off-by: Henrique Camargo <[email protected]>

Applied, thank you.