2010-08-09 07:49:55

by Axel Lin

Subject: [PATCH RESEND] regulator: tps6507x - add missing platform_set_drvdata in tps6507x_pmic_probe

We should call platform_set_drvdata() before calling platform_get_drvdata().

Signed-off-by: Axel Lin <[email protected]>
---
Per Mark's comment, this resend remove platform_set_drvdata(pdev, NULL)
in tps6507x_pmic_remove.
drivers/regulator/tps6507x-regulator.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/regulator/tps6507x-regulator.c b/drivers/regulator/tps6507x-regulator.c
index 8152d65..c239f42 100644
--- a/drivers/regulator/tps6507x-regulator.c
+++ b/drivers/regulator/tps6507x-regulator.c
@@ -614,6 +614,7 @@ int tps6507x_pmic_probe(struct platform_device *pdev)
}

tps6507x_dev->pmic = tps;
+ platform_set_drvdata(pdev, tps6507x_dev);

return 0;

--
1.5.4.3

2010-08-10 14:46:16

by Mark Brown

Subject: Re: [PATCH RESEND] regulator: tps6507x - add missing platform_set_drvdata in tps6507x_pmic_probe

On Mon, Aug 09, 2010 at 03:51:23PM +0800, Axel Lin wrote:
> We should call platform_set_drvdata() before calling platform_get_drvdata().
>
> Signed-off-by: Axel Lin <[email protected]>

Acked-by: Mark Brown <[email protected]>

2010-08-10 17:18:40

by Liam Girdwood

Subject: Re: [PATCH RESEND] regulator: tps6507x - add missing platform_set_drvdata in tps6507x_pmic_probe

On Tue, 2010-08-10 at 15:46 +0100, Mark Brown wrote:
> On Mon, Aug 09, 2010 at 03:51:23PM +0800, Axel Lin wrote:
> > We should call platform_set_drvdata() before calling platform_get_drvdata().
> >
> > Signed-off-by: Axel Lin <[email protected]>
>
> Acked-by: Mark Brown <[email protected]>
> --

Applied.

Thanks

Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk