2010-08-09 19:51:55

by Kulikov Vasiliy

Subject: [PATCH 12/18 v2] staging: crystalhd: call disable_pci_device() if pci_probe() failed

Driver should call disable_pci_device() if it returns from pci_probe()
with error.

Signed-off-by: Kulikov Vasiliy <[email protected]>
---
drivers/staging/crystalhd/crystalhd_lnx.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/crystalhd/crystalhd_lnx.c b/drivers/staging/crystalhd/crystalhd_lnx.c
index fbb80f0..115e79b 100644
--- a/drivers/staging/crystalhd/crystalhd_lnx.c
+++ b/drivers/staging/crystalhd/crystalhd_lnx.c
@@ -570,6 +570,7 @@ static int __devinit chd_dec_pci_probe(struct pci_dev *pdev,
rc = chd_pci_reserve_mem(pinfo);
if (rc) {
BCMLOG_ERR("Failed to setup memory regions.\n");
+ pci_disable_device(pdev);
return -ENOMEM;
}

--
1.7.0.4

2010-08-23 18:03:42

by Jarod Wilson

Subject: Re: [PATCH 12/18 v2] staging: crystalhd: call disable_pci_device() if pci_probe() failed

On Mon, Aug 09, 2010 at 11:51:44PM +0400, Kulikov Vasiliy wrote:
> Driver should call disable_pci_device() if it returns from pci_probe()
> with error.
>
> Signed-off-by: Kulikov Vasiliy <[email protected]>

Looks fine by me.

Acked-by: Jarod Wilson <[email protected]>

--
Jarod Wilson
[email protected]