2010-08-07 16:47:29

by Namhyung Kim

Subject: [PATCH] padata: add missing __percpu markup in include/linux/padata.h

parallel_data->queue is a percpu pointer but was missing __percpu markup.
Add it.

Signed-off-by: Namhyung Kim <[email protected]>
---
include/linux/padata.h | 18 +++++++++---------
1 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/include/linux/padata.h b/include/linux/padata.h
index 8d84062..67df560 100644
--- a/include/linux/padata.h
+++ b/include/linux/padata.h
@@ -96,15 +96,15 @@ struct padata_queue {
* @timer: Reorder timer.
*/
struct parallel_data {
- struct padata_instance *pinst;
- struct padata_queue *queue;
- atomic_t seq_nr;
- atomic_t reorder_objects;
- atomic_t refcnt;
- unsigned int max_seq_nr;
- cpumask_var_t cpumask;
- spinlock_t lock;
- struct timer_list timer;
+ struct padata_instance *pinst;
+ struct padata_queue __percpu *queue;
+ atomic_t seq_nr;
+ atomic_t reorder_objects;
+ atomic_t refcnt;
+ unsigned int max_seq_nr;
+ cpumask_var_t cpumask;
+ spinlock_t lock;
+ struct timer_list timer;
};

/**
--
1.7.0.4

2010-08-07 19:37:11

by Tejun Heo

Subject: Re: [PATCH] padata: add missing __percpu markup in include/linux/padata.h

On 08/07/2010 06:47 PM, Namhyung Kim wrote:
> parallel_data->queue is a percpu pointer but was missing __percpu markup.
> Add it.
>
> Signed-off-by: Namhyung Kim <[email protected]>

Acked-by: Tejun Heo <[email protected]>

--
tejun

2010-08-11 18:24:42

by Steffen Klassert

Subject: Re: [PATCH] padata: add missing __percpu markup in include/linux/padata.h

On Sun, Aug 08, 2010 at 01:47:25AM +0900, Namhyung Kim wrote:
> parallel_data->queue is a percpu pointer but was missing __percpu markup.
> Add it.
>

The patch does not apply, please respin against linux-2.6 git current.

Thanks,

Steffen

2010-08-12 10:54:33

by Namhyung Kim

Subject: [PATCH resend] padata: add missing __percpu markup in include/linux/padata.h

parallel_data->queue is a percpu pointer but was missing __percpu markup.
Add it.

Signed-off-by: Namhyung Kim <[email protected]>
---
include/linux/padata.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/padata.h b/include/linux/padata.h
index bdcd1e9..4633b2f 100644
--- a/include/linux/padata.h
+++ b/include/linux/padata.h
@@ -127,8 +127,8 @@ struct padata_cpumask {
*/
struct parallel_data {
struct padata_instance *pinst;
- struct padata_parallel_queue *pqueue;
- struct padata_serial_queue *squeue;
+ struct padata_parallel_queue __percpu *pqueue;
+ struct padata_serial_queue __percpu *squeue;
atomic_t seq_nr;
atomic_t reorder_objects;
atomic_t refcnt;
--
1.7.0.4

2010-08-16 07:08:08

by Steffen Klassert

Subject: Re: [PATCH resend] padata: add missing __percpu markup in include/linux/padata.h

On Thu, Aug 12, 2010 at 07:54:27PM +0900, Namhyung Kim wrote:
> parallel_data->queue is a percpu pointer but was missing __percpu markup.
> Add it.
>
> Signed-off-by: Namhyung Kim <[email protected]>

Acked-by: Steffen Klassert <[email protected]>

Thanks,

Steffen