2010-08-12 16:36:06

by Ursula Braun

[permalink] [raw]
Subject: Re: Fw: [PATCH net-next] drivers/s390/net/qeth_l3_main.c: Use %pI6

ACK
Thanks Joe - we make sure your patch is submitted to Dave Miller within
our next submission of qeth patches.

Ursula

> From: Joe Perches <[email protected]>
> To: Frank Blaschka <[email protected]>
> Subject: [PATCH net-next] drivers/s390/net/qeth_l3_main.c: Use %pI6

> Format an ipv6 address using vsprintf extensions.
>
> Signed-off-by: Joe Perches <[email protected]>
> ---
> drivers/s390/net/qeth_l3_main.c | 7 +------
> 1 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/s390/net/qeth_l3_main.c
> b/drivers/s390/net/qeth_l3_main.c
> index e22ae24..561bdc8 100644
> --- a/drivers/s390/net/qeth_l3_main.c
> +++ b/drivers/s390/net/qeth_l3_main.c
> @@ -103,12 +103,7 @@ int qeth_l3_string_to_ipaddr4(const char *buf,
> __u8 *addr)
>
> void qeth_l3_ipaddr6_to_string(const __u8 *addr, char *buf)
> {
> - sprintf(buf, "%02x%02x:%02x%02x:%02x%02x:%02x%02x"
> - ":%02x%02x:%02x%02x:%02x%02x:%
> 02x%02x",
> - addr[0], addr[1], addr[2],
> addr[3],
> - addr[4], addr[5], addr[6],
> addr[7],
> - addr[8], addr[9], addr[10],
> addr[11],
> - addr[12], addr[13], addr[14],
> addr[15]);
> + sprintf(buf, "%pI6", addr);
> }
>
> int qeth_l3_string_to_ipaddr6(const char *buf, __u8 *addr)
>
>