2010-08-14 14:31:57

by Axel Lin

Subject: [PATCH] regulator: tps6507x - remove incorrect comments

This driver is a platform driver, not a i2c driver.
Thus remove incorrect tps6507x_remove comments.

Signed-off-by: Axel Lin <[email protected]>
---
drivers/regulator/tps6507x-regulator.c | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/drivers/regulator/tps6507x-regulator.c b/drivers/regulator/tps6507x-regulator.c
index c239f42..020f587 100644
--- a/drivers/regulator/tps6507x-regulator.c
+++ b/drivers/regulator/tps6507x-regulator.c
@@ -626,12 +626,6 @@ fail:
return error;
}

-/**
- * tps6507x_remove - TPS6507x driver i2c remove handler
- * @client: i2c driver client device structure
- *
- * Unregister TPS driver as an i2c client device driver
- */
static int __devexit tps6507x_pmic_remove(struct platform_device *pdev)
{
struct tps6507x_dev *tps6507x_dev = platform_get_drvdata(pdev);
--
1.7.0.4

2010-08-15 15:42:50

by Mark Brown

Subject: Re: [PATCH] regulator: tps6507x - remove incorrect comments

On Sat, Aug 14, 2010 at 10:32:13PM +0800, Axel Lin wrote:
> This driver is a platform driver, not a i2c driver.
> Thus remove incorrect tps6507x_remove comments.
>
> Signed-off-by: Axel Lin <[email protected]>

Acked-by: Mark Brown <[email protected]>

2010-08-18 13:29:52

by Liam Girdwood

Subject: Re: [PATCH] regulator: tps6507x - remove incorrect comments

On Sat, 2010-08-14 at 22:32 +0800, Axel Lin wrote:
> This driver is a platform driver, not a i2c driver.
> Thus remove incorrect tps6507x_remove comments.
>
> Signed-off-by: Axel Lin <[email protected]>
> ---
> drivers/regulator/tps6507x-regulator.c | 6 ------
> 1 files changed, 0 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/regulator/tps6507x-regulator.c b/drivers/regulator/tps6507x-regulator.c
> index c239f42..020f587 100644
> --- a/drivers/regulator/tps6507x-regulator.c
> +++ b/drivers/regulator/tps6507x-regulator.c
> @@ -626,12 +626,6 @@ fail:
> return error;
> }
>
> -/**
> - * tps6507x_remove - TPS6507x driver i2c remove handler
> - * @client: i2c driver client device structure
> - *
> - * Unregister TPS driver as an i2c client device driver
> - */
> static int __devexit tps6507x_pmic_remove(struct platform_device *pdev)
> {
> struct tps6507x_dev *tps6507x_dev = platform_get_drvdata(pdev);

Applied.

Thanks

Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk