2010-08-18 05:15:31

by Namhyung Kim

Subject: [PATCH] x86: change a temporary variable name in ia32_signal.c

This removes following sparse warnings:

ia32_signal.c:240:17: warning: symbol 'tmp' shadows an earlier one
ia32_signal.c:228:13: originally declared here
ia32_signal.c:241:17: warning: symbol 'tmp' shadows an earlier one
ia32_signal.c:228:13: originally declared here
ia32_signal.c:242:17: warning: symbol 'tmp' shadows an earlier one
ia32_signal.c:228:13: originally declared here
ia32_signal.c:243:17: warning: symbol 'tmp' shadows an earlier one
ia32_signal.c:228:13: originally declared here
ia32_signal.c:249:17: warning: symbol 'tmp' shadows an earlier one
ia32_signal.c:228:13: originally declared here
ia32_signal.c:250:17: warning: symbol 'tmp' shadows an earlier one
ia32_signal.c:228:13: originally declared here

Signed-off-by: Namhyung Kim <[email protected]>
---
arch/x86/ia32/ia32_signal.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/x86/ia32/ia32_signal.c b/arch/x86/ia32/ia32_signal.c
index 348928a..6db169d 100644
--- a/arch/x86/ia32/ia32_signal.c
+++ b/arch/x86/ia32/ia32_signal.c
@@ -202,9 +202,9 @@ asmlinkage long sys32_sigaltstack(const stack_ia32_t __user *uss_ptr,
}

#define GET_SEG(seg) ({ \
- unsigned short tmp; \
- get_user_ex(tmp, &sc->seg); \
- tmp; \
+ unsigned short __tmp; \
+ get_user_ex(__tmp, &sc->seg); \
+ __tmp; \
})

#define COPY_SEG_CPL3(seg) do { \
--
1.7.0.4

2010-08-18 05:40:29

by Cong Wang

Subject: Re: [PATCH] x86: change a temporary variable name in ia32_signal.c

On Wed, Aug 18, 2010 at 02:15:20PM +0900, Namhyung Kim wrote:
>This removes following sparse warnings:
>
> ia32_signal.c:240:17: warning: symbol 'tmp' shadows an earlier one
> ia32_signal.c:228:13: originally declared here
> ia32_signal.c:241:17: warning: symbol 'tmp' shadows an earlier one
> ia32_signal.c:228:13: originally declared here
> ia32_signal.c:242:17: warning: symbol 'tmp' shadows an earlier one
> ia32_signal.c:228:13: originally declared here
> ia32_signal.c:243:17: warning: symbol 'tmp' shadows an earlier one
> ia32_signal.c:228:13: originally declared here
> ia32_signal.c:249:17: warning: symbol 'tmp' shadows an earlier one
> ia32_signal.c:228:13: originally declared here
> ia32_signal.c:250:17: warning: symbol 'tmp' shadows an earlier one
> ia32_signal.c:228:13: originally declared here
>
>Signed-off-by: Namhyung Kim <[email protected]>


Reviewed-by: WANG Cong <[email protected]>

Thanks.

>---
> arch/x86/ia32/ia32_signal.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/arch/x86/ia32/ia32_signal.c b/arch/x86/ia32/ia32_signal.c
>index 348928a..6db169d 100644
>--- a/arch/x86/ia32/ia32_signal.c
>+++ b/arch/x86/ia32/ia32_signal.c
>@@ -202,9 +202,9 @@ asmlinkage long sys32_sigaltstack(const stack_ia32_t __user *uss_ptr,
> }
>
> #define GET_SEG(seg) ({ \
>- unsigned short tmp; \
>- get_user_ex(tmp, &sc->seg); \
>- tmp; \
>+ unsigned short __tmp; \
>+ get_user_ex(__tmp, &sc->seg); \
>+ __tmp; \
> })
>
> #define COPY_SEG_CPL3(seg) do { \
>--
>1.7.0.4
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to [email protected]
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at http://www.tux.org/lkml/