2010-08-27 02:31:08

by Axel Lin

Subject: [PATCH] ASoC: soc-core: fix debugfs_pop_time file permissions

I think this is a typo, debugfs_pop_time should not be executable.

Signed-off-by: Axel Lin <[email protected]>
---
sound/soc/soc-core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 65352c7..42542e0 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -249,7 +249,7 @@ static void soc_init_codec_debugfs(struct snd_soc_codec *codec)
printk(KERN_WARNING
"ASoC: Failed to create codec register debugfs file\n");

- codec->debugfs_pop_time = debugfs_create_u32("dapm_pop_time", 0744,
+ codec->debugfs_pop_time = debugfs_create_u32("dapm_pop_time", 0644,
codec->debugfs_codec_root,
&codec->pop_time);
if (!codec->debugfs_pop_time)
--
1.7.2

2010-08-27 12:25:08

by Liam Girdwood

Subject: Re: [PATCH] ASoC: soc-core: fix debugfs_pop_time file permissions

On Fri, 2010-08-27 at 10:34 +0800, Axel Lin wrote:
> I think this is a typo, debugfs_pop_time should not be executable.
>
> Signed-off-by: Axel Lin <[email protected]>
> ---
> sound/soc/soc-core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
> index 65352c7..42542e0 100644
> --- a/sound/soc/soc-core.c
> +++ b/sound/soc/soc-core.c
> @@ -249,7 +249,7 @@ static void soc_init_codec_debugfs(struct snd_soc_codec *codec)
> printk(KERN_WARNING
> "ASoC: Failed to create codec register debugfs file\n");
>
> - codec->debugfs_pop_time = debugfs_create_u32("dapm_pop_time", 0744,
> + codec->debugfs_pop_time = debugfs_create_u32("dapm_pop_time", 0644,
> codec->debugfs_codec_root,
> &codec->pop_time);
> if (!codec->debugfs_pop_time)

Acked-by: Liam Girdwood <[email protected]>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

2010-08-27 19:01:18

by Mark Brown

Subject: Re: [PATCH] ASoC: soc-core: fix debugfs_pop_time file permissions

On Fri, Aug 27, 2010 at 01:25:00PM +0100, Liam Girdwood wrote:
> On Fri, 2010-08-27 at 10:34 +0800, Axel Lin wrote:
> > I think this is a typo, debugfs_pop_time should not be executable.
> >
> > Signed-off-by: Axel Lin <[email protected]>

> Acked-by: Liam Girdwood <[email protected]>

Applied, thanks.