2010-11-04 19:43:59

by Allyn, Mark A

Subject: [PATCH 1/1] crypto: api.c: add comments to crypto_alg_lookup and crypto_alg_larval_lookup

This is resubmitted due to errors in style

Signed-off-by: Mark A. Allyn <[email protected]>
---
crypto/api.c | 15 +++++++++++++++
1 files changed, 15 insertions(+), 0 deletions(-)

diff --git a/crypto/api.c b/crypto/api.c
index 033a714..0314083 100644
--- a/crypto/api.c
+++ b/crypto/api.c
@@ -193,6 +193,13 @@ static struct crypto_alg *crypto_larval_wait(struct crypto_alg *alg)
return alg;
}

+/**
+ * crypto_alg_lookup() - return crypto_alg structure for an algorithm
+ * @name: text string containing name of algorithm
+ * @type: crypto type defined in include/linux/crypto.h
+ * @mask: mask of allowable crypto types (use or'd list
+ * of types as defined in include/linux/crypto.h)
+ */
struct crypto_alg *crypto_alg_lookup(const char *name, u32 type, u32 mask)
{
struct crypto_alg *alg;
@@ -205,6 +212,14 @@ struct crypto_alg *crypto_alg_lookup(const char *name, u32 type, u32 mask)
}
EXPORT_SYMBOL_GPL(crypto_alg_lookup);

+/**
+ * crypto_alg_larval_lookup() - returns large value (larval) crypto_alg
+ * structure for an algorithm
+ * @name: text string containing name of algorithm
+ * @type: crypto type defined in include/linux/crypto.h
+ * @mask: mask of allowable crypto types (use or'd list
+ * of types as defined in include/linux/crypto.h)
+ */
struct crypto_alg *crypto_larval_lookup(const char *name, u32 type, u32 mask)
{
struct crypto_alg *alg;
--
1.6.3.3

2010-11-04 19:51:33

by Randy Dunlap

Subject: Re: [PATCH 1/1] crypto: api.c: add comments to crypto_alg_lookup and crypto_alg_larval_lookup

On Thu, 4 Nov 2010 12:49:48 -0700 Mark Allyn wrote:

> This is resubmitted due to errors in style
>
> Signed-off-by: Mark A. Allyn <[email protected]>
> ---
> crypto/api.c | 15 +++++++++++++++
> 1 files changed, 15 insertions(+), 0 deletions(-)
>
> diff --git a/crypto/api.c b/crypto/api.c
> index 033a714..0314083 100644
> --- a/crypto/api.c
> +++ b/crypto/api.c
> @@ -193,6 +193,13 @@ static struct crypto_alg *crypto_larval_wait(struct crypto_alg *alg)
> return alg;
> }
>
> +/**
> + * crypto_alg_lookup() - return crypto_alg structure for an algorithm
> + * @name: text string containing name of algorithm
> + * @type: crypto type defined in include/linux/crypto.h
> + * @mask: mask of allowable crypto types (use or'd list
> + * of types as defined in include/linux/crypto.h)
> + */
> struct crypto_alg *crypto_alg_lookup(const char *name, u32 type, u32 mask)
> {
> struct crypto_alg *alg;
> @@ -205,6 +212,14 @@ struct crypto_alg *crypto_alg_lookup(const char *name, u32 type, u32 mask)
> }
> EXPORT_SYMBOL_GPL(crypto_alg_lookup);
>
> +/**
> + * crypto_alg_larval_lookup() - returns large value (larval) crypto_alg
> + * structure for an algorithm

That function name still does not match the actual name below.


> + * @name: text string containing name of algorithm
> + * @type: crypto type defined in include/linux/crypto.h
> + * @mask: mask of allowable crypto types (use or'd list
> + * of types as defined in include/linux/crypto.h)
> + */
> struct crypto_alg *crypto_larval_lookup(const char *name, u32 type, u32 mask)
> {
> struct crypto_alg *alg;
> --


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***