2010-11-10 19:00:21

by Peter Zijlstra

[permalink] [raw]
Subject: Re: [RFC][PATCH 03/22] sched: SCHED_DEADLINE data structures.

On Fri, 2010-10-29 at 08:28 +0200, Raistlin wrote:
> + /*
> + * Bandwidth enforcement timer. Each -deadline task has its
> + * own bandwidth to be enforced, thus we need one timer per task.
> + */
> + struct hrtimer dl_timer;

This is for the bandwidth replenishment right? Not the runtime throttle?

The throttle thing should only need a single timer per rq as only the
current task will be consuming runtime.


2010-11-10 23:07:04

by Dario Faggioli

[permalink] [raw]
Subject: Re: [RFC][PATCH 03/22] sched: SCHED_DEADLINE data structures.

On Wed, 2010-11-10 at 19:59 +0100, Peter Zijlstra wrote:
> On Fri, 2010-10-29 at 08:28 +0200, Raistlin wrote:
> > + /*
> > + * Bandwidth enforcement timer. Each -deadline task has its
> > + * own bandwidth to be enforced, thus we need one timer per task.
> > + */
> > + struct hrtimer dl_timer;
>
> This is for the bandwidth replenishment right?
Yep.

> Not the runtime throttle?
>
Not, that is done on tick basis, or by means of hrtick, if enabled.

> The throttle thing should only need a single timer per rq as only the
> current task will be consuming runtime.
>
Sure, and that's what the hrtick does (again, if enabled).

Thanks,
Dario

--
<<This happens because I choose it to happen!>> (Raistlin Majere)
----------------------------------------------------------------------
Dario Faggioli, ReTiS Lab, Scuola Superiore Sant'Anna, Pisa (Italy)

http://blog.linux.it/raistlin / [email protected] /
[email protected]


Attachments:
signature.asc (198.00 B)
This is a digitally signed message part