2010-11-11 14:25:16

by Peter Zijlstra

[permalink] [raw]
Subject: Re: [RFC][PATCH 05/22] sched: SCHED_DEADLINE policy implementation

On Fri, 2010-10-29 at 08:30 +0200, Raistlin wrote:
> +static void check_preempt_curr_dl(struct rq *rq, struct task_struct *p,
> + int flags)
> +{
> + if (!dl_task(rq->curr) || (dl_task(p) &&
> + dl_time_before(p->dl.deadline, rq->curr->dl.deadline)))
> + resched_task(rq->curr);
> +}

every moment now a patch will hit -tip that ensures
->check_preempt_curr() is only called when both the current and waking
task belong to the same sched_class.


2010-11-11 14:33:21

by Dario Faggioli

[permalink] [raw]
Subject: Re: [RFC][PATCH 05/22] sched: SCHED_DEADLINE policy implementation

On Thu, 2010-11-11 at 15:25 +0100, Peter Zijlstra wrote:
> On Fri, 2010-10-29 at 08:30 +0200, Raistlin wrote:
> > +static void check_preempt_curr_dl(struct rq *rq, struct task_struct *p,
> > + int flags)
> > +{
> > + if (!dl_task(rq->curr) || (dl_task(p) &&
> > + dl_time_before(p->dl.deadline, rq->curr->dl.deadline)))
> > + resched_task(rq->curr);
> > +}
>
> every moment now a patch will hit -tip that ensures
> ->check_preempt_curr() is only called when both the current and waking
> task belong to the same sched_class.
>
Again, I saw your fix to this, which is later than this patchset... :-)

I'll take care of this while rebasing right in these days.

Thanks,
Dario

--
<<This happens because I choose it to happen!>> (Raistlin Majere)
----------------------------------------------------------------------
Dario Faggioli, ReTiS Lab, Scuola Superiore Sant'Anna, Pisa (Italy)

http://blog.linux.it/raistlin / [email protected] /
[email protected]


Attachments:
signature.asc (198.00 B)
This is a digitally signed message part