2010-11-13 23:28:47

by Tracey Dent

Subject: [PATCH] kernel/power/: Changed Makefile to use proper ccflag flag

Use the ccflags-$ flag instead of EXTRA_CFLAGS because EXTRA_CFLAGS is
deprecated and should now be switched. According to (documentation/kbuild/makefiles.txt).

Signed-off-by: Tracey Dent <[email protected]>
---
kernel/power/Makefile | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/kernel/power/Makefile b/kernel/power/Makefile
index f9063c6..b755972 100644
--- a/kernel/power/Makefile
+++ b/kernel/power/Makefile
@@ -1,7 +1,4 @@
-
-ifeq ($(CONFIG_PM_DEBUG),y)
-EXTRA_CFLAGS += -DDEBUG
-endif
+ccflags-$(CONFIG_PM_DEBUG) := -DDEBUG

obj-$(CONFIG_PM) += main.o
obj-$(CONFIG_PM_SLEEP) += console.o
--
1.7.3.2.164.g6f10c

2010-11-14 05:32:28

by Pavel Machek

Subject: Re: [PATCH] kernel/power/: Changed Makefile to use proper ccflag flag

On Sat 2010-11-13 18:28:34, Tracey Dent wrote:
> Use the ccflags-$ flag instead of EXTRA_CFLAGS because EXTRA_CFLAGS is
> deprecated and should now be switched. According to (documentation/kbuild/makefiles.txt).
>
> Signed-off-by: Tracey Dent <[email protected]>

ACK.

> ---
> kernel/power/Makefile | 5 +----
> 1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/power/Makefile b/kernel/power/Makefile
> index f9063c6..b755972 100644
> --- a/kernel/power/Makefile
> +++ b/kernel/power/Makefile
> @@ -1,7 +1,4 @@
> -
> -ifeq ($(CONFIG_PM_DEBUG),y)
> -EXTRA_CFLAGS += -DDEBUG
> -endif
> +ccflags-$(CONFIG_PM_DEBUG) := -DDEBUG
>
> obj-$(CONFIG_PM) += main.o
> obj-$(CONFIG_PM_SLEEP) += console.o

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

2010-11-26 22:05:37

by Rafael J. Wysocki

Subject: Re: [PATCH] kernel/power/: Changed Makefile to use proper ccflag flag

On Sunday, November 14, 2010, Tracey Dent wrote:
> Use the ccflags-$ flag instead of EXTRA_CFLAGS because EXTRA_CFLAGS is
> deprecated and should now be switched. According to (documentation/kbuild/makefiles.txt).

Applied to suspend-2.6/linux-next.

Thanks,
Rafael


> Signed-off-by: Tracey Dent <[email protected]>
> ---
> kernel/power/Makefile | 5 +----
> 1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/power/Makefile b/kernel/power/Makefile
> index f9063c6..b755972 100644
> --- a/kernel/power/Makefile
> +++ b/kernel/power/Makefile
> @@ -1,7 +1,4 @@
> -
> -ifeq ($(CONFIG_PM_DEBUG),y)
> -EXTRA_CFLAGS += -DDEBUG
> -endif
> +ccflags-$(CONFIG_PM_DEBUG) := -DDEBUG
>
> obj-$(CONFIG_PM) += main.o
> obj-$(CONFIG_PM_SLEEP) += console.o
>