2010-11-15 09:22:23

by Alessio Igor Bogani

[permalink] [raw]
Subject: [PATCH] powerpc: Update a comment

The commit 5e3d20a remove bkl from startup code so setup_arch() it isn't called
with bkl held anymore. Update the comment on top of that function.

This work was supported by a hardware donation from the CE Linux Forum.

Signed-off-by: Alessio Igor Bogani <[email protected]>
---
arch/powerpc/kernel/setup_64.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c
index 2a178b0..71f44e5 100644
--- a/arch/powerpc/kernel/setup_64.c
+++ b/arch/powerpc/kernel/setup_64.c
@@ -497,9 +497,8 @@ static void __init emergency_stack_init(void)
}

/*
- * Called into from start_kernel, after lock_kernel has been called.
- * Initializes bootmem, which is unsed to manage page allocation until
- * mem_init is called.
+ * Called into from start_kernel this initializes bootmem, which is unsed
+ * to manage page allocation until mem_init is called.
*/
void __init setup_arch(char **cmdline_p)
{
--
1.7.0.4


2010-11-16 11:33:27

by Josh Boyer

[permalink] [raw]
Subject: Re: [PATCH] powerpc: Update a comment

On Mon, Nov 15, 2010 at 3:21 AM, Alessio Igor Bogani <[email protected]> wrote:
> The commit 5e3d20a remove bkl from startup code so setup_arch() it isn't called
> with bkl held anymore. Update the comment on top of that function.
>
> This work was supported by a hardware donation from the CE Linux Forum.

You should make sure to send powerpc patches to linuxppc-dev.

>
> Signed-off-by: Alessio Igor Bogani <[email protected]>
> ---
> ?arch/powerpc/kernel/setup_64.c | ? ?5 ++---
> ?1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c
> index 2a178b0..71f44e5 100644
> --- a/arch/powerpc/kernel/setup_64.c
> +++ b/arch/powerpc/kernel/setup_64.c
> @@ -497,9 +497,8 @@ static void __init emergency_stack_init(void)
> ?}
>
> ?/*
> - * Called into from start_kernel, after lock_kernel has been called.
> - * Initializes bootmem, which is unsed to manage page allocation until
> - * mem_init is called.
> + * Called into from start_kernel this initializes bootmem, which is unsed
> + * to manage page allocation until mem_init is called.

You might as well fix the typo while you're there. unsed->used

josh