2010-11-16 20:46:32

by Linus Torvalds

[permalink] [raw]
Subject: nouveau build failure (was Re: Linux 2.6.37-rc2)

Looks like commit 34e9d85a1aae ("drm/nouveau: Add temperature support
(vbios parsing, readings, hwmon)") didn't make things properly
dependent on CONFIG_HWMON (or do the appropriate "select HWMON" or
whatever).

Added some collection of hopefully more relevant people to the discussion..

Linus

On Tue, Nov 16, 2010 at 12:35 PM, Zimny Lech
<[email protected]> wrote:
>
> ?LD ? ? ?vmlinux.o
> ?MODPOST vmlinux.o
> WARNING: modpost: Found 7 section mismatch(es).
> To see full details build your kernel with:
> 'make CONFIG_DEBUG_SECTION_MISMATCH=y'
> ?GEN ? ? .version
> ?CHK ? ? include/generated/compile.h
> ?UPD ? ? include/generated/compile.h
> ?CC ? ? ?init/version.o
> ?LD ? ? ?init/built-in.o
> ?LD ? ? ?.tmp_vmlinux1
> drivers/built-in.o: In function `nouveau_pm_fini':
> (.text+0xe1857): undefined reference to `hwmon_device_unregister'
> drivers/built-in.o: In function `nouveau_pm_init':
> (.text+0xe1b4d): undefined reference to `hwmon_device_register'
> drivers/built-in.o: In function `nouveau_pm_init':
> (.text+0xe1bef): undefined reference to `hwmon_device_unregister'
> make[1]: *** [.tmp_vmlinux1] Error 1
> make: *** [sub-make] Error 2


2010-11-16 20:51:52

by Randy Dunlap

[permalink] [raw]
Subject: Re: nouveau build failure (was Re: Linux 2.6.37-rc2)

On Tue, 16 Nov 2010 12:45:43 -0800 Linus Torvalds wrote:

> Looks like commit 34e9d85a1aae ("drm/nouveau: Add temperature support
> (vbios parsing, readings, hwmon)") didn't make things properly
> dependent on CONFIG_HWMON (or do the appropriate "select HWMON" or
> whatever).
>
> Added some collection of hopefully more relevant people to the discussion..
>
> Linus


This build error was reported for linux-next on 2010.1011 and 2010.1025,
with no replies.

Some process fix would be nice to see.


> On Tue, Nov 16, 2010 at 12:35 PM, Zimny Lech
> <[email protected]> wrote:
> >
> > ?LD ? ? ?vmlinux.o
> > ?MODPOST vmlinux.o
> > WARNING: modpost: Found 7 section mismatch(es).
> > To see full details build your kernel with:
> > 'make CONFIG_DEBUG_SECTION_MISMATCH=y'
> > ?GEN ? ? .version
> > ?CHK ? ? include/generated/compile.h
> > ?UPD ? ? include/generated/compile.h
> > ?CC ? ? ?init/version.o
> > ?LD ? ? ?init/built-in.o
> > ?LD ? ? ?.tmp_vmlinux1
> > drivers/built-in.o: In function `nouveau_pm_fini':
> > (.text+0xe1857): undefined reference to `hwmon_device_unregister'
> > drivers/built-in.o: In function `nouveau_pm_init':
> > (.text+0xe1b4d): undefined reference to `hwmon_device_register'
> > drivers/built-in.o: In function `nouveau_pm_init':
> > (.text+0xe1bef): undefined reference to `hwmon_device_unregister'
> > make[1]: *** [.tmp_vmlinux1] Error 1
> > make: *** [sub-make] Error 2
> --


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

2010-11-16 20:59:44

by Ben Skeggs

[permalink] [raw]
Subject: Re: nouveau build failure (was Re: Linux 2.6.37-rc2)

On Tue, 2010-11-16 at 12:50 -0800, Randy Dunlap wrote:
> On Tue, 16 Nov 2010 12:45:43 -0800 Linus Torvalds wrote:
>
> > Looks like commit 34e9d85a1aae ("drm/nouveau: Add temperature support
> > (vbios parsing, readings, hwmon)") didn't make things properly
> > dependent on CONFIG_HWMON (or do the appropriate "select HWMON" or
> > whatever).
> >
> > Added some collection of hopefully more relevant people to the discussion..
> >
> > Linus
>
>
> This build error was reported for linux-next on 2010.1011 and 2010.1025,
> with no replies.
>
> Some process fix would be nice to see.
It's actually been fixed in the nouveau tree, I have to go through and
get fixes out of it and send them to Dave.

Ben.
>
>
> > On Tue, Nov 16, 2010 at 12:35 PM, Zimny Lech
> > <[email protected]> wrote:
> > >
> > > LD vmlinux.o
> > > MODPOST vmlinux.o
> > > WARNING: modpost: Found 7 section mismatch(es).
> > > To see full details build your kernel with:
> > > 'make CONFIG_DEBUG_SECTION_MISMATCH=y'
> > > GEN .version
> > > CHK include/generated/compile.h
> > > UPD include/generated/compile.h
> > > CC init/version.o
> > > LD init/built-in.o
> > > LD .tmp_vmlinux1
> > > drivers/built-in.o: In function `nouveau_pm_fini':
> > > (.text+0xe1857): undefined reference to `hwmon_device_unregister'
> > > drivers/built-in.o: In function `nouveau_pm_init':
> > > (.text+0xe1b4d): undefined reference to `hwmon_device_register'
> > > drivers/built-in.o: In function `nouveau_pm_init':
> > > (.text+0xe1bef): undefined reference to `hwmon_device_unregister'
> > > make[1]: *** [.tmp_vmlinux1] Error 1
> > > make: *** [sub-make] Error 2
> > --
>
>
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***

2010-11-16 21:20:47

by Zimny Lech

[permalink] [raw]
Subject: Re: nouveau build failure (was Re: Linux 2.6.37-rc2)

Salve!

2010/11/16 Ben Skeggs <[email protected]>:
> On Tue, 2010-11-16 at 12:50 -0800, Randy Dunlap wrote:
>> On Tue, 16 Nov 2010 12:45:43 -0800 Linus Torvalds wrote:
>>
>> > Looks like commit 34e9d85a1aae ("drm/nouveau: Add temperature support
>> > (vbios parsing, readings, hwmon)") didn't make things properly
>> > dependent on CONFIG_HWMON (or do the appropriate "select HWMON" or
>> > whatever).
>> >
>> > Added some collection of hopefully more relevant people to the discussion..
>> >
>> > ? ? ? ? ? ? ? ? ? Linus
>>
>>
>> This build error was reported for linux-next on 2010.1011 and 2010.1025,
>> with no replies.
>>
>> Some process fix would be nice to see.
> It's actually been fixed in the nouveau tree, I have to go through and
> get fixes out of it and send them to Dave.

thanks for the info

>
> Ben.
>>
>>
>> > On Tue, Nov 16, 2010 at 12:35 PM, Zimny Lech
>> > <[email protected]> wrote:
>> > >
>> > > ?LD ? ? ?vmlinux.o
>> > > ?MODPOST vmlinux.o
>> > > WARNING: modpost: Found 7 section mismatch(es).
>> > > To see full details build your kernel with:
>> > > 'make CONFIG_DEBUG_SECTION_MISMATCH=y'
>> > > ?GEN ? ? .version
>> > > ?CHK ? ? include/generated/compile.h
>> > > ?UPD ? ? include/generated/compile.h
>> > > ?CC ? ? ?init/version.o
>> > > ?LD ? ? ?init/built-in.o
>> > > ?LD ? ? ?.tmp_vmlinux1
>> > > drivers/built-in.o: In function `nouveau_pm_fini':
>> > > (.text+0xe1857): undefined reference to `hwmon_device_unregister'
>> > > drivers/built-in.o: In function `nouveau_pm_init':
>> > > (.text+0xe1b4d): undefined reference to `hwmon_device_register'
>> > > drivers/built-in.o: In function `nouveau_pm_init':
>> > > (.text+0xe1bef): undefined reference to `hwmon_device_unregister'
>> > > make[1]: *** [.tmp_vmlinux1] Error 1
>> > > make: *** [sub-make] Error 2
>> > --
>>
>>
>> ---
>> ~Randy
>> *** Remember to use Documentation/SubmitChecklist when testing your code ***
>
>
>



--
Slawa!
N.P.S.

Les fleurs du mal unfold
Comme les fleurs du mal
Dark demons of my soul
Un amour fatal

2010-11-17 01:44:44

by Ben Skeggs

[permalink] [raw]
Subject: Re: nouveau build failure (was Re: Linux 2.6.37-rc2)

On Wed, 2010-11-17 at 02:42 +0100, Martin Peres wrote:
> Le 16/11/2010 21:58, Ben Skeggs a écrit :
> > On Tue, 2010-11-16 at 12:50 -0800, Randy Dunlap wrote:
> >> On Tue, 16 Nov 2010 12:45:43 -0800 Linus Torvalds wrote:
> >>
> >>> Looks like commit 34e9d85a1aae ("drm/nouveau: Add temperature support
> >>> (vbios parsing, readings, hwmon)") didn't make things properly
> >>> dependent on CONFIG_HWMON (or do the appropriate "select HWMON" or
> >>> whatever).
> >>>
> >>> Added some collection of hopefully more relevant people to the discussion..
> >>>
> >>> Linus
> >>
> >> This build error was reported for linux-next on 2010.1011 and 2010.1025,
> >> with no replies.
> >>
> >> Some process fix would be nice to see.
> > It's actually been fixed in the nouveau tree, I have to go through and
> > get fixes out of it and send them to Dave.
> >
> > Ben.
> Thanks Ben, I should have checked my fix actually went in David's
> drm-fixes branch. I'll try to be more vigilent on this in the future.
Well I'm partially to blame. I'd prefer, where possible, for patches to
go through me (so, the nouveau tree) and then get them to Dave. I've
been busy working on other things lately, and missed it too :)

Ben.
>
> Martin

2010-11-17 01:48:48

by Martin Peres

[permalink] [raw]
Subject: Re: nouveau build failure (was Re: Linux 2.6.37-rc2)

Le 16/11/2010 21:58, Ben Skeggs a écrit :
> On Tue, 2010-11-16 at 12:50 -0800, Randy Dunlap wrote:
>> On Tue, 16 Nov 2010 12:45:43 -0800 Linus Torvalds wrote:
>>
>>> Looks like commit 34e9d85a1aae ("drm/nouveau: Add temperature support
>>> (vbios parsing, readings, hwmon)") didn't make things properly
>>> dependent on CONFIG_HWMON (or do the appropriate "select HWMON" or
>>> whatever).
>>>
>>> Added some collection of hopefully more relevant people to the discussion..
>>>
>>> Linus
>>
>> This build error was reported for linux-next on 2010.1011 and 2010.1025,
>> with no replies.
>>
>> Some process fix would be nice to see.
> It's actually been fixed in the nouveau tree, I have to go through and
> get fixes out of it and send them to Dave.
>
> Ben.
Thanks Ben, I should have checked my fix actually went in David's
drm-fixes branch. I'll try to be more vigilent on this in the future.

Martin