2010-11-19 05:27:09

by Anand Gadiyar

Subject: [PATCH] kernel/cpu.c - fix build warning

Patch "sched: Simplify cpu-hot-unplug task migration" in
linux-next as of 20101119 introduced the following compile
warning. Fix this.

CC kernel/cpu.o
kernel/cpu.c: In function 'take_cpu_down':
kernel/cpu.c:200: warning: unused variable 'cpu'

Signed-off-by: Anand Gadiyar <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Ingo Molnar <[email protected]>
---
Okay with me to fold this into the original patch if that's
still possible.

kernel/cpu.c | 1 -
1 file changed, 1 deletion(-)

Index: linux-2.6/kernel/cpu.c
===================================================================
--- linux-2.6.orig/kernel/cpu.c
+++ linux-2.6/kernel/cpu.c
@@ -197,7 +197,6 @@ struct take_cpu_down_param {
static int __ref take_cpu_down(void *_param)
{
struct take_cpu_down_param *param = _param;
- unsigned int cpu = (unsigned long)param->hcpu;
int err;

/* Ensure this CPU doesn't handle any more interrupts. */

2010-11-19 06:24:25

by Rakib Mullick

Subject: Re: [PATCH] kernel/cpu.c - fix build warning

On 11/19/10, Anand Gadiyar <[email protected]> wrote:
> Patch "sched: Simplify cpu-hot-unplug task migration" in
> linux-next as of 20101119 introduced the following compile
> warning. Fix this.
>
> CC kernel/cpu.o
> kernel/cpu.c: In function 'take_cpu_down':
> kernel/cpu.c:200: warning: unused variable 'cpu'
>
It's been already fixed by http://lkml.org/lkml/2010/11/18/314.


thanks,
rakib

> Signed-off-by: Anand Gadiyar <[email protected]>
> Cc: Peter Zijlstra <[email protected]>
> Cc: Ingo Molnar <[email protected]>
> ---
> Okay with me to fold this into the original patch if that's
> still possible.
>
> kernel/cpu.c | 1 -
> 1 file changed, 1 deletion(-)
>
> Index: linux-2.6/kernel/cpu.c
> ===================================================================
> --- linux-2.6.orig/kernel/cpu.c
> +++ linux-2.6/kernel/cpu.c
> @@ -197,7 +197,6 @@ struct take_cpu_down_param {
> static int __ref take_cpu_down(void *_param)
> {
> struct take_cpu_down_param *param = _param;
> - unsigned int cpu = (unsigned long)param->hcpu;
> int err;
>
> /* Ensure this CPU doesn't handle any more interrupts. */
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>