2010-11-19 15:49:33

by Aaro Koskinen

Subject: [PATCH] pm: fix comments to match runtime callback code

Commit 05aa55dddb9ee4045c320661068bea78dad6a6e5 changed routines to
succeed if the driver handler is not defined. Comments were not updated.

Signed-off-by: Aaro Koskinen <[email protected]>
---
drivers/base/power/generic_ops.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/base/power/generic_ops.c b/drivers/base/power/generic_ops.c
index 81f2c84..3d2c350 100644
--- a/drivers/base/power/generic_ops.c
+++ b/drivers/base/power/generic_ops.c
@@ -39,7 +39,7 @@ EXPORT_SYMBOL_GPL(pm_generic_runtime_idle);
*
* If PM operations are defined for the @dev's driver and they include
* ->runtime_suspend(), execute it and return its error code. Otherwise,
- * return -EINVAL.
+ * return 0.
*/
int pm_generic_runtime_suspend(struct device *dev)
{
@@ -58,7 +58,7 @@ EXPORT_SYMBOL_GPL(pm_generic_runtime_suspend);
*
* If PM operations are defined for the @dev's driver and they include
* ->runtime_resume(), execute it and return its error code. Otherwise,
- * return -EINVAL.
+ * return 0.
*/
int pm_generic_runtime_resume(struct device *dev)
{
--
1.5.6.5

2010-11-26 22:05:02

by Rafael J. Wysocki

Subject: Re: [PATCH] pm: fix comments to match runtime callback code

On Friday, November 19, 2010, Aaro Koskinen wrote:
> Commit 05aa55dddb9ee4045c320661068bea78dad6a6e5 changed routines to
> succeed if the driver handler is not defined. Comments were not updated.

Applied to suspend-2.6/linux-next.

Thanks,
Rafael


> Signed-off-by: Aaro Koskinen <[email protected]>
> ---
> drivers/base/power/generic_ops.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/base/power/generic_ops.c b/drivers/base/power/generic_ops.c
> index 81f2c84..3d2c350 100644
> --- a/drivers/base/power/generic_ops.c
> +++ b/drivers/base/power/generic_ops.c
> @@ -39,7 +39,7 @@ EXPORT_SYMBOL_GPL(pm_generic_runtime_idle);
> *
> * If PM operations are defined for the @dev's driver and they include
> * ->runtime_suspend(), execute it and return its error code. Otherwise,
> - * return -EINVAL.
> + * return 0.
> */
> int pm_generic_runtime_suspend(struct device *dev)
> {
> @@ -58,7 +58,7 @@ EXPORT_SYMBOL_GPL(pm_generic_runtime_suspend);
> *
> * If PM operations are defined for the @dev's driver and they include
> * ->runtime_resume(), execute it and return its error code. Otherwise,
> - * return -EINVAL.
> + * return 0.
> */
> int pm_generic_runtime_resume(struct device *dev)
> {
>