2010-11-20 12:01:40

by Mariusz Kozlowski

Subject: [PATCH] backlight: make 1-bit signed filed unsigned in l4f00242t03.c

Fixes sparse warning:
drivers/video/backlight/l4f00242t03.c:28:21: error: dubious one-bit
signed bitfield

Signed-off-by: Mariusz Kozlowski <[email protected]>
---
drivers/video/backlight/l4f00242t03.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/backlight/l4f00242t03.c b/drivers/video/backlight/l4f00242t03.c
index c67801e..6d9ba0e 100644
--- a/drivers/video/backlight/l4f00242t03.c
+++ b/drivers/video/backlight/l4f00242t03.c
@@ -25,7 +25,7 @@
struct l4f00242t03_priv {
struct spi_device *spi;
struct lcd_device *ld;
- int lcd_on:1;
+ unsigned int lcd_on:1;
struct regulator *io_reg;
struct regulator *core_reg;
};
--
1.7.0.4

2010-11-22 10:07:12

by Richard Purdie

Subject: Re: [PATCH] backlight: make 1-bit signed filed unsigned in l4f00242t03.c

On Sat, 2010-11-20 at 13:01 +0100, Mariusz Kozlowski wrote:
> Fixes sparse warning:
> drivers/video/backlight/l4f00242t03.c:28:21: error: dubious one-bit
> signed bitfield
>
> Signed-off-by: Mariusz Kozlowski <[email protected]>
Acked-by: Richard Purdie <[email protected]>
> ---
> drivers/video/backlight/l4f00242t03.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/backlight/l4f00242t03.c b/drivers/video/backlight/l4f00242t03.c
> index c67801e..6d9ba0e 100644
> --- a/drivers/video/backlight/l4f00242t03.c
> +++ b/drivers/video/backlight/l4f00242t03.c
> @@ -25,7 +25,7 @@
> struct l4f00242t03_priv {
> struct spi_device *spi;
> struct lcd_device *ld;
> - int lcd_on:1;
> + unsigned int lcd_on:1;
> struct regulator *io_reg;
> struct regulator *core_reg;
> };