2010-11-24 21:48:18

by Dmitry Artamonow

Subject: [PATCH] ASoC: fix SND_PXA2XX_LIB Kconfig warning

Fix following warning observed when SND_PXA2XX_SOC is set and SND_ARM isn't:

warning: (SND_PXA2XX_AC97 && SOUND && !M68K && SND && SND_ARM && ARCH_PXA ||
SND_PXA2XX_SOC && SOUND && !M68K && SND && SND_SOC && ARCH_PXA) selects
SND_PXA2XX_LIB which has unmet direct dependencies (SOUND && !M68K && SND &&
SND_ARM)

Signed-off-by: Dmitry Artamonow <[email protected]>
---

This is fix for 2.6.37-rc3

sound/soc/pxa/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sound/soc/pxa/Kconfig b/sound/soc/pxa/Kconfig
index 37f191b..580f485 100644
--- a/sound/soc/pxa/Kconfig
+++ b/sound/soc/pxa/Kconfig
@@ -1,6 +1,7 @@
config SND_PXA2XX_SOC
tristate "SoC Audio for the Intel PXA2xx chip"
depends on ARCH_PXA
+ select SND_ARM
select SND_PXA2XX_LIB
help
Say Y or M if you want to add support for codecs attached to
--
1.7.0.4

2010-11-25 10:28:47

by Liam Girdwood

Subject: Re: [alsa-devel] [PATCH] ASoC: fix SND_PXA2XX_LIB Kconfig warning

On Thu, 2010-11-25 at 00:46 +0300, Dmitry Artamonow wrote:
> Fix following warning observed when SND_PXA2XX_SOC is set and SND_ARM isn't:
>
> warning: (SND_PXA2XX_AC97 && SOUND && !M68K && SND && SND_ARM && ARCH_PXA ||
> SND_PXA2XX_SOC && SOUND && !M68K && SND && SND_SOC && ARCH_PXA) selects
> SND_PXA2XX_LIB which has unmet direct dependencies (SOUND && !M68K && SND &&
> SND_ARM)
>
> Signed-off-by: Dmitry Artamonow <[email protected]>
> ---
>
> This is fix for 2.6.37-rc3
>
> sound/soc/pxa/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/pxa/Kconfig b/sound/soc/pxa/Kconfig
> index 37f191b..580f485 100644
> --- a/sound/soc/pxa/Kconfig
> +++ b/sound/soc/pxa/Kconfig
> @@ -1,6 +1,7 @@
> config SND_PXA2XX_SOC
> tristate "SoC Audio for the Intel PXA2xx chip"
> depends on ARCH_PXA
> + select SND_ARM
> select SND_PXA2XX_LIB
> help
> Say Y or M if you want to add support for codecs attached to

Acked-by: Liam Girdwood <[email protected]>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

2010-11-25 11:13:32

by Mark Brown

Subject: Re: [PATCH] ASoC: fix SND_PXA2XX_LIB Kconfig warning

On Thu, Nov 25, 2010 at 12:46:15AM +0300, Dmitry Artamonow wrote:
> Fix following warning observed when SND_PXA2XX_SOC is set and SND_ARM isn't:
>
> warning: (SND_PXA2XX_AC97 && SOUND && !M68K && SND && SND_ARM && ARCH_PXA ||
> SND_PXA2XX_SOC && SOUND && !M68K && SND && SND_SOC && ARCH_PXA) selects
> SND_PXA2XX_LIB which has unmet direct dependencies (SOUND && !M68K && SND &&
> SND_ARM)
>
> Signed-off-by: Dmitry Artamonow <[email protected]>

Applied, thanks.