2010-11-29 06:49:27

by Axel Lin

Subject: [PATCH 1/2] ASoC: Add missing dev_set_drvdata in mpc8610_hpcd_probe

Otherwise, calling dev_get_drvdata in mpc8610_hpcd_remove returns NULL.

Signed-off-by: Axel Lin <[email protected]>
---
sound/soc/fsl/mpc8610_hpcd.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sound/soc/fsl/mpc8610_hpcd.c b/sound/soc/fsl/mpc8610_hpcd.c
index 0d7dcf1..7d7847a 100644
--- a/sound/soc/fsl/mpc8610_hpcd.c
+++ b/sound/soc/fsl/mpc8610_hpcd.c
@@ -498,6 +498,7 @@ static int mpc8610_hpcd_probe(struct platform_device *pdev)
dev_err(&pdev->dev, "platform device add failed\n");
goto error;
}
+ dev_set_drvdata(&pdev->dev, sound_device);

of_node_put(codec_np);

--
1.7.2

2010-11-29 06:50:26

by Axel Lin

Subject: [PATCH 2/2] ASoC: Add missing dev_set_drvdata in p1022_ds_probe

Otherwise, calling dev_get_drvdata in p1022_ds_remove returns NULL.

Signed-off-by: Axel Lin <[email protected]>
---
sound/soc/fsl/p1022_ds.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sound/soc/fsl/p1022_ds.c b/sound/soc/fsl/p1022_ds.c
index 63b9eaa..026b756 100644
--- a/sound/soc/fsl/p1022_ds.c
+++ b/sound/soc/fsl/p1022_ds.c
@@ -498,6 +498,7 @@ static int p1022_ds_probe(struct platform_device *pdev)
dev_err(&pdev->dev, "platform device add failed\n");
goto error;
}
+ dev_set_drvdata(&pdev->dev, sound_device);

of_node_put(codec_np);

--
1.7.2

2010-11-29 11:08:50

by Liam Girdwood

Subject: Re: [PATCH 1/2] ASoC: Add missing dev_set_drvdata in mpc8610_hpcd_probe

On Mon, 2010-11-29 at 14:54 +0800, Axel Lin wrote:
> Otherwise, calling dev_get_drvdata in mpc8610_hpcd_remove returns NULL.
>
> Signed-off-by: Axel Lin <[email protected]>
> ---
> sound/soc/fsl/mpc8610_hpcd.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/fsl/mpc8610_hpcd.c b/sound/soc/fsl/mpc8610_hpcd.c
> index 0d7dcf1..7d7847a 100644
> --- a/sound/soc/fsl/mpc8610_hpcd.c
> +++ b/sound/soc/fsl/mpc8610_hpcd.c
> @@ -498,6 +498,7 @@ static int mpc8610_hpcd_probe(struct platform_device *pdev)
> dev_err(&pdev->dev, "platform device add failed\n");
> goto error;
> }
> + dev_set_drvdata(&pdev->dev, sound_device);
>
> of_node_put(codec_np);
>

All

Acked-by: Liam Girdwood <[email protected]>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

2010-11-29 14:54:04

by Timur Tabi

Subject: Re: [PATCH 1/2] ASoC: Add missing dev_set_drvdata in mpc8610_hpcd_probe

Axel Lin wrote:
> Otherwise, calling dev_get_drvdata in mpc8610_hpcd_remove returns NULL.
>
> Signed-off-by: Axel Lin <[email protected]>

Both patches:

Acked-by: Timur Tabi <[email protected]>

Thanks for catching this.

--
Timur Tabi
Linux kernel developer at Freescale

2010-11-29 16:12:23

by Mark Brown

Subject: Re: [PATCH 1/2] ASoC: Add missing dev_set_drvdata in mpc8610_hpcd_probe

On Mon, Nov 29, 2010 at 08:53:48AM -0600, Timur Tabi wrote:
> Axel Lin wrote:
> > Otherwise, calling dev_get_drvdata in mpc8610_hpcd_remove returns NULL.
> >
> > Signed-off-by: Axel Lin <[email protected]>

> Both patches:

> Acked-by: Timur Tabi <[email protected]>

Applied now.