2010-12-01 06:32:44

by Axel Lin

Subject: [PATCH] ASoC: Remove unused aic3x_i2c_init and aic3x_i2c_exit functions

Signed-off-by: Axel Lin <[email protected]>
---
sound/soc/codecs/tlv320aic3x.c | 15 ---------------
1 files changed, 0 insertions(+), 15 deletions(-)

diff --git a/sound/soc/codecs/tlv320aic3x.c b/sound/soc/codecs/tlv320aic3x.c
index fc5abdf..8cd4cf5 100644
--- a/sound/soc/codecs/tlv320aic3x.c
+++ b/sound/soc/codecs/tlv320aic3x.c
@@ -1545,21 +1545,6 @@ static struct i2c_driver aic3x_i2c_driver = {
.remove = aic3x_i2c_remove,
.id_table = aic3x_i2c_id,
};
-
-static inline void aic3x_i2c_init(void)
-{
- int ret;
-
- ret = i2c_add_driver(&aic3x_i2c_driver);
- if (ret)
- printk(KERN_ERR "%s: error regsitering i2c driver, %d\n",
- __func__, ret);
-}
-
-static inline void aic3x_i2c_exit(void)
-{
- i2c_del_driver(&aic3x_i2c_driver);
-}
#endif

static int __init aic3x_modinit(void)
--
1.7.2

2010-12-01 07:42:41

by Jarkko Nikula

Subject: Re: [PATCH] ASoC: Remove unused aic3x_i2c_init and aic3x_i2c_exit functions

On Wed, 01 Dec 2010 14:38:24 +0800
Axel Lin <[email protected]> wrote:

> Signed-off-by: Axel Lin <[email protected]>
> ---
> sound/soc/codecs/tlv320aic3x.c | 15 ---------------
> 1 files changed, 0 insertions(+), 15 deletions(-)
>
> diff --git a/sound/soc/codecs/tlv320aic3x.c b/sound/soc/codecs/tlv320aic3x.c
> index fc5abdf..8cd4cf5 100644
> --- a/sound/soc/codecs/tlv320aic3x.c
> +++ b/sound/soc/codecs/tlv320aic3x.c
> @@ -1545,21 +1545,6 @@ static struct i2c_driver aic3x_i2c_driver = {
> .remove = aic3x_i2c_remove,
> .id_table = aic3x_i2c_id,
> };
> -
> -static inline void aic3x_i2c_init(void)
> -{
> - int ret;
> -
> - ret = i2c_add_driver(&aic3x_i2c_driver);
> - if (ret)
> - printk(KERN_ERR "%s: error regsitering i2c driver, %d\n",
> - __func__, ret);
> -}
> -
> -static inline void aic3x_i2c_exit(void)
> -{
> - i2c_del_driver(&aic3x_i2c_driver);
> -}
> #endif
>
True, these are unused nowadays.

Acked-by: Jarkko Nikula <[email protected]>

2010-12-01 11:28:24

by Mark Brown

Subject: Re: [PATCH] ASoC: Remove unused aic3x_i2c_init and aic3x_i2c_exit functions

On Wed, Dec 01, 2010 at 02:38:24PM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <[email protected]>

Acked-by: Mark Brown <[email protected]>

2010-12-02 11:52:32

by Liam Girdwood

Subject: Re: [PATCH] ASoC: Remove unused aic3x_i2c_init and aic3x_i2c_exit functions

On Wed, 2010-12-01 at 14:38 +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <[email protected]>
> ---
> sound/soc/codecs/tlv320aic3x.c | 15 ---------------
> 1 files changed, 0 insertions(+), 15 deletions(-)
>

Applied.

Thanks

Liam

--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk