2010-12-02 14:07:37

by Mattias Wallin

Subject: [PATCH] MFD: ab8500-core interrupt ffs bit bug

This patch fixes a bug in ab8500 interrupt handling

Signed-off-by: Mattias Wallin <[email protected]>
---
drivers/mfd/ab8500-core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd/ab8500-core.c
index dbe1c93..d9640a6 100644
--- a/drivers/mfd/ab8500-core.c
+++ b/drivers/mfd/ab8500-core.c
@@ -303,7 +303,7 @@ static irqreturn_t ab8500_irq(int irq, void *dev)
continue;

do {
- int bit = __ffs(status);
+ int bit = __ffs(value);
int line = i * 8 + bit;

handle_nested_irq(ab8500->irq_base + line);
--
1.7.2.2

2010-12-09 12:13:22

by Samuel Ortiz

Subject: Re: [PATCH] MFD: ab8500-core interrupt ffs bit bug

Hi Mattias,

On Thu, Dec 02, 2010 at 03:06:49PM +0100, Mattias Wallin wrote:
> This patch fixes a bug in ab8500 interrupt handling
Patch applied. This also looks like a good candidate for 2.6.37.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/

2010-12-10 08:19:04

by Mattias Wallin

Subject: Re: [PATCH] MFD: ab8500-core interrupt ffs bit bug

On 12/09/2010 01:13 PM, Samuel Ortiz wrote:
> Hi Mattias,
>
> On Thu, Dec 02, 2010 at 03:06:49PM +0100, Mattias Wallin wrote:
>> This patch fixes a bug in ab8500 interrupt handling
> Patch applied. This also looks like a good candidate for 2.6.37.
I agree, AB8500 interrupts gets lost without this patch so the error is bad.
Do you want me to do anything for this to happen?
>
> Cheers,
> Samuel.
>

2010-12-10 09:42:19

by Samuel Ortiz

Subject: Re: [PATCH] MFD: ab8500-core interrupt ffs bit bug

On Fri, Dec 10, 2010 at 09:18:55AM +0100, Mattias Wallin wrote:
>
>
> On 12/09/2010 01:13 PM, Samuel Ortiz wrote:
> > Hi Mattias,
> >
> > On Thu, Dec 02, 2010 at 03:06:49PM +0100, Mattias Wallin wrote:
> >> This patch fixes a bug in ab8500 interrupt handling
> > Patch applied. This also looks like a good candidate for 2.6.37.
> I agree, AB8500 interrupts gets lost without this patch so the error is bad.
> Do you want me to do anything for this to happen?
No, the patch is already in my for-linus branch.

Cheers,
Samuel.


> >
> > Cheers,
> > Samuel.
> >

--
Intel Open Source Technology Centre
http://oss.intel.com/