2010-12-07 14:49:19

by Namhyung Kim

Subject: [PATCH] isdn/hisax: fix compiler warning on hisax_pci_tbl

Annotate hisax_pci_tbl as '__used' to fix following warning:

CC drivers/isdn/hisax/config.o
drivers/isdn/hisax/config.c:1920: warning: ‘hisax_pci_tbl’ defined but not used

Signed-off-by: Namhyung Kim <[email protected]>
---
drivers/isdn/hisax/config.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/isdn/hisax/config.c b/drivers/isdn/hisax/config.c
index b133378..c110f86 100644
--- a/drivers/isdn/hisax/config.c
+++ b/drivers/isdn/hisax/config.c
@@ -1917,7 +1917,7 @@ static void EChannel_proc_rcv(struct hisax_d_if *d_if)
#ifdef CONFIG_PCI
#include <linux/pci.h>

-static struct pci_device_id hisax_pci_tbl[] __devinitdata = {
+static struct pci_device_id hisax_pci_tbl[] __devinitdata __used = {
#ifdef CONFIG_HISAX_FRITZPCI
{PCI_VDEVICE(AVM, PCI_DEVICE_ID_AVM_A1) },
#endif
--
1.7.0.4

2010-12-08 18:50:39

by David Miller

Subject: Re: [PATCH] isdn/hisax: fix compiler warning on hisax_pci_tbl

From: Namhyung Kim <[email protected]>
Date: Tue, 7 Dec 2010 23:49:06 +0900

> Annotate hisax_pci_tbl as '__used' to fix following warning:
>
> CC drivers/isdn/hisax/config.o
> drivers/isdn/hisax/config.c:1920: warning: ?hisax_pci_tbl? defined but not used
>
> Signed-off-by: Namhyung Kim <[email protected]>

This only happens because the hisax driver doesn't actually use this table
for probing. Each sub-driver does it's own thing.

What a mess.

Anyways, applied, thank you.
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?